Merge pull request #35 from HossamSaberr/api-alignment

Refactor: Align creation APIs and close resolved issues

Author: jordanmontt

src/Containers-Array2D-Tests/CTNewArray2DTest.class.st

@@ -171,6 +171,51 @@ CTNewArray2DTest >> testFromRightToLeftFromTopToBottomDo [
 	self assert: res equals: #(2 1 4 3 6 5) asOrderedCollection
 ]
 
+{ #category : 'tests' }
+CTNewArray2DTest >> testFromRowsPad [
+	| array |
+	array := self arrayClass fromRows: #( #(1 2) #(3 4 5) #(6) ) pad: 0.
+	
+	self assert: array width equals: 3.
+	self assert: array height equals: 3.
+	self assert: (array atRow: 1) equals: #(1 2 0).
+	self assert: (array atRow: 2) equals: #(3 4 5).
+	self assert: (array atRow: 3) equals: #(6 0 0).
+]
+
+{ #category : 'tests' }
+CTNewArray2DTest >> testFromRowsPadNoPaddingNeeded [
+	| array |
+	array := self arrayClass fromRows: #( #(1 2) #(3 4) ) pad: 99.
+	
+	self assert: array width equals: 2.
+	self assert: array height equals: 2.
+	self assert: (array atRow: 1) equals: #(1 2).
+	self assert: (array atRow: 2) equals: #(3 4).
+]
+
+{ #category : 'tests' }
+CTNewArray2DTest >> testFromRowsPadWithCharacters [
+	| array |
+	array := self arrayClass fromRows: #( #($a $b) #($c) ) pad: $x.
+	
+	self assert: array width equals: 2.
+	self assert: array height equals: 2.
+	self assert: (array atRow: 1) equals: #($a $b).
+	self assert: (array atRow: 2) equals: #($c $x).
+]
+
+{ #category : 'tests' }
+CTNewArray2DTest >> testFromRowsPadWithNil [
+	| array |
+	array := self arrayClass fromRows: #( #(1) #(2 3) ) pad: nil.
+	
+	self assert: array width equals: 2.
+	self assert: array height equals: 2.
+	self assert: (array atRow: 1) equals: #(1 nil).
+	self assert: (array atRow: 2) equals: #(2 3).
+]
+
 { #category : 'tests' }
 CTNewArray2DTest >> testFromTopToBottomFromLeftToRightDo [
 	|foo res|

src/Containers-Array2D/CTNewArray2D.class.st

@@ -42,6 +42,21 @@ CTNewArray2D class >> fromArray: aCollection width: aSize [
 
 ]
 
+{ #category : 'instance creation' }
+CTNewArray2D class >> fromRows: rows pad: paddingElement [
+	| width contents pad |
+	width := rows max: [ :row | row size ].
+	contents := rows first species new: (width * rows size) streamContents: [ :aStream |
+		rows do: [  :row |
+			aStream nextPutAll: row.
+			pad := width - row size.
+			pad > 0 ifTrue: [ aStream next: pad put: paddingElement ].
+		]
+	].
+
+	^ self fromArray: contents width: width
+]
+
 { #category : 'instance creation' }
 CTNewArray2D class >> new [