Skip to content

Conversation

@YannickChevalier
Copy link

Addition of a add: anElement unless: aPresentelementSatisties adds a new element unless the block evaluates to true on an existing element. A principal motivation is the addition of an element unless it is already present in the queue.

…new element unless the block evaluates to true on an existing element. A principal motivation is the addition of an element unless it is already present in the queue.
…tation-improvements

Improve Queue DS Implementation, Tests, Workflows & Readme
@jordanmontt
Copy link
Member

Sorry, we missed this PR and not it has conflicts. Could you please fix them if possible? Like that we can review this PR.

@YannickChevalier
Copy link
Author

I have changed the implementation to match the new one

@Ducasse
Copy link
Collaborator

Ducasse commented Jan 14, 2026

Hello Yannick happy new year.
Great to see some commits (we missed the previous and I feel bad about it).
I launched the CI.
I saw that you remove peek so apparently it was not tested :)

@Ducasse Ducasse merged commit 536f974 into pharo-containers:master Jan 14, 2026
15 checks passed
@github-actions
Copy link

Pull Request Test Coverage Report for Build 21003044264

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 142 of 148 (95.95%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-3.6%) to 96.429%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Containers-Queue/CTQueue.class.st 142 148 95.95%
Totals Coverage Status
Change from base Build 14791745891: -3.6%
Covered Lines: 162
Relevant Lines: 168

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants