Use enumerations as shared pools?

[tinchodias]

For example:

It may look clearer. I'm quite sure @estebanlm agrees... do you?

[tinchodias]

BTW, checking evt type this way is mostly for small demos, I've implemented a visitor for events for other more complex use cases (inspired on SDL2 bindings).

This is the method in SDL3MappedEvent:

type
	^ SDL3EventType fromInteger: self typeNumber

So, this means wrapping the integer into a enumeration instance only to compare it... it would save cycles to just compare the integers. But you can see for SDLK_ESCAPE that anyway we have to send asInteger to get the value.

[tinchodias]

Maybe an alternative implementation of FFIEnumeration can be more similar to the constants shared pool, and avoid wrapping the integers, and be more performant. I mean, to achieve something like:

... where we just compare integers without wrapping.

[estebanlm]

FFI Enumerations are already SharedPools and can be used as such :)
But of course, you have to include the SharedPools into your classPools.

EDIT: but yes, I agree :)

[tinchodias]

I didn't look at the class hierarchy of enums until this week! as variables I have to recognize the UPPERCASE_NAMES are not so ugly as with methods (for methods I think they must be camelCase always even in FFI)

[tinchodias]

What about a FFIEnumeration that doesn't wrap the integers as FFIEnumeration instances? In such case, the typedef should initialize the enumeration name as a uint?

[estebanlm]

What about a FFIEnumeration that doesn't wrap the integers as FFIEnumeration instances? In such case, the typedef should initialize the enumeration name as a uint?

that is not how uFFI is supposed to work ;)

[tinchodias]

El mié, 1 abr 2026 a la(s) 1:17 p.m., Esteban Lorenzano ( ***@***.***) escribió:

*estebanlm* left a comment (pharo-graphics/PharoSDL3#48) <#48 (comment)> What about a FFIEnumeration that doesn't wrap the integers as FFIEnumeration instances? In such case, the typedef should initialize the enumeration name as a uint? that is not how uFFI is supposed to work ;)

How to see it? I see that enum items are wrapped in P14

…

— Reply to this email directly, view it on GitHub <#48?email_source=notifications&email_token=AAXHHKJYHGSCBEFU4FDM5M34TU6IVA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJXGEZDEMRSGQZKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-4171222242>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAXHHKKKOYAWPQ6TIWK2VWT4TU6IVAVCNFSM6AAAAACXIKLNHKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DCNZRGIZDEMRUGI> . You are receiving this because you authored the thread.Message ID: ***@***.***>