Merge pull request #16486 from tesonep/remove-redundant-allocations-while-compiling

During compilation there are redundant allocation of collections

Author: estebanlm

src/Files/AbstractBinaryFileStream.class.st

@@ -178,12 +178,19 @@ AbstractBinaryFileStream >> next: n into: aString startingAt: startIndex [
 
 { #category : 'writing' }
 AbstractBinaryFileStream >> next: amount putAll: aByteArray [
+
+	^ self next: amount putAll: aByteArray startingAt: 1
+]
+
+{ #category : 'accessing' }
+AbstractBinaryFileStream >> next: amount putAll: aByteArray startingAt: startingIndex [
+
 	forWrite
 		ifFalse: [ ^ self error: 'Cannot write a read-only file' ].
 	[ File
 		write: handle
 		from: aByteArray
-		startingAt: 1
+		startingAt: startingIndex
 		count: amount ]
 		on: PrimitiveFailed
 		do: [ (FileWriteError fileName: self name)

src/System-Sources/ChunkWriteStream.class.st

@@ -38,18 +38,25 @@ ChunkWriteStream >> duplicateTerminatorMarkOn: aString [
 
 	| string start bangIndex newStringStream |
 	string := aString asString.
-	newStringStream := WriteStream on: (string species new: string size * 2).
 	start := 1.
+	bangIndex := string indexOf: self terminatorMark startingAt: start.
+	
+	"We check the bang ahead, so we can avoid two allocations of the string!"
+	(bangIndex = 0) 
+		ifTrue: [ ^ string copyWith: self terminatorMark ].
+
+	newStringStream := WriteStream on: (string species new: string size * 2).
 
-	[ (bangIndex := string indexOf: self terminatorMark startingAt: start) = 0 ]
+	[ bangIndex = 0 ]
 		whileFalse: [
 			newStringStream
 				next: bangIndex - start + 1
 				putAll: string
 				startingAt: start.
 
 			newStringStream nextPut: self terminatorMark. "double it"
-			start := bangIndex + 1 ].
+			start := bangIndex + 1.
+			bangIndex := string indexOf: self terminatorMark startingAt: start ].
 
 	newStringStream
 		next: string size - start + 1