Merge pull request #16503 from jecisc/misc/improve-tests

Clean System-Announcements-Tests

Author: guillep

src/Announcements-Core-Tests/AnnouncerTest.class.st

@@ -334,6 +334,44 @@ AnnouncerTest >> testSubscribersForClass [
 	self assert: subscribers size equals: 0
 ]
 
+{ #category : 'tests' }
+AnnouncerTest >> testSuspendAllWhile [
+
+	| value |
+	value := 42.
+
+	announcer suspendAllWhile: [
+		announcer
+			when: AnnouncementMockA do: [ value := value + 1 ] for: self;
+			announce: AnnouncementMockA ].
+
+	self assert: value equals: 42. "The answer is always 42 :)"
+
+	announcer announce: AnnouncementMockA.
+
+	self assert: value equals: 43
+]
+
+{ #category : 'tests' }
+AnnouncerTest >> testSuspendAllWhileStoring [
+
+	| stored |
+	stored := announcer suspendAllWhileStoring: [ announcer announce: AnnouncementMockA ].
+
+	self assert: stored size equals: 1.
+	self assert: (stored at: 1) equals: AnnouncementMockA
+]
+
+{ #category : 'tests' }
+AnnouncerTest >> testSuspendAllWhileStoringNested [
+
+	| stored |
+	stored := announcer suspendAllWhileStoring: [ announcer suspendAllWhileStoring: [ announcer announce: AnnouncementMockA ] ].
+
+	self assert: stored size equals: 1.
+	self assert: (stored at: 1) equals: AnnouncementMockA
+]
+
 { #category : 'tests' }
 AnnouncerTest >> testSymbolIdentifier [
 	| passed |

src/BaselineOfBasicTools/BaselineOfBasicTools.class.st

@@ -75,7 +75,7 @@ BaselineOfBasicTools >> baseline: spec [
 			package: 'Monticello-GUI-Diff'
 			with: [ spec requires: #( 'Tool-Diff' 'MonticelloGUI' ) ].
 		spec package: 'System-Sources-Tests'. "<= Not sure this one should be here but it is where the classes were loaded before been extracted from Tests package."
-		spec package: 'System-Announcements-Tests'. "<= Not sure this one should be here but it is where the classes were loaded before been extracted from Tests package."
+
 		spec package: 'Kernel-CodeModel-Tests'.
 		spec package: 'Monticello-Tests'.
 		spec package: 'MonticelloGUI-Tests'.

src/ReleaseTests/ReleaseTest.class.st

@@ -289,6 +289,18 @@ ReleaseTest >> testMethodsContainNoHalt [
 				print: methods ] ]
 ]
 
+{ #category : 'tests - announcer' }
+ReleaseTest >> testNoDeadSubscriptions [
+
+	| dead |
+	"we skiped this on the ci in the past: https://github.com/pharo-project/pharo/issues/2471"
+	3 timesRepeat: [ Smalltalk garbageCollect ].
+
+	dead := self class codeChangeAnnouncer subscriptions subscriptions select: [ :sub | sub subscriber isNil ].
+
+	self assert: dead asArray equals: #(  )
+]
+
 { #category : 'tests' }
 ReleaseTest >> testNoEmptyPackages [
 	"Test that we have no empty packages left"
@@ -415,6 +427,16 @@ ReleaseTest >> testObsoleteClasses [
 					print: obsoleteClasses ]]
 ]
 
+{ #category : 'tests - announcer' }
+ReleaseTest >> testOnlyWeakSubscriptions [
+
+	| strong |
+	"only weak subscriptions should be allowed to be added to the SystemAnnouncer..."
+	strong := self class codeChangeAnnouncer subscriptions subscriptions reject: [ :each | each isKindOf: WeakAnnouncementSubscription ].
+
+	self assert: strong asArray equals: #(  )
+]
+
 { #category : 'tests - package' }
 ReleaseTest >> testPackageOrganizer [
 	"Ensure other tests temporary created organizers are collected"