Skip to content

Commit 04f7d54

Browse files
authored
Merge pull request #123 from jecisc/error-messages
Improve error messages
2 parents e1dfa3f + c9153a8 commit 04f7d54

File tree

4 files changed

+17
-6
lines changed

4 files changed

+17
-6
lines changed

.github/scripts/preLoading.st

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,2 @@
11
IceRepository registry remove: (IceRepository repositoryNamed: #tonel).
2-
#( 'BaselineOfTonel' ) do: [ :each |
3-
(RPackageOrganizer default packageNamed: each ifAbsent: [ nil ])
4-
ifNotNil: [ :aPackage | aPackage removeFromSystem ] ]
2+
#( 'BaselineOfTonel' ) do: [ :each | (each asPackageIfAbsent: [ nil ]) ifNotNil: #removeFromSystem ]

.gitignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
2+
**/.DS_Store
3+

MonticelloTonel-Core.package/TonelReader.class/instance/loadDefinitions.st

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,10 @@ loadDefinitions
33

44
| definitionOrders newDefinitions tagNames |
55
definitionOrders := self class definitionOrders.
6-
newDefinitions := ((self packageDirectory entries select: [ :each | self canBeLoaded: each ]) collect: [ :each |
7-
each readStreamDo: [ :s | TonelParser parseStream: s ] ]) flattened sort: [ :a :b |
8-
(definitionOrders at: a class) < (definitionOrders at: b class) ].
6+
7+
newDefinitions := ((self packageDirectory entries select: [ :file | self canBeLoaded: file ]) collect: [ :file | self parseTonelFile: file ]) flattened sort: [
8+
:a
9+
:b | (definitionOrders at: a class) < (definitionOrders at: b class) ].
910

1011
self ensurePackagesAndTagsOfDefinitions: newDefinitions.
1112

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
loading
2+
parseTonelFile: file
3+
"In case of error we add the info of the file that produced the error for a better debugging experience."
4+
5+
^ [ file readStreamDo: [ :aStream | TonelParser parseStream: aStream ] ]
6+
on: TonelParseError
7+
do: [ :error |
8+
error messageText: 'Error while parsing ' , file basename , ': ' , error messageText.
9+
error pass ]

0 commit comments

Comments
 (0)