Skip to content

Commit c3370ec

Browse files
committed
Fix handling of SQLite build argument
1 parent ebf092d commit c3370ec

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

build.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ CLI_VERSION=${1:-8.3}
77

88
# Install SQLite 3.x for Drupal 11 testing if CLI version >= 8.3
99
INSTALL_SQLITE=false
10+
# Use the `bc` calculator to compare the PHP version number.
1011
if [ "$(echo "${CLI_VERSION} >= 8.3" | bc -l)" -eq 1 ]; then
1112
INSTALL_SQLITE=true
1213
fi

src/Dockerfile

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,9 @@ RUN curl https://awscli.amazonaws.com/awscli-exe-linux-"$(uname -m)".zip -o "aws
4242
RUN wget https://github.com/mikefarah/yq/releases/download/v4.21.1/yq_linux_"$(dpkg --print-architecture)".tar.gz -O - |\
4343
tar xz && mv yq_linux_"$(dpkg --print-architecture)" /usr/bin/yq
4444

45-
# Upgrade SQLite 3.x for Drupal 11 testing if CLI version >= 8.3
45+
# Upgrade SQLite 3.x if specified in the build args.
4646
# @see https://www.drupal.org/project/drupal/issues/3346338
4747
# @see https://github.com/docksal/service-cli/pull/327/files
48-
# Use the `bc` calculator to compare the PHP version number, removing the `php` prefix.
4948
# Need to get sqlite3 from the Debian testing repository as the default version is too old.
5049
RUN if [ "$INSTALL_SQLITE" = "true" ]; then \
5150
set -xe; \

0 commit comments

Comments
 (0)