Skip to content

Commit cb8bdc8

Browse files
committed
ui race condition fixes
1 parent 844cceb commit cb8bdc8

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

src/Mod/CAM/Path/Main/Gui/Job.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -224,6 +224,7 @@ def deleteObjectsOnReject(self):
224224
return hasattr(self, "deleteOnReject") and self.deleteOnReject
225225

226226
def setEdit(self, vobj=None, mode=0):
227+
self.taskPanel = None
227228
Path.Log.track(mode)
228229
if 0 == mode:
229230
job = self.vobj.Object
@@ -233,8 +234,8 @@ def setEdit(self, vobj=None, mode=0):
233234
return True
234235

235236
def openTaskPanel(self, activate=None):
236-
self.taskPanel = TaskPanel(self.vobj, self.deleteObjectsOnReject())
237237
FreeCADGui.Control.closeDialog()
238+
self.taskPanel = TaskPanel(self.vobj, self.deleteObjectsOnReject())
238239
FreeCADGui.Control.showDialog(self.taskPanel)
239240
self.taskPanel.setupUi(activate)
240241
self.showOriginAxis(True)
@@ -696,7 +697,10 @@ def __init__(self, vobj, deleteOnReject):
696697
self.vproxy = vobj.Proxy
697698
self.obj = vobj.Object
698699
self.deleteOnReject = deleteOnReject
699-
self.form = FreeCADGui.PySideUic.loadUi(":/panels/PathEdit.ui")
700+
self.wrapper = QtGui.QVBoxLayout()
701+
self.wrapper.setContentsMargins(0, 0, 0, 0)
702+
self.wrapper.addWidget(FreeCADGui.PySideUic.loadUi(":/panels/PathEdit.ui"))
703+
self.form = self.wrapper
700704
self.template = PathJobDlg.JobTemplateExport(self.obj, self.form.jobBox.widget(1))
701705
self.name = self.obj.Name
702706

src/Mod/CAM/Path/Op/Gui/Base.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,9 +114,9 @@ def setEdit(self, vobj=None, mode=0):
114114

115115
def setupTaskPanel(self, panel):
116116
"""setupTaskPanel(panel) ... internal function to start the editor."""
117-
self.panel = panel
118117
FreeCADGui.Control.closeDialog()
119118
FreeCADGui.Control.showDialog(panel)
119+
self.panel = panel
120120
panel.setupUi()
121121
job = self.Object.Proxy.getJob(self.Object)
122122
if job:

0 commit comments

Comments
 (0)