Ctd

Author: phax

as2-lib/src/main/java/com/helger/as2lib/processor/sender/AbstractSenderModule.java

@@ -50,6 +50,12 @@
 import com.helger.commons.collection.impl.ICommonsMap;
 import com.helger.commons.string.StringParser;
 
+/**
+ * An abstract sender module that allows for retry. It allows to configure the
+ * maximum number of retries.
+ *
+ * @author Philip Helger
+ */
 public abstract class AbstractSenderModule extends AbstractProcessorModule implements IProcessorSenderModule
 {
   private static final Logger LOGGER = LoggerFactory.getLogger (AbstractSenderModule.class);
@@ -64,7 +70,8 @@ public abstract class AbstractSenderModule extends AbstractProcessorModule imple
    * @return 0 to indicate no retry.
    */
   @Nonnegative
-  protected final int getRetryCount (@Nullable final Partnership aPartnerhsip, @Nullable final Map <String, Object> aOptions)
+  protected final int getRetryCount (@Nullable final Partnership aPartnerhsip,
+                                     @Nullable final Map <String, Object> aOptions)
   {
     int nRetries = -1;
 

as2-lib/src/main/java/com/helger/as2lib/processor/storage/MessageFileModule.java

@@ -136,7 +136,8 @@ public void handle (@Nonnull final String sAction,
 
   @Override
   @Nonnull
-  protected String getFilename (@Nonnull final IMessage aMsg, @Nullable final String sFileParam) throws AS2InvalidParameterException
+  protected String getFilename (@Nonnull final IMessage aMsg,
+                                @Nullable final String sFileParam) throws AS2InvalidParameterException
   {
     final CompositeParameters aCompParams = new CompositeParameters (false).add ("date", new DateParameters ())
                                                                            .add ("msg", new MessageParameters (aMsg));
@@ -148,11 +149,9 @@ protected static InputStream getHeaderStream (@Nonnull final IMessage aMsg, @Non
   {
     final StringBuilder aSB = new StringBuilder ();
 
-    // write headers to the string buffer
+    // write headers and a trailing EOL to the string builder
     aSB.append ("Message Headers:").append (CHttp.EOL);
-
     aMsg.headers ().forEachHeaderLine (sHeaderLine -> aSB.append (sHeaderLine).append (CHttp.EOL), true);
-
     aSB.append (CHttp.EOL);
 
     // write attributes to the string buffer