Skip to content

Commit 32fb135

Browse files
committed
deploy: 606b7d0
1 parent 35fbc5b commit 32fb135

File tree

69 files changed

+376
-112
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

69 files changed

+376
-112
lines changed

appConfig.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ window.AppConfig = {
2828
"app_notification_url": "assets/notifications/dev/",
2929
"app_update_url": "https://updates.phcode.io/tauri/update-latest-experimental-build.json",
3030
"linting.enabled_by_default": true,
31-
"build_timestamp": "2025-08-25T13:36:22.125Z",
31+
"build_timestamp": "2025-08-26T09:58:43.469Z",
3232
"googleAnalyticsID": "G-P4HJFPDB76",
3333
"googleAnalyticsIDDesktop": "G-VE5BXWJ0HF",
3434
"mixPanelID": "49c4d164b592be2350fc7af06a259bf3",
@@ -40,7 +40,7 @@ window.AppConfig = {
4040
"bugsnagEnv": "development"
4141
},
4242
"name": "Phoenix Code",
43-
"version": "4.1.2-21344",
43+
"version": "4.1.2-21346",
4444
"apiVersion": "4.1.2",
4545
"homepage": "https://core.ai",
4646
"issues": {

assets/default-project/en.zip

0 Bytes
Binary file not shown.

assets/sample-projects/HTML5.zip

0 Bytes
Binary file not shown.
0 Bytes
Binary file not shown.
0 Bytes
Binary file not shown.

assets/sample-projects/explore.zip

0 Bytes
Binary file not shown.
0 Bytes
Binary file not shown.

brackets-min.js

Lines changed: 36 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13227,6 +13227,11 @@ define("command/Menus", function (require, exports, module) {
1322713227
logger.leaveTrail("UI Menu Click: " + menuItem._command.getID());
1322813228
MainViewManager.focusActivePane();
1322913229
if (menuItem._command._options.eventSource) {
13230+
// NOTE: Ideally beforeExecuteCommand should be fired inside Command.execute itself.
13231+
// But right now Command.execute() bypasses the event flow
13232+
// So we run through CommandManager.execute() to keep things consistent
13233+
// (keyboard + menu both go through the same path)
13234+
// Read this for more info: https://github.com/phcode-dev/phoenix/pull/2356
1323013235
CommandManager.execute(menuItem._command.getID(), {
1323113236
eventSource: CommandManager.SOURCE_UI_MENU_CLICK,
1323213237
sourceType: self.id
@@ -34862,6 +34867,7 @@ define("extensionsIntegrated/CSSColorPreview/main", function (require, exports,
3486234867
define("extensionsIntegrated/CollapseFolders/main", function (require, exports, module) {
3486334868
const AppInit = require("utils/AppInit");
3486434869
const ProjectManager = require("project/ProjectManager");
34870+
const Strings = require("strings");
3486534871

3486634872
/**
3486734873
* This is the main function that handles the closing of all the directories
@@ -34902,7 +34908,7 @@ define("extensionsIntegrated/CollapseFolders/main", function (require, exports,
3490234908

3490334909
// create the collapse btn
3490434910
const $collapseBtn = $(`
34905-
<div id="collapse-folders" class="btn-alt-quiet" title="Collapse All">
34911+
<div id="collapse-folders" class="btn-alt-quiet" title="${Strings.COLLAPSE_ALL_FOLDERS}">
3490634912
<i class="fa-solid fa-chevron-down collapse-icon" aria-hidden="true"></i>
3490734913
<i class="fa-solid fa-chevron-up collapse-icon" aria-hidden="true"></i>
3490834914
</div>
@@ -49099,11 +49105,23 @@ define("extensionsIntegrated/TabBar/main", function (require, exports, module) {
4909949105
let $tabBar = null;
4910049106
let $tabBar2 = null;
4910149107

49108+
/**
49109+
* this function checks if the TabBar is currently enabled or not (no. of tabs is 0 means tab bar is disabled)
49110+
* @returns {boolean} true if TabBar is enabled and should be active
49111+
*/
49112+
function isTabBarActive() {
49113+
return Preference.tabBarEnabled && Preference.tabBarNumberOfTabs !== 0;
49114+
}
49115+
4910249116
/**
4910349117
* This function is responsible to take all the files from the working set and gets the working sets ready
4910449118
* This is placed here instead of helper.js because it modifies the working sets
4910549119
*/
4910649120
function getAllFilesFromWorkingSet() {
49121+
if (!isTabBarActive()) {
49122+
return;
49123+
}
49124+
4910749125
Global.firstPaneWorkingSet = [];
4910849126
Global.secondPaneWorkingSet = [];
4910949127

@@ -49251,7 +49269,7 @@ define("extensionsIntegrated/TabBar/main", function (require, exports, module) {
4925149269
* Creates the tab bar and adds it to the DOM
4925249270
*/
4925349271
function createTabBar() {
49254-
if (!Preference.tabBarEnabled || Preference.tabBarNumberOfTabs === 0) {
49272+
if (!isTabBarActive()) {
4925549273
cleanupTabBar();
4925649274
return;
4925749275
}
@@ -49284,6 +49302,10 @@ define("extensionsIntegrated/TabBar/main", function (require, exports, module) {
4928449302
* It is called when the working set changes. So instead of creating a new tab bar, we just update the existing one
4928549303
*/
4928649304
function updateTabs() {
49305+
if (!isTabBarActive()) {
49306+
return;
49307+
}
49308+
4928749309
// Get all files from the working set. refer to `global.js`
4928849310
getAllFilesFromWorkingSet();
4928949311

@@ -49600,6 +49622,10 @@ define("extensionsIntegrated/TabBar/main", function (require, exports, module) {
4960049622
* @param {String} commandId - the command id, to make sure we check it do the operation only on file save
4960149623
*/
4960249624
function onFileSave(event, commandId) {
49625+
if (!isTabBarActive()) {
49626+
return;
49627+
}
49628+
4960349629
if (commandId === Commands.FILE_SAVE || commandId === Commands.FILE_SAVE_ALL) {
4960449630
const activePane = MainViewManager.getActivePaneId();
4960549631
const currentFile = MainViewManager.getCurrentlyViewedFile(activePane);
@@ -49679,6 +49705,10 @@ define("extensionsIntegrated/TabBar/main", function (require, exports, module) {
4967949705

4968049706
// File dirty flag change handling
4968149707
DocumentManager.on("dirtyFlagChange", function (event, doc) {
49708+
if (!isTabBarActive()) {
49709+
return;
49710+
}
49711+
4968249712
const filePath = doc.file.fullPath;
4968349713

4968449714
// Update UI
@@ -49725,7 +49755,7 @@ define("extensionsIntegrated/TabBar/main", function (require, exports, module) {
4972549755
// Update menu checkmark
4972649756
CommandManager.get(Commands.TOGGLE_TABBAR).setChecked(prefs.showTabBar);
4972749757

49728-
if (Preference.tabBarEnabled && Preference.tabBarNumberOfTabs !== 0) {
49758+
if (isTabBarActive()) {
4972949759
createTabBar();
4973049760
} else {
4973149761
cleanupTabBar();
@@ -111843,6 +111873,9 @@ define("nls/root/strings", {
111843111873
"AI_QUOTA_USED": "AI quota used",
111844111874
"LOGIN_REFRESH": "Check Login Status",
111845111875

111876+
// Collapse Folders
111877+
"COLLAPSE_ALL_FOLDERS": "Collapse All Folders",
111878+
111846111879
// Custom Snippets
111847111880
"CUSTOM_SNIPPETS_MENU_ITEM_NAME": "Custom Snippets\u2026",
111848111881
"CUSTOM_SNIPPETS_PANEL_TITLE": "Custom Snippets",

cacheManifest.json

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
2-
"appConfig.js": "433b888c1b0be0ee5d1f09369f8769c6b622e97af9789ac77c1196f337e3395a",
3-
"assets/default-project/en.zip": "bac3524b72c609dedd1e4a17e9ba105b0b059d2426df22c217607cdbd6743be9",
2+
"appConfig.js": "4b2cf52bff38ba4c4a8e59ec449f908b3fdf14d778d3ee9f2bcee90207e26a5a",
3+
"assets/default-project/en.zip": "161dfd18c5ba67b04f3f3ef634904cb61ceb6cf6ec15996584f6517fc3047f09",
44
"assets/default-project/en/images/cloud1.svg": "527399dadfa3357c3ee1a63d6c1c7dda81ecebb832f7383db26f1aaeaf722a8d",
55
"assets/default-project/en/images/cloud2.svg": "8127c63c0987bc674e2d25f7d24ead017853326c1e43d07706fec46091904418",
66
"assets/default-project/en/images/cloud3.svg": "15de53aa41dea3b0f685292814563f97213a9736c3cec2f8e17b5d9d45b3ae3d",
@@ -126,7 +126,7 @@
126126
"assets/pwa/32x32.png": "4f8f75bfcdb6efbbed1732f49edab4e292274cdeb1841e285ccc8194f4c9d8ac",
127127
"assets/pwa/phoenix.png": "d292bf76d6d61fdece2f97fb4cd71b8b0060d1058e9c1d02c94bfb20da8b7f0d",
128128
"assets/pwa/Square284x284Logo.png": "9887c2967039b4fae1214817925f1fb4f9227cba12d37612457c1c8ee1110c67",
129-
"assets/sample-projects/bootstrap-blog.zip": "823f269719327e8f996320b7cf65143afcf4947b39584015c838e1722f0439f5",
129+
"assets/sample-projects/bootstrap-blog.zip": "5019c71e379be2b691179b047dfcc86c7354ad0bfb67994a2d06da99716568b4",
130130
"assets/sample-projects/bootstrap-blog/assets/brand/bootstrap-logo-white.svg": "203d56e7e5e15d8203e596d4a711cec986f6380064591de21850f4563fb840bf",
131131
"assets/sample-projects/bootstrap-blog/assets/brand/bootstrap-logo.svg": "df11d37a123e36a768f2a6064973c4c6ab17d1e3c6501c8bf434ca5c0134c9a2",
132132
"assets/sample-projects/bootstrap-blog/assets/dist/css/bootstrap.min.css": "fb1763b59f9f5764294b5af9fa5250835ae608282fe6f2f2213a5952aacf1fbf",
@@ -136,7 +136,7 @@
136136
"assets/sample-projects/bootstrap-blog/blog.rtl.css": "33f49d02bbcb2e78f019b7582408fad2b5a76a2ecf79fe09d5b3c08c6ee3872b",
137137
"assets/sample-projects/bootstrap-blog/index-rtl.html": "c582278884060098ff51b9d350b0739e1a0396debdc76772c62b6ec375b6efcb",
138138
"assets/sample-projects/bootstrap-blog/index.html": "f4716c2affa299a27ab6f8c74c22fe67564f1b1d36ff2f0b322672bf0479d739",
139-
"assets/sample-projects/dashboard.zip": "b41660b6641a56fc8a8cf39c9d33e9956383a2365a058a7cf5006c5787d5846b",
139+
"assets/sample-projects/dashboard.zip": "ea6f5adb529279c5b91525cb2bae07d0e9230e040e545fa6d9a5b4ddae508690",
140140
"assets/sample-projects/dashboard/assets/brand/bootstrap-logo-white.svg": "203d56e7e5e15d8203e596d4a711cec986f6380064591de21850f4563fb840bf",
141141
"assets/sample-projects/dashboard/assets/brand/bootstrap-logo.svg": "df11d37a123e36a768f2a6064973c4c6ab17d1e3c6501c8bf434ca5c0134c9a2",
142142
"assets/sample-projects/dashboard/assets/dist/css/bootstrap.min.css": "fb1763b59f9f5764294b5af9fa5250835ae608282fe6f2f2213a5952aacf1fbf",
@@ -148,7 +148,7 @@
148148
"assets/sample-projects/dashboard/index.html": "1fb0c934f816d728cad85e180f78369679dc9edb1eca2d5c625b9360e6264235",
149149
"assets/sample-projects/dashboard/signin.css": "083bef710a6170a5112ce257c2ecf8580ca97ce19136d770f10460e5b85862de",
150150
"assets/sample-projects/dashboard/signin.html": "8c602e656631aeee624673397c0dc00c339498914ed930ab177478c4662a8d26",
151-
"assets/sample-projects/explore.zip": "1da383979ecac899a3af9d0b744f4239bf99b1f39d9860c411b4330c4d8b2594",
151+
"assets/sample-projects/explore.zip": "b7377fb8ff39d6ec5217a87891a8d6e772df8c5547a0df264666aff7751fc3a8",
152152
"assets/sample-projects/explore/A-tribute-page.html": "bd510c60f444058b7fcb71d83841f32b1cb5193c1a39421d7739bd6af9fef248",
153153
"assets/sample-projects/explore/adjustable-fireworks.html": "11e69bb2dd8708ed8fbf1acc62b0aaaf88c7ffec859ee958dc1ae51cd53ddac8",
154154
"assets/sample-projects/explore/ant_colony.html": "bc9435ed1b9868f2fbc7212d526f7532c533a5fdf45da988fa5e575bc5f363b7",
@@ -236,7 +236,7 @@
236236
"assets/sample-projects/explore/watermelon-pixel.html": "765a3fbffb5db97910512fbabaa7c55c0b52dc8eedfcc630811be39d0af98663",
237237
"assets/sample-projects/explore/webmine.html": "6b808f52812dc03db28483411500c04daf8ee0226f535c600a36999d6b7837c0",
238238
"assets/sample-projects/explore/whack-a-mole.html": "25be94a3640553b4801f80edd49998bae3a360988e8a26ff3bdfdc2a76b77191",
239-
"assets/sample-projects/home-pages.zip": "cd633e3562714f8151f881a127f8ebf37d1dfaf8a1a892518649e7f8f6476d27",
239+
"assets/sample-projects/home-pages.zip": "88f3e3677a9d5aa21ca229320517ac68dba4213f8022f1100c0340c8ac812f95",
240240
"assets/sample-projects/home-pages/album/index.html": "e29a1e96644bc17bab1a7e3724e822d65a479e10df182725ee1afa916efbfdc1",
241241
"assets/sample-projects/home-pages/assets/brand/bootstrap-logo-white.svg": "203d56e7e5e15d8203e596d4a711cec986f6380064591de21850f4563fb840bf",
242242
"assets/sample-projects/home-pages/assets/brand/bootstrap-logo.svg": "df11d37a123e36a768f2a6064973c4c6ab17d1e3c6501c8bf434ca5c0134c9a2",
@@ -248,28 +248,28 @@
248248
"assets/sample-projects/home-pages/carousel/index.html": "235d650043a09f2954f24e4659f64d99ef3988858567fb2221fb1cf34df057e6",
249249
"assets/sample-projects/home-pages/cover/cover.css": "2fbb596077c570cad7ee9e98fb88f5665e0ecfc11e7085c3e04639ad03f7bc10",
250250
"assets/sample-projects/home-pages/cover/index.html": "759214701ff759432711b3421d80aca692c7a2b4c978c516a0bcd0c81a43f381",
251-
"assets/sample-projects/HTML5.zip": "39008f1bed6eb4931599a3650a38299256911a7b66c4a74015b45b5380b8cf1b",
251+
"assets/sample-projects/HTML5.zip": "b23da53afd4cb099ff29c7c8ea25e4e6875c2f87178852678ab9c3deb5491968",
252252
"assets/sample-projects/HTML5/index.html": "2dc94c7d3e33aeeb44ec4f75bc7df86a5fd19f3121f2fd3638636fbf7c476c6a",
253253
"assets/sample-projects/HTML5/script.js": "c49e4b01cded4defbc21f5d5d0102719ce4cccbe1b9cb19f9232c5a05df658da",
254254
"assets/sample-projects/HTML5/styles.css": "744b85a9c31affbb00976694c4b9c9149b31e575ed9efdec386231d062ae93f2",
255255
"assets/sample-projects/new-project-list.json": "be1c907279163610779b000aa9ea6e4b035e07429203f16445a914c7045f2d64",
256256
"assets/sample-projects/zips/bootstrap.zip": "6f10407c00ce5d598e77f890528743dc645bc28014335483992b481e63fd7b97",
257257
"base-config/keyboard.json": "32ab31d6aeda47bab8bcce276209ca017893f572cb4aa97655fb75baf1a9c123",
258258
"base-config/readme-keyboard.md": "27e98128176dbd060e93b1f321a4ddcd609571b7b8eb8c9112588f4767d08a03",
259-
"brackets-min.js": "08392c09c36e1ee583d7d488f3f1a39da4b50495702752d2354922917e60740a",
259+
"brackets-min.js": "d3bfd0894e13e95fefef779af121e5e7c2911af73806a1df12e61aae72e308a6",
260260
"brackets.config.dist.json": "8faa5c0a82bb4f49784e93d1225dbd5e1fd8ec6ab07b95f5f874c7c7bd7bb234",
261261
"brackets.config.staging.json": "c0e1f22c772c80f4f5756ab947e40538bcaf7fb7f8925834cfd4ef57c55e477a",
262262
"brackets.js": "9b7cd89217bbabaa45a2cde4b5ba0099b86495a19047b649195bf69ffcf670f4",
263-
"cacheManifest.json": "6da2cd3e809481601fa7635a0639a5b6740a2ccdb5da32226f7976f5c4f175c5",
263+
"cacheManifest.json": "9bfe35e1e8c087f503bfb3433c2c61aadb58d4a3f23489a356f85f634f7222b3",
264264
"command/ChangeShortcutTemplate.html": "345d682d8bde29380822824778cf09acc79affae6e82b9db00c6205b2b3dd2ee",
265265
"command/CommandManager.js": "10181902fc2e55a780981a17b95c7b579427fdfd12c92ed49df35d3b70f64c15",
266266
"command/Commands.js": "166fe466d645d020c71ab770d8b5f3b95a66b3ef9d9a4e81e0c0aae904f34b9d",
267267
"command/DefaultMenus.js": "285e7c4bfd14f2c1a06f239adbe2aef880e58c7f9c9356a2039fc7d5ae02b612",
268268
"command/KeyBindingManager.js": "9cf6683e8402ca62769cf0696213a8ca8f7082bd440fb8dabeea3cae1a695ed0",
269269
"command/KeyboardOverlayMode.js": "7170dfcfca59b41252146ef8a5ca4f652c666e33b7a4b411e30e72951bd35b49",
270270
"command/Keys.js": "36545bbbca56d2a909779c5873fa860bf737977588ad61a398acb86f6bcbe4ee",
271-
"command/Menus.js": "fc913ed7741d7f277f92a217774ea87b8e27756b6be6ffbbbb98ccbe3c5ca12d",
272-
"config.json": "0c9e81b9fa82b0f8b4843840176a668cbd6fdfdd0365ced8e17d288bc6631e94",
271+
"command/Menus.js": "45cbaf725423c29ea34e61ee044c82d395b38748dcfce5b8b4a8f1ec646bbf04",
272+
"config.json": "2d9c27a3e01fb2d0bc58983c2d9ae6d9776ee5bd37e3b9ba23f17a0aae55a10c",
273273
"desktop-metrics.html": "66f87550ddf04f284a6c1e81567b7dfbefb2b8007f48f0bad7d8f7aacdb11bac",
274274
"devEnable.html": "44aa1a496a8be413299f651e6b0c3e62ac50cd5d40126ad1bb6b70b9b2b818c4",
275275
"document/ChangedDocumentTracker.js": "03b0eaf0995fee6d27c782a8028a1314f61214e383f5f5e198320b2faac4cf40",
@@ -577,7 +577,7 @@
577577
"extensions/default/UrlCodeHints/requirejs-config.json": "44136fa355b3678a1146ad16f7e8649e94fb4fc21fe77e8310c060f61caaff8a",
578578
"extensions/default/UrlCodeHints/unittests.js": "c60ecbe81555d435437dc5b7294f4e89b3befb7b34d60c44285c6009807c29c2",
579579
"extensions/dev/README.md": "3fd897e55e0e05e503c898555cfa3b20e820b32946fc7c426ea9bb2afbed449f",
580-
"extensions/registry/popularity.json": "b2b2290423179df3e4d5df80ffb85db68a2ff0181dcf89166cc9c4af20d1b723",
580+
"extensions/registry/popularity.json": "2b01359c2db52520439909f60e0b8ebc6fc3910efc6b46f89cf50e8489367176",
581581
"extensions/registry/registry_version.json": "878b8ae9dba7622a9fb9148e41577bbe6a73030bec4465d629340370fd7bbf06",
582582
"extensions/samples/BracketsConfigCentral/htmlContent/Config.html": "6ac3ce03e2fb8913ec5da3e8835c0646894f242600c64d95b77c7d7dc0a156f7",
583583
"extensions/samples/BracketsConfigCentral/htmlContent/logo-sm.png": "006f025fecd24c292e87a1eb0e123ee21178ec9c09517a1f16fe362fe2fbcbb5",
@@ -602,7 +602,7 @@
602602
"extensions/samples/README.md": "381c6647cc6f90bd8c609b5896cfcdf78bcae2b3a9660c204d8b744a21436df6",
603603
"extensions/samples/TypingSpeedLogger/main.js": "87327584d6ebaa4e69ee7a8b4972951baeb01869f22b7c971736524cecd3137f",
604604
"extensionsIntegrated/appUpdater/main.js": "1d0c06f3bfb951d6293e0a69ea10def6d4f3addec459e8df78f3c88ea0a26fb6",
605-
"extensionsIntegrated/CollapseFolders/main.js": "789bce830aada2d49368528395be54d562cf02e7f63e6e39852dc4e48afe16c0",
605+
"extensionsIntegrated/CollapseFolders/main.js": "65d56875a05fc5badc919e93ab1dc7e2bfae5357a28d13b91bc01f68d3166451",
606606
"extensionsIntegrated/CSSColorPreview/main.js": "bcaeb1b11bbfed4ca5c635ae0ac9803323ea847341f5debbf56504b79a8dc061",
607607
"extensionsIntegrated/CustomSnippets/codeHintIntegration.js": "bb267cef6869d7abc5f4d4fe94763d47d5ade44b2ce7e0cbcfc177c4b535dcdd",
608608
"extensionsIntegrated/CustomSnippets/driver.js": "e6eda9ca0d948f8b1e9e9a12178d1b0e556173a28402b69e4e5784a03ca92416",
@@ -674,7 +674,7 @@
674674
"extensionsIntegrated/TabBar/helper.js": "7b62221e0db5f5df227a5da3aac5b2a62d2044a291807187c4b0df7b84219ef2",
675675
"extensionsIntegrated/TabBar/html/tabbar-pane.html": "d19f8ceb934240a69c87dc3148936bb5050615112900f1e576d81a5475a118af",
676676
"extensionsIntegrated/TabBar/html/tabbar-second-pane.html": "cd8a8b9cb816ea5781f4456e65f15e9597d5645bc4c5375ca46b244bb3d240d9",
677-
"extensionsIntegrated/TabBar/main.js": "766c61000d145c67bb8f47c506f7157155d8ca984238520215d2a3bc61ac2a60",
677+
"extensionsIntegrated/TabBar/main.js": "8916a00c236fb9247770c676b03edb11355cca720613d701aa9762f6047a761a",
678678
"extensionsIntegrated/TabBar/more-options.js": "58aeab1b2117e28ecb5c3b0161056ca01a99fdafa84461290cb4870160a9920d",
679679
"extensionsIntegrated/TabBar/overflow.js": "aae1a80e61423abbe59c5806901ea8ccb47d5f3cc53823f37974cfd686d583e6",
680680
"extensionsIntegrated/TabBar/preference.js": "47b104cb56e43fb482caa6ef00ce61f994e865219fba9756df74c91148b27320",
@@ -844,7 +844,7 @@
844844
"nls/README.md": "b9f71ba2e71d692ee72f89ab4f9d4080c195793fc2a5e9838e863ed2ac72ac92",
845845
"nls/ro/strings.js": "e3574bb57b81a62093d29ddf09cf988712325cc6f2e9ef8ad37e7d7ce7bca22b",
846846
"nls/root/strings-app.js": "e82c0a855a2f6abc77063465c89c64974f1204146fbc629bd54fef2ae11a81bb",
847-
"nls/root/strings.js": "06e5cb7892edcaaec196e105eb54d982150fa8bff6dfe076dc8562b0501db440",
847+
"nls/root/strings.js": "be8d79137aa1a9bee83a211f07ffe7ad7600f73172479868c9a11471a7a6002d",
848848
"nls/root/urls.js": "0e8522a0a58bb321a1de2d5fd72277089d558809a7c20af8922f1ea61ed4097e",
849849
"nls/ru/strings.js": "d37fdf0b263ef0a4b9fecb929c0b4862975f43ed2c6c04aa9ed792926c7898db",
850850
"nls/ru/urls.js": "822c62a15e13e41c9ceee0aa6403c2f05468ced045d9485ebf7755d3a2703f0a",

command/Menus.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -737,6 +737,11 @@ define(function (require, exports, module) {
737737
logger.leaveTrail("UI Menu Click: " + menuItem._command.getID());
738738
MainViewManager.focusActivePane();
739739
if (menuItem._command._options.eventSource) {
740+
// NOTE: Ideally beforeExecuteCommand should be fired inside Command.execute itself.
741+
// But right now Command.execute() bypasses the event flow
742+
// So we run through CommandManager.execute() to keep things consistent
743+
// (keyboard + menu both go through the same path)
744+
// Read this for more info: https://github.com/phcode-dev/phoenix/pull/2356
740745
CommandManager.execute(menuItem._command.getID(), {
741746
eventSource: CommandManager.SOURCE_UI_MENU_CLICK,
742747
sourceType: self.id

0 commit comments

Comments
 (0)