fix: interim releif for dark theme white flash on startup

Author: abose

src-tauri/src/boot_config.rs

@@ -15,7 +15,8 @@ pub static APP_CONSTANTS: OnceCell<AppConstants> = OnceCell::new();
 
 #[derive(Serialize)]
 pub struct BootConfig {
-    pub version: u32
+    pub version: u32,
+    pub start_as_hidden_window: bool,
 }
 static BOOT_CONFIG_FILE_NAME: &'static str = "boot_config.json";
 
@@ -26,15 +27,17 @@ fn get_boot_config_file_path(app_local_data_dir: &PathBuf) -> PathBuf {
 }
 
 fn _set_boot_config(boot_config: &mut BootConfig, value: &Value) {
-    boot_config.version = match value["version"].as_u64() {
-        Some(value) => value as u32,
-        None => 0
-    };
+    boot_config.version = value["version"].as_u64().map(|v| v as u32).unwrap_or(0);
+
+    boot_config.start_as_hidden_window = value["start_as_hidden_window"]
+        .as_bool()
+        .unwrap_or(false); // Default to `false` if missing or invalid
 }
 
 pub fn read_boot_config() -> BootConfig {
     let mut boot_config = BootConfig {
-        version: 1
+        version: 1,
+        start_as_hidden_window: false
     };
     if let Some(app_constants) = APP_CONSTANTS.get() {
         let boot_config_file_path = get_boot_config_file_path(&app_constants.app_local_data_dir);
@@ -50,20 +53,4 @@ pub fn read_boot_config() -> BootConfig {
     return boot_config;
 }
 
-fn _write_boot_config(boot_config: &BootConfig) {
-    if let Some(app_constants) = APP_CONSTANTS.get() {
-        let boot_config_file_path = get_boot_config_file_path(&app_constants.app_local_data_dir);
-        // Convert the BootConfig struct to JSON
-        let json_string = serde_json::to_string(boot_config).unwrap();
-        let mut file = File::create(boot_config_file_path).expect("Failed to create file");
-        file.write_all(json_string.as_bytes())
-            .expect("Failed to write to boot config file");   
-    }
-}
-
-// WARNING: If there are multiple windows, this will be called on each window close.
-pub fn write_boot_config(version: u32) {
-    _write_boot_config(&BootConfig {
-         version
-     })
-}
+// writing the boot config is always done from js to be simpler, as js is eazier to handle json.

src-tauri/src/init.rs

@@ -2,8 +2,9 @@ use crate::utilities::ensure_dir_exists;
 use crate::boot_config::read_boot_config;
 use crate::boot_config::APP_CONSTANTS;
 use crate::boot_config::AppConstants;
+use crate::boot_config::BootConfig;
 
-pub fn init_app(app: &mut tauri::App) {
+pub fn init_app(app: &mut tauri::App) -> BootConfig {
     let config = app.config().clone();
     println!("Appdata path is {}",  tauri::api::path::app_local_data_dir(&config).expect("failed to retrieve app_local_data_dir").display());
     ensure_dir_exists(&tauri::api::path::app_local_data_dir(&config).unwrap()); // canonicalize will work only if path exists
@@ -14,14 +15,31 @@ pub fn init_app(app: &mut tauri::App) {
     });
 
     // To get a value
-    if let Some(app_constants) = APP_CONSTANTS.get() {
-        #[cfg(debug_assertions)]{
-            println!("Bundle ID is {}", app_constants.tauri_config.tauri.bundle.identifier);
+    let boot_config = if let Some(app_constants) = APP_CONSTANTS.get() {
+        #[cfg(debug_assertions)]
+        {
+            println!(
+                "Bundle ID is {}",
+                app_constants.tauri_config.tauri.bundle.identifier
+            );
         }
         ensure_dir_exists(&app_constants.app_local_data_dir);
-        read_boot_config();
-        #[cfg(debug_assertions)]{
-            println!("Bootconfig version is {}", read_boot_config().version);
+        let boot_config = read_boot_config();
+
+        #[cfg(debug_assertions)]
+        {
+            println!("Bootconfig version is {}", boot_config.version);
+            println!("start as hidden: {}", boot_config.start_as_hidden_window);
+        }
+
+        boot_config
+    } else {
+        // Return a default boot config if APP_CONSTANTS is not set
+        BootConfig {
+            version: 1,
+            start_as_hidden_window: false,
         }
-    }
+    };
+
+    boot_config
 }

src-tauri/src/main.rs

@@ -257,12 +257,12 @@ fn zoom_window(window: tauri::Window, scale_factor: f64) {
       });
 }
 
-fn process_window_event(event: &GlobalWindowEvent) {
-    if let tauri::WindowEvent::CloseRequested { .. } = event.event() {
-        // this does nothing and is here if in future you need to persist something on window close.
-        boot_config::write_boot_config(1);
-    }
-}
+// here in case you need to process windows events
+// fn process_window_event(event: &GlobalWindowEvent) {
+//     if let tauri::WindowEvent::CloseRequested { .. } = event.event() {
+//         // this does nothing and is here if in future you need to persist something on window close.
+//     }
+// }
 
 // convert url of form "protocol://host/v1.2.3/path/to/something" to "protocol://host/path/to/something"
 fn remove_version_from_url(url: &str) -> String {
@@ -431,7 +431,7 @@ fn main() {
 
                     app.emit_all("single-instance", Payload { args: argv, cwd }).unwrap();
                 }))
-        .on_window_event(|event| process_window_event(&event))
+        //.on_window_event(|event| process_window_event(&event))
         .invoke_handler(tauri::generate_handler![
             get_mac_deep_link_requests, get_process_id,
             toggle_devtools, console_log, console_error, _get_commandline_args, get_current_working_dir,
@@ -440,7 +440,14 @@ fn main() {
             _get_windows_drives, _rename_path, show_in_folder, move_to_trash, zoom_window,
             _get_clipboard_files, _open_url_in_browser_win])
         .setup(|app| {
-            init::init_app(app);
+            let boot_config = init::init_app(app);
+
+            if boot_config.start_as_hidden_window {
+                if let Some(main_window) = app.get_window("main") {
+                    main_window.hide().expect("Failed to hide main window");
+                }
+            }
+
             #[cfg(target_os = "linux")]
             {
                 // In linux, f10 key press events are reserved for gtk-menu-bar-accel and not passed.

src-tauri/src/utilities.rs

@@ -53,11 +53,15 @@ pub fn read_json_file(path: &PathBuf) -> Option<Value> {
 
     let mut contents = String::new();
     if let Err(_) = file.read_to_string(&mut contents) {
+        eprintln!("Failed to read file: {}", path.display());
         return None; // Error reading the file
     }
 
     match serde_json::from_str(&contents) {
         Ok(data) => Some(data),
-        Err(_) => None, // JSON parsing error
+        Err(err) => {
+            eprintln!("Failed to parse JSON in {}: {}", path.display(), err);
+            None
+        }
     }
 }