fix: invalid paratemeter error cb if path is invalid

Author: abose

dist/virtualfs.js

@@ -1,7 +1,7 @@
 {
   "name": "@phcode/fs",
   "description": "Phoenix virtual file system over filer/ browser fs access/ tauri / phoenix web socket APIs",
-  "version": "2.0.1",
+  "version": "2.0.2",
   "keywords": [
     "phoenix",
     "browser",

dist/virtualfs.js.map

@@ -121,6 +121,10 @@ const fileSystemLib = {
     },
     stat: function (...args) { // (path, callback)
         let path = args[0];
+        if(typeof path !== 'string') {
+            let callback = args[_getFirstFunctionIndex(args)];
+            return callback(new Errors.EINVAL(`Error Invalid path for stat: ${path}`));
+        }
         if(TauriFS.isTauriSubPath(path)) {
             return TauriFS.stat(...args);
         }

package-lock.json

@@ -59,6 +59,10 @@ function _processContents(contentsBuffer, encoding, callback, path) {
 
 function readFile(path, options, callback) {
     try{
+        if(typeof path !== 'string') {
+            return callback(new Errors.EINVAL(`Error Invalid path for readFile: ${path}`));
+        }
+
         path = globalObject.path.normalize(path);
 
         callback = arguments[arguments.length - 1];
@@ -87,6 +91,9 @@ function writeFile (path, data, options, callback) {
     try{
         callback = arguments[arguments.length - 1];
         options = Utils.validateFileOptions(options, Constants.BINARY_ENCODING, 'w');
+        if(typeof path !== 'string') {
+            return callback(new Errors.EINVAL(`Error Invalid path for writeFile: ${path}`));
+        }
 
         let bufferData;
         if(data instanceof ArrayBuffer){

package.json

@@ -129,6 +129,30 @@ function _setupTests(testType) {
         await _writeTestFile();
     });
 
+    it(`should phoenix ${testType} writeFile return an error if called with invalid parameters`, async function () {
+        let resolveP;
+        const promise = new Promise((resolve) => {resolveP = resolve;});
+        fs.writeFile(42, _fileContent(), `utf8`, (err)=>{
+            resolveP(err);
+        });
+        const error = await promise;
+
+        expect(error.code).to.equal(fs.ERR_CODES.EINVAL);
+    });
+
+    it(`should phoenix ${testType} unlink return an error if called with invalid parameters`, async function () {
+        let resolveP;
+        const promise = new Promise((resolve) => {resolveP = resolve;});
+
+        fs.unlink(42, (err)=>{
+            resolveP(err);
+        });
+
+        const error = await promise;
+
+        expect(error.code).to.equal(fs.ERR_CODES.EINVAL);
+    });
+
     it(`Should phoenix ${testType} read in browser`, async function () {
         await _writeTestFile();
         let resolveP,rejectP;