Skip to content

Commit 00c5c43

Browse files
author
Amro Khalil
committed
Main
### What kind of change does this PR introduce? <!-- Delete ones that doesnt apply--> - Bugfix - fixes issues- give issue github url/details here. - Feature - Docs - Code style update - Refactor - Build-related changes - Other, please describe: ### Screenshots or Gifs of the change 1. Any visual or workflow changes must come with a gif or screenshot. 2. Gif screen recordings help more if present. You can use one of the below free screen recorders: 1. windows gif recorder- https://www.screentogif.com/ 2. mac gif recorder- https://apps.apple.com/au/app/giphy-capture-the-gif-maker/id668208984?mt=12 3. linux gif recorder- https://github.com/phw/peek ### Does this PR introduce a breaking change? <!-- If yes, please describe the impact and migration path for existing applications in an attached issue. --> - Yes, and the changes were approved in issue #___ - No ### Tests done - Describe unit tests done - Describe integration tests done - Describe manual tests done ### Checklist - [ ] When resolving issues, reference those issue URLs in description. - [ ] Propose a changelog if this pull request has any customer facing impact. - [ ] I have added a convincing reason for adding this feature, if necessary. ### Other information ### pull request guidelines: * It's OK to have multiple small commits as you work on the PR - we will let GitHub automatically squash it before merging. * If adding new feature:, Provide convincing reason to add this feature. Ideally you should open a suggestion issue first and have it greenlighted before working on it. * If fixing a bug:Provide detailed description of the bug in the PR, or link to an issue that does. * Provide screenshots or gifs of the changes whenever possible.
1 parent 8730bc4 commit 00c5c43

File tree

2 files changed

+28
-17
lines changed

2 files changed

+28
-17
lines changed

.vscode/extensions.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"recommendations": []
3+
}

src/extensionsIntegrated/Phoenix-live-preview/livePreviewSettings.html

Lines changed: 25 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,41 @@
1-
<div class="live-preview-settings modal" style="min-height: 400px;display: flex; flex-direction: column; justify-content: space-between">
1+
<div class="""live-preview-settings modal live-preview-settings-container">
22
<div>
33
<div class="modal-header">
44
<h1 class="dialog-title">{{Strings.LIVE_DEV_SETTINGS_TITLE}}</h1>
55
</div>
66
<div class="modal-body">
77
<div class="form-group form-check">
8-
<input type="checkbox" class="form-check-input" id="showLivePreviewAtStartupChk" style="margin-top: -2px;">
9-
<label class="form-check-label" for="showLivePreviewAtStartupChk" style="display: inline">{{Strings.LIVE_DEV_SETTINGS_STARTUP}}</label>
8+
<input type="""checkbox" class="""form-check-input input-margin-top" id="""showLivePreviewAtStartupChk" title="{{Strings.LIVE_DEV_SETTINGS_STARTUP}}" placeholder="{{Strings.LIVE_DEV_SETTINGS_STARTUP}}">
9+
<label class="""form-check-label label-inline" for="""showLivePreviewAtStartupChk">{{Strings.LIVE_DEV_SETTINGS_STARTUP}}</label>
1010
</div>
11-
<div class="form-group" style="margin-top: 9px;">
12-
<input id="enableCustomServerChk" type="checkbox" class="form-check-input" style="margin-top: -1px;">
13-
<label id="enableCustomServerLabel" class="form-check-label" for="enableCustomServerChk" style="display: inline">{{Strings.LIVE_DEV_SETTINGS_USE_SERVER}}</label>
14-
<input id="livePreviewServerURL" type="text" spellcheck="false" autocomplete="off" class=""
15-
style="width: 93%; margin-left: 20px;margin-top: 5px;margin-bottom: 0;" value="{{settings.fontSize}}" placeholder="{{Strings.LIVE_DEV_SETTINGS_SERVER_INBUILT}}">
16-
<label id="serveRootLabel" class="forced-hidden" style="margin-left: 20px;margin-top: 9px;">{{Strings.LIVE_DEV_SETTINGS_SERVER_ROOT}}</label>
17-
<input id="serveRoot" type="text" spellcheck="false" autocomplete="off" class="forced-hidden" style="width: 93%; margin-left: 20px;"
11+
<div class="""form-group form-group-margin-top"></div>
12+
<input id="""enableCustomServerChk" type="""checkbox" class="""form-check-input input-margin-top-small" title="{{Strings.LIVE_DEV_SETTINGS_USE_SERVER}}" placeholder="{{Strings.LIVE_DEV_SETTINGS_USE_SERVER}}">
13+
<label id="""enableCustomServerLabel" class="""form-check-label label-inline" for="""enableCustomServerChk">{{Strings.LIVE_DEV_SETTINGS_USE_SERVER}}</label>
14+
<input id="""livePreviewServerURL" type="""text" spellcheck="""false" autocomplete="""off" class="input-server-url"
15+
value="{{settings.fontSize}}" placeholder="{{Strings.LIVE_DEV_SETTINGS_SERVER_INBUILT}}">
16+
<label id="serveRootLabel" class="forced-hidden label-margin-left label-margin-top" >{{Strings.LIVE_DEV_SETTINGS_SERVER_ROOT}}</label>
17+
<input id="serveRoot" type="text" spellcheck="false" autocomplete="off" class="forced-hidden input-server-root"
1818
value="{{settings.fontSize}}" placeholder="{{Strings.LIVE_DEV_SETTINGS_SERVER_ROOT_HELP}}">
19-
<label id="frameworkLabel" class="forced-hidden" style="margin-left: 20px;">{{Strings.LIVE_DEV_SETTINGS_FRAMEWORK}}</label>
20-
<select id="frameworkSelect" class="forced-hidden" style="width: 20%; margin-left: 20px;">
21-
<option style="text-align:left;" value="Custom">{{Strings.LIVE_DEV_SETTINGS_FRAMEWORK_CUSTOM}}</option>
22-
<option style="text-align:left;" value="Docusaurus">Docusaurus</option>
19+
<label id="frameworkLabel" class="forced-hidden label-margin-left">{{Strings.LIVE_DEV_SETTINGS_FRAMEWORK}}</label>
20+
<select id="frameworkSelect" class="forced-hidden" title="{{Strings.LIVE_DEV_SETTINGS_FRAMEWORK}}" >
21+
<option class="option-align-left" value="Custom">{{Strings.LIVE_DEV_SETTINGS_FRAMEWORK_CUSTOM}}</option>
22+
<option class="option-align-left" value="Docusaurus">Docusaurus</option>
2323
</select>
2424

25-
<input id="hotReloadChk" type="checkbox" class="form-check-input forced-hidden" style="margin-top: -2px; margin-left: 20px;">
26-
<label id="hotReloadLabel" class="form-check-label forced-hidden" for="hotReloadChk" style="display: inline" title="{{Strings.LIVE_DEV_SETTINGS_RELOAD_HELP}}">{{Strings.LIVE_DEV_SETTINGS_RELOAD}}</label>
25+
<input id="hotReloadChk" type="checkbox" class="form-check-input forced-hidden input-margin-top input-margin-left">
26+
<label id="hotReloadLabel" class="form-check-label forced-hidden label-inline" for="hotReloadChk" title="{{Strings.LIVE_DEV_SETTINGS_RELOAD_HELP}}">{{Strings.LIVE_DEV_SETTINGS_RELOAD}}</label>
27+
</div>
28+
29+
<div class="form-group element-highlight-wrapper" id="elementHighlightWrapper">
30+
<label for="elementHighlight" class="label-margin-top">{{Strings.LIVE_DEV_SETTINGS_ELEMENT_HIGHLIGHT}} </label>
31+
<select name="elementHighlight" id="elementHighlight">
32+
<option value="hover">{{Strings.LIVE_DEV_SETTINGS_ELEMENT_HIGHLIGHT_HOVER}}</option>
33+
<option value="click">{{Strings.LIVE_DEV_SETTINGS_ELEMENT_HIGHLIGHT_CLICK}}</option>
34+
</select>
2735
</div>
2836
</div>
2937
</div>
30-
<div class="modal-footer" style="">
38+
<div class="modal-footer">
3139
<button class="dialog-button btn" data-button-id="cancel">{{Strings.CANCEL}}</button>
3240
<button class="dialog-button btn primary" id="theme-settings-done-btn" data-button-id="ok">{{Strings.DONE}}</button>
3341
</div>

0 commit comments

Comments
 (0)