fix: flakey LocalizationUtils time tests indepedent of current time

Author: abose

src/utils/LocalizationUtils.js

@@ -113,11 +113,12 @@ define(function (require, exports, module) {
      *
      * @param {Date} date - The date to compare and format.
      * @param {string} [lang] - Optional language code to use for formatting (e.g., 'en', 'fr').
+     * @param {Date} [fromDate] - Optional date to use instead of now to compute the relative dateTime from.
      * @returns {string} - An intelligently formatted date string.
      */
-    function dateTimeFromNowFriendly(date, lang) {
-        const now = new Date();
-        const diffInMilliseconds = date - now;
+    function dateTimeFromNowFriendly(date, lang, fromDate) {
+        fromDate = fromDate || new Date();
+        const diffInMilliseconds = date - fromDate;
         const diffInDays = Math.trunc(diffInMilliseconds / (1000 * 60 * 60 * 24));
 
         // If within the last 30 days or the future, use relative time
@@ -126,7 +127,7 @@ define(function (require, exports, module) {
         }
 
         // If in the current year, format as "MMM DD"
-        const currentYear = now.getFullYear();
+        const currentYear = fromDate.getFullYear();
         const dateYear = date.getFullYear();
 
         const languageOption = [lang || brackets.getLocale() || "en", "en"];

test/spec/LocalizationUtils-test.js

@@ -262,9 +262,9 @@ define(function (require, exports, module) {
             });
 
             it("should use formatted date without year for dates earlier this year", function () {
-                const now = new Date();
-                const testDate = new Date(now.getFullYear(), 1, 15); // Feb 15 of current year
-                const result = LocalizationUtils.dateTimeFromNowFriendly(testDate, "en");
+                const testDate = new Date(2024, 1, 15);
+                const fromDate = new Date(2024, 11, 15);
+                const result = LocalizationUtils.dateTimeFromNowFriendly(testDate, "en", fromDate);
                 expect(result).toBe("Feb 15");
             });
 
@@ -301,9 +301,9 @@ define(function (require, exports, module) {
 
             // Current year tests
             it("should use formatted date without year for dates earlier this year (de locale)", function () {
-                const now = new Date();
-                const testDate = new Date(now.getFullYear(), 1, 15); // Feb 15 of current year
-                const result = LocalizationUtils.dateTimeFromNowFriendly(testDate, "de");
+                const testDate = new Date(2024, 1, 15);
+                const fromDate = new Date(2024, 10, 15);
+                const result = LocalizationUtils.dateTimeFromNowFriendly(testDate, "de", fromDate);
                 expect(result).toBe("15. Feb.");
             });
 
@@ -322,4 +322,4 @@ define(function (require, exports, module) {
         });
 
     });
-}); 
+});