Skip to content

Commit 0cf38e7

Browse files
committed
feat: localize missing strings for button title
1 parent b2100ca commit 0cf38e7

File tree

3 files changed

+11
-9
lines changed

3 files changed

+11
-9
lines changed

src/LiveDevelopment/BrowserScripts/RemoteFunctions.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2291,7 +2291,7 @@ function RemoteFunctions(config = {}) {
22912291
22922292
.search-wrapper {
22932293
position: relative;
2294-
margin-right: 2px;
2294+
margin-right: 6px;
22952295
}
22962296
22972297
.search-wrapper input {
@@ -2329,7 +2329,7 @@ function RemoteFunctions(config = {}) {
23292329
color: #a0a0a0;
23302330
border: none;
23312331
border-radius: 3px;
2332-
padding: 4px 8px;
2332+
padding: 4px 8px 4px 3px;
23332333
font-size: 12px;
23342334
cursor: pointer;
23352335
}
@@ -2600,7 +2600,7 @@ function RemoteFunctions(config = {}) {
26002600
26012601
<div class="phoenix-image-gallery-search-container">
26022602
<div class="search-wrapper">
2603-
<button class="search-icon">${ICONS.search}</button>
2603+
<button class="search-icon" title="${config.strings.imageGallerySearchButton}">${ICONS.search}</button>
26042604
<input
26052605
type="text"
26062606
placeholder="${config.strings.imageGallerySearchPlaceholder}"
@@ -2609,16 +2609,16 @@ function RemoteFunctions(config = {}) {
26092609
</div>
26102610
26112611
<div class='phoenix-image-gallery-upload-container'>
2612-
<button>${ICONS.selectImageFromComputer} Upload</button>
2612+
<button title="${config.strings.imageGallerySelectFromComputer}">${ICONS.selectImageFromComputer} ${config.strings.imageGalleryUpload}</button>
26132613
<input type="file" class="phoenix-file-input" accept="image/*" style="display: none;">
26142614
</div>
26152615
26162616
<div class='phoenix-image-gallery-right-buttons'>
2617-
<button class='phoenix-image-gallery-download-folder-button'>
2617+
<button class='phoenix-image-gallery-download-folder-button' title="${config.strings.imageGallerySelectDownloadFolder}">
26182618
${ICONS.folderSettings}
26192619
</button>
26202620
2621-
<button class='phoenix-image-gallery-close-button'>
2621+
<button class='phoenix-image-gallery-close-button' title="${config.strings.imageGalleryClose}">
26222622
${ICONS.close}
26232623
</button>
26242624
</div>
@@ -3020,7 +3020,7 @@ function RemoteFunctions(config = {}) {
30203020

30213021
const img = window.document.createElement('img');
30223022
img.src = image.thumb_url || image.url;
3023-
img.alt = image.alt_text || 'Unsplash image';
3023+
img.alt = image.alt_text || '';
30243024
img.loading = 'lazy';
30253025

30263026
// show hovered image along with dimensions

src/LiveDevelopment/main.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,8 @@ define(function main(require, exports, module) {
9090
imageGalleryLoadingMore: Strings.LIVE_DEV_IMAGE_GALLERY_LOADING_MORE,
9191
imageGalleryNoImages: Strings.LIVE_DEV_IMAGE_GALLERY_NO_IMAGES,
9292
imageGalleryLoadError: Strings.LIVE_DEV_IMAGE_GALLERY_LOAD_ERROR,
93-
imageGalleryClose: Strings.LIVE_DEV_IMAGE_GALLERY_CLOSE
93+
imageGalleryClose: Strings.LIVE_DEV_IMAGE_GALLERY_CLOSE,
94+
imageGalleryUpload: Strings.LIVE_DEV_IMAGE_GALLERY_UPLOAD
9495
}
9596
};
9697
// Status labels/styles are ordered: error, not connected, progress1, progress2, connected.

src/nls/root/strings.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ define({
191191
"LIVE_DEV_MORE_OPTIONS_AI": "Edit with AI",
192192
"LIVE_DEV_MORE_OPTIONS_IMAGE_GALLERY": "Image Gallery",
193193
"LIVE_DEV_IMAGE_GALLERY_USE_IMAGE": "Use this image",
194-
"LIVE_DEV_IMAGE_GALLERY_SELECT_FROM_COMPUTER": "Select image from computer",
194+
"LIVE_DEV_IMAGE_GALLERY_SELECT_FROM_COMPUTER": "Upload image from computer",
195195
"LIVE_DEV_IMAGE_GALLERY_SELECT_DOWNLOAD_FOLDER": "Choose image download folder",
196196
"LIVE_DEV_IMAGE_GALLERY_SEARCH_PLACEHOLDER": "Search images\u2026",
197197
"LIVE_DEV_IMAGE_GALLERY_SEARCH_BUTTON": "Search",
@@ -200,6 +200,7 @@ define({
200200
"LIVE_DEV_IMAGE_GALLERY_NO_IMAGES": "No images found",
201201
"LIVE_DEV_IMAGE_GALLERY_LOAD_ERROR": "Failed to load images",
202202
"LIVE_DEV_IMAGE_GALLERY_CLOSE": "Close",
203+
"LIVE_DEV_IMAGE_GALLERY_UPLOAD": "Upload",
203204
"LIVE_DEV_IMAGE_FOLDER_DIALOG_TITLE": "Select Folder to Save Image",
204205
"LIVE_DEV_IMAGE_FOLDER_DIALOG_DESCRIPTION": "Choose where to download the image:",
205206
"LIVE_DEV_IMAGE_FOLDER_DIALOG_PLACEHOLDER": "Type folder path (e.g., assets/images/)",

0 commit comments

Comments
 (0)