fix: right clicks on tab bar sometimes opens up editor's context menu

Author: devvaannsh

src/command/DefaultMenus.js

@@ -407,6 +407,10 @@ define(function (require, exports, module) {
          * an existing selection
          */
         $("#editor-holder").on("contextmenu", function (e) {
+            // make sure that the click was not made inside a tab bar container
+            // if it is, then we don't show editor context menu as tab bar has its own
+            if($(e.target).closest('.tab-bar-container').length) { return; }
+
             require(["editor/EditorManager"], function (EditorManager) {
                 if ($(e.target).parents(".CodeMirror-gutter").length !== 0) {
                     return;
@@ -477,4 +481,4 @@ define(function (require, exports, module) {
         Menus.getContextMenu(Menus.ContextMenuIds.WORKING_SET_CONTEXT_MENU).on("beforeContextMenuOpen", _setMenuItemsVisible);
         Menus.getContextMenu(Menus.ContextMenuIds.PROJECT_MENU).on("beforeContextMenuOpen", _setMenuItemsVisible);
     });
-});
+});

src/extensionsIntegrated/TabBar/main.js

@@ -511,6 +511,9 @@ define(function (require, exports, module) {
 
         // delegate event handling for both tab bars
         $(document).on("mousedown", ".phoenix-tab-bar .tab", function (event) {
+            // to prevent right clicks activate the mousedown event
+            if (event.button === 2) { return; }
+
             if ($(event.target).hasClass("fa-times") || $(event.target).closest(".tab-close").length) {
                 return;
             }