build: add octicons to core for git extension

Author: abose

src/extensions/default/Git/main.js

@@ -32,7 +32,6 @@ define(function (require, exports, module) {
 
     // Load CSS
     ExtensionUtils.loadStyleSheet(module, "styles/brackets-git.less");
-    ExtensionUtils.loadStyleSheet(module, "styles/fonts/octicon.less");
 
     AppInit.appReady(function () {
         Main.init().then((enabled)=>{

src/extensions/default/Git/src/Branch.js

@@ -458,7 +458,7 @@ define(function (require, exports) {
                     var MAX_LEN = 18;
 
                     const tooltip = StringUtils.format(Strings.ON_BRANCH, branchName);
-                    const html = `<i class='octicon octicon-git-branch'></i> ${
+                    const html = `<i class="fas fa-code-branch"></i> ${
                         branchName.length > MAX_LEN ? branchName.substring(0, MAX_LEN) + "\u2026" : branchName
                     }`;
                     $gitBranchName
@@ -491,7 +491,7 @@ define(function (require, exports) {
         // Add branch name to project tree
         const $html = $(`<div id='git-branch-dropdown-toggle' class='btn-alt-quiet'>
             <span id='git-branch'>
-                <i class='octicon octicon-git-branch'></i>
+                <i class="fas fa-code-branch"></i>
             </span>
             <span class="dropdown-arrow"></span>
             </div>`);

src/extensions/default/Git/styles/brackets-git.less

@@ -51,7 +51,7 @@
     /* adjust margins to keep position #project-title position stable after extension is loaded */
     overflow: hidden;
     white-space: nowrap;
-    padding: 1px 5px;
+    padding: 2px 5px;
     margin-left: -5px;
     .dropdown-arrow {
         display: inline-block;
@@ -68,9 +68,8 @@
     overflow: hidden;
     text-overflow: ellipsis;
     flex: 1 1 0;
-    .octicon {
-        line-height: unset;
-        font-size: small;
+    .fas {
+        font-size: 10px;
     }
 }
 

src/extensions/default/Git/styles/fonts/octicons-regular-webfont.eot

@@ -712,6 +712,7 @@
     <link rel="stylesheet" type="text/css" href="thirdparty/fontawesome/css/all.min.css">
     <link rel="stylesheet" type="text/css" href="thirdparty/devicon/devicon.min.css">
     <link rel="stylesheet" type="text/css" href="thirdparty/file-icons/ffont.css">
+    <link rel="stylesheet" type="text/css" href="thirdparty/octicon/octicon-woff-only.css">
     <link rel="stylesheet/less" type="text/css" href="styles/brackets.less"> <!--will be replaced in prod/staging with brackets-all.css by release:staging and prod command-->
 
     <!-- Pre-load third party scripts that cannot be async loaded. Defer loading of all below scripts