chore: should not lint minified css and js files

Author: abose

src/extensions/default/CSSCodeHints/css-lint.js

@@ -54,11 +54,11 @@ define(function (require, exports, module) {
      * a gold star when no errors are found.
      */
     async function lintOneFile(text, fullPath) {
-        return new Promise((resolve)=>{
+        return new Promise((resolve, reject)=>{
             const languageId = LanguageManager.getLanguageForPath(fullPath).getId();
             if(!cssMode[languageId]){
                 console.error("Unknown language id to lint: ", languageId, fullPath);
-                resolve();
+                reject(new Error("Unknown CSS language to lint for "+ fullPath));
                 return;
             }
             IndexingWorker.execPeer("cssLint", {
@@ -88,7 +88,10 @@ define(function (require, exports, module) {
     for(let language of supportedLanguages){
         CodeInspection.register(language, {
             name: StringUtils.format(Strings.CSS_LINT_NAME, cssMode[language]),
-            scanFileAsync: lintOneFile
+            scanFileAsync: lintOneFile,
+            canInspect: function (fullPath) {
+                return fullPath && !fullPath.endsWith(".min.css");
+            }
         });
     }
 });

src/extensions/default/JSHint/main.js

@@ -234,6 +234,9 @@ define(function (require, exports, module) {
     // Register for JS files
     CodeInspection.register("javascript", {
         name: Strings.JSHINT_NAME,
-        scanFileAsync: lintOneFile
+        scanFileAsync: lintOneFile,
+        canInspect: function (fullPath) {
+            return fullPath && !fullPath.endsWith(".min.js");
+        }
     });
 });

src/language/CodeInspection.js

@@ -255,6 +255,10 @@ define(function (require, exports, module) {
             return response.promise();
         }
 
+        providerList = providerList.filter(function (provider) {
+            return !provider.canInspect || provider.canInspect(file.fullPath);
+        });
+
         DocumentManager.getDocumentText(file)
             .done(function (fileText) {
                 var perfTimerInspector = PerfUtils.markStart("CodeInspection:\t" + file.fullPath),
@@ -284,6 +288,7 @@ define(function (require, exports, module) {
                                 runPromise.resolve(scanResult);
                             })
                             .catch(function (err) {
+                                err = err || new Error("Unknown error while inspecting "+ file.fullPath);
                                 PerfUtils.finalizeMeasurement(perfTimerProvider);
                                 var errError = {
                                     pos: {line: -1, col: 0},
@@ -305,7 +310,8 @@ define(function (require, exports, module) {
                                 message: StringUtils.format(Strings.LINTER_FAILED, provider.name, err),
                                 type: Type.ERROR
                             };
-                            console.error("[CodeInspection] Provider " + provider.name + " (sync) threw an error: " + err.stack);
+                            console.error("[CodeInspection] Provider " + provider.name +
+                                " (sync) threw an error: " + err && (err.stack || err));
                             runPromise.resolve({errors: [errError]});
                         }
                     }
@@ -558,9 +564,13 @@ define(function (require, exports, module) {
             return;
         }
 
-        var currentDoc = DocumentManager.getCurrentDocument(),
+        let currentDoc = DocumentManager.getCurrentDocument(),
             providerList = currentDoc && getProvidersForPath(currentDoc.file.fullPath);
 
+        providerList = providerList && providerList.filter(function (provider) {
+            return !provider.canInspect || provider.canInspect(currentDoc.file.fullPath);
+        });
+
         if (providerList && providerList.length) {
             var numProblems = 0;
             var aborted = false;