refactor: git extension less to single file to improve load speed

Author: abose

src/extensions/default/Git/main.js

@@ -31,7 +31,7 @@ define(function (require, exports, module) {
     require(modules);
 
     // Load CSS
-    ExtensionUtils.loadStyleSheet(module, "styles/brackets-git.less");
+    ExtensionUtils.loadStyleSheet(module, "styles/git-styles.less");
 
     AppInit.appReady(function () {
         Main.init().then((enabled)=>{

src/extensions/default/Git/src/Panel.js

@@ -601,54 +601,60 @@ define(function (require, exports) {
         let totalFiles = gitStatusResults.length,
             filesDone = 0;
 
+        function showProgress() {
+            const $progressBar = $dialog.find('.accordion-progress-bar-inner');
+            if ($progressBar.length) {
+                $progressBar[0].style.width = `${filesDone/totalFiles*100}%`;
+            }
+            if(filesDone === totalFiles){
+                $dialog.find('.accordion-progress-bar').addClass("forced-inVisible");
+            }
+            const progressString = StringUtils.format(Strings.CODE_INSPECTION_DONE_FILES, filesDone, totalFiles);
+            $dialog.find(".lint-errors").html(progressString);
+        }
+
         const codeInspectionPromises = gitStatusResults.map(function (fileObj) {
             const isDeleted = fileObj.status.indexOf(Git.FILE_STATUS.DELETED) !== -1;
+            if(isDeleted){
+                filesDone++;
+                showProgress();
+                return;
+            }
 
             // Do a code inspection for the file, if it was not deleted
-            if (!isDeleted) {
-                return new Promise((resolve) => {
-                    // Delay lintFile execution to give the event loop some breathing room
-                    setTimeout(() => {
-                        lintFile(fileObj.file)
-                            .catch(function () {
-                                return [
-                                    {
-                                        provider: { name: "See console [F12] for details" },
-                                        result: {
-                                            errors: [
-                                                {
-                                                    pos: { line: 0, ch: 0 },
-                                                    message: "CodeInspection failed to execute for this file."
-                                                }
-                                            ]
-                                        }
+            return new Promise((resolve) => {
+                // Delay lintFile execution to give the event loop some breathing room
+                setTimeout(() => {
+                    lintFile(fileObj.file)
+                        .catch(function () {
+                            return [
+                                {
+                                    provider: { name: "See console [F12] for details" },
+                                    result: {
+                                        errors: [
+                                            {
+                                                pos: { line: 0, ch: 0 },
+                                                message: "CodeInspection failed to execute for this file."
+                                            }
+                                        ]
                                     }
-                                ];
-                            })
-                            .then(function (result) {
-                                if (result) {
-                                    lintResults.push({
-                                        filename: fileObj.file,
-                                        result: result
-                                    });
-                                }
-                                resolve();
-                            }).finally(()=>{
-                                filesDone++;
-                                const $progressBar = $dialog.find('.accordion-progress-bar-inner');
-                                if ($progressBar.length) {
-                                    $progressBar[0].style.width = `${filesDone/totalFiles*100}%`;
-                                }
-                                if(filesDone === totalFiles){
-                                    $dialog.find('.accordion-progress-bar').addClass("forced-inVisible");
                                 }
-                                const progressString = StringUtils.format(Strings.CODE_INSPECTION_DONE_FILES, filesDone, totalFiles);
-                                $dialog.find(".lint-errors").html(progressString);
-
-                            });
-                    }, 0); // Delay of 0ms to defer to the next tick of the event loop
-                });
-            }
+                            ];
+                        })
+                        .then(function (result) {
+                            if (result) {
+                                lintResults.push({
+                                    filename: fileObj.file,
+                                    result: result
+                                });
+                            }
+                            resolve();
+                        }).finally(()=>{
+                            filesDone++;
+                            showProgress();
+                        });
+                }, 0); // Delay of 0ms to defer to the next tick of the event loop
+            });
         });
 
         return Promise.all(_.compact(codeInspectionPromises)).then(function () {

src/extensions/default/Git/src/dialogs/templates/push-dialog.html

@@ -1,4 +1,4 @@
-<div id="git-pull-dialog" class="git modal">
+<div id="git-push-dialog" class="git modal">
     <div class="modal-header">
         <h1 class="dialog-title">{{Strings.DIALOG_PUSH_TITLE}} &mdash; {{config.remote}}</h1>
     </div>