test: integ tests for auto tab space detection

Author: abose

src/editor/Editor.js

@@ -2597,6 +2597,9 @@ define(function (require, exports, module) {
             computedValues.useTabChar = value;
             // persist explicitly user set values to storage
             tabSpacesStateManager.set(fullPath, computedValues);
+            Editor.forEveryEditor(editor=>{
+                editor._updateOption(USE_TAB_CHAR);
+            }, fullPath);
             return true;
         }
         var options = fullPath && {context: fullPath};
@@ -2630,6 +2633,9 @@ define(function (require, exports, module) {
                 computedValues.tabSize = value;
                 // persist explicitly user set values to storage
                 tabSpacesStateManager.set(fullPath, computedValues);
+                Editor.forEveryEditor(editor=>{
+                    editor._updateOption(TAB_SIZE);
+                }, fullPath);
             }
             return true;
         }
@@ -2722,6 +2728,9 @@ define(function (require, exports, module) {
                 computedValues.spaceUnits = value;
                 // persist explicitly user set values to storage
                 tabSpacesStateManager.set(fullPath, computedValues);
+                Editor.forEveryEditor(editor=>{
+                    editor._updateOption(SPACE_UNITS);
+                }, fullPath);
             }
             return true;
         }
@@ -2847,11 +2856,19 @@ define(function (require, exports, module) {
     };
 
     /**
-     * Runs callback for every Editor instance that currently exists
+     * Runs callback for every Editor instance that currently exists or only the editors matching the given fullPath.
      * @param {!function(!Editor)} callback
+     * @param {string} [fullPath] an optional second argument, if given will only callback for all editors
+     *  that is editing the file for the given fullPath
      */
-    Editor.forEveryEditor = function (callback) {
-        _instances.forEach(callback);
+    Editor.forEveryEditor = function (callback, fullPath) {
+        _instances.forEach(function (editor) {
+            if(!fullPath) {
+                callback(editor);
+            } else if(editor.document.file.fullPath === fullPath) {
+                callback(editor);
+            }
+        });
     };
 
     /**

src/extensions/default/DebugCommands/MacroRunner.js

@@ -374,11 +374,11 @@ define(function (require, exports, module) {
                 Editor.Editor.setAutoTabSpaces(isAutoMode, fullPath);
                 isAutoMode && Editor.Editor._autoDetectTabSpaces(activeEditor, true, true);
             }
-            Editor.Editor.setUseTabChar(useTabs);
+            Editor.Editor.setUseTabChar(useTabs, fullPath);
             if(useTabs) {
-                Editor.Editor.setTabSize(spaceOrTabCount);
+                Editor.Editor.setTabSize(spaceOrTabCount, fullPath);
             } else {
-                Editor.Editor.setSpaceUnits(spaceOrTabCount);
+                Editor.Editor.setSpaceUnits(spaceOrTabCount, fullPath);
             }
         }
     };

test/spec/spacing-auto-detect-integ-test.js

@@ -108,5 +108,38 @@ define(function (require, exports, module) {
             validateSpacing("Tab Size:", "6", "Auto");
             await __PR.closeFile();
         });
+
+        it(`should switching to fixed mode default to 4 spaces for all files`, async function () {
+            await __PR.openFile("tab-2.js");
+            validateSpacing("Tab Size:", "2", "Auto");
+            $("#indent-auto").click();
+            validateSpacing("Spaces:", "4", "Fixed");
+            await __PR.openFile("space-1.js");
+            validateSpacing("Spaces:", "4", "Fixed");
+            await __PR.closeFile();
+        });
+
+        it(`should be able to change spacing/tabs settings of fixed mode`, async function () {
+            await __PR.openFile("tab-2.js");
+            // now change the fixed width
+            __PR.EDITING.setEditorSpacing(true, 6, false);
+            validateSpacing("Tab Size:", "6", "Fixed");
+            await __PR.openFile("space-12.js");
+            validateSpacing("Tab Size:", "6", "Fixed");
+            // revert back to defaults
+            __PR.EDITING.setEditorSpacing(false, 4, false);
+            await __PR.closeFile();
+        });
+
+        it(`should toggling auto mode recompute the spacing`, async function () {
+            await __PR.openFile("tab-2.js");
+            __PR.EDITING.setEditorSpacing(false, 3, true);
+            validateSpacing("Spaces:", "3", "Auto");
+            // now toggle the auto to fixed and then to auto once to force recompute spacing
+            $("#indent-auto").click();
+            $("#indent-auto").click();
+            validateSpacing("Tab Size:", "2", "Auto");
+            await __PR.closeFile();
+        });
     });
 });