chore: login workflow messaging and dialogs

Author: abose

src/nls/root/strings.js

@@ -1595,7 +1595,7 @@ define({
     "SIGNED_IN_FAILED_TITLE": "Cannot Sign In",
     "SIGNED_IN_FAILED_MESSAGE": "Something went wrong while trying to sign in. Please try again.",
     "SIGNED_OUT_FAILED_TITLE": "Failed to Sign Out",
-    "SIGNED_OUT_FAILED_MESSAGE": "Something went wrong while trying to sign out. Please try again.",
+    "SIGNED_OUT_FAILED_MESSAGE": "Something went wrong while logging out. Press OK to open <a href='https://account.phcode.dev/#advanced'>account.phcode.dev</a> where you can logout manually.",
     "VALIDATION_CODE_TITLE": "Sign In Verification Code",
     "VALIDATION_CODE_MESSAGE": "Please use this Verification code to sign in to your {APP_NAME} account:",
     "COPY_VALIDATION_CODE": "Copy Code",
@@ -1616,6 +1616,7 @@ define({
     "CHECKING_STATUS": "Checking login status\u2026",
     "NOT_SIGNED_IN_YET": "Not signed in yet. Please complete sign-in in the other tab.",
     "WELCOME_BACK": "Welcome back, {0}!",
+    "POPUP_BLOCKED": "Pop-up blocked. Please allow pop-ups and try again, or manually navigate to {0}",
 
     // Collapse Folders
     "COLLAPSE_ALL_FOLDERS": "Collapse All Folders",

src/services/login-browser.js

@@ -102,8 +102,7 @@ define(function (require, exports, module) {
                 method: 'GET',
                 credentials: 'include', // Include cookies
                 headers: {
-                    'Accept': 'application/json',
-                    'Cache-Control': 'no-cache'
+                    'Accept': 'application/json'
                 }
             });
 
@@ -289,7 +288,7 @@ define(function (require, exports, module) {
             Dialogs.showModalDialog(
                 DefaultDialogs.DIALOG_ID_ERROR,
                 Strings.SIGNED_IN_FAILED_TITLE,
-                "Pop-up blocked. Please allow pop-ups and try again, or manually navigate to " + accountURL
+                StringUtils.format(Strings.POPUP_BLOCKED, accountURL)
             );
             return;
         }
@@ -310,8 +309,7 @@ define(function (require, exports, module) {
                 method: 'POST',
                 credentials: 'include', // Include cookies
                 headers: {
-                    'Content-Type': 'application/json',
-                    'Cache-Control': 'no-cache'
+                    'Content-Type': 'application/json'
                 }
             });
 
@@ -324,7 +322,7 @@ define(function (require, exports, module) {
                     Dialogs.showModalDialog(
                         DefaultDialogs.DIALOG_ID_INFO,
                         Strings.SIGNED_OUT,
-                        "You have been signed out successfully."
+                        Strings.SIGNED_OUT
                     );
                     Metrics.countEvent(Metrics.EVENT_TYPE.AUTH, 'browserLogoutOK', 'browser');
                     return;
@@ -333,22 +331,28 @@ define(function (require, exports, module) {
 
             // If we get here, there was some issue but we still signed out locally
             console.warn('Logout may not have completed on server, but signed out locally');
-            Dialogs.showModalDialog(
-                DefaultDialogs.DIALOG_ID_INFO,
-                Strings.SIGNED_OUT,
-                "Signed out locally. You may need to sign out from your browser as well."
+            const dialog = Dialogs.showModalDialog(
+                DefaultDialogs.DIALOG_ID_ERROR,
+                Strings.SIGNED_OUT_FAILED_TITLE,
+                Strings.SIGNED_OUT_FAILED_MESSAGE
             );
+            dialog.done(() => {
+                window.open(_getAccountWebURL() + "#advanced", '_blank');
+            });
             Metrics.countEvent(Metrics.EVENT_TYPE.AUTH, 'browserLogoutPartial', 'browser');
 
         } catch (error) {
             // Always reset local state even on network error
             await _resetBrowserLogin();
             console.error("Network error during logout:", error);
-            Dialogs.showModalDialog(
-                DefaultDialogs.DIALOG_ID_INFO,
-                Strings.SIGNED_OUT,
-                "Signed out locally due to network error. You may need to sign out from your browser as well."
+            const dialog = Dialogs.showModalDialog(
+                DefaultDialogs.DIALOG_ID_ERROR,
+                Strings.SIGNED_OUT_FAILED_TITLE,
+                Strings.SIGNED_OUT_FAILED_MESSAGE
             );
+            dialog.done(() => {
+                window.open(_getAccountWebURL() + "#advanced", '_blank');
+            });
             Metrics.countEvent(Metrics.EVENT_TYPE.AUTH, 'browserLogoutError', 'browser');
         }
     }