refactor: clean up code to fix all eslint issues

Author: devvaannsh

src/LiveDevelopment/BrowserScripts/RemoteFunctions.js

@@ -20,14 +20,14 @@
  */
 
 /*jslint forin: true */
-/*global Node, MessageEvent*/
 /*theseus instrument: false */
 
 /**
  * RemoteFunctions define the functions to be executed in the browser. This
  * modules should define a single function that returns an object of all
  * exported functions.
  */
+// eslint-disable-next-line no-unused-vars
 function RemoteFunctions(config = {}) {
     const GLOBALS = {
         // given to internal elements like info box, options box, image gallery and all other phcode internal elements
@@ -133,7 +133,8 @@ function RemoteFunctions(config = {}) {
         if(element && // element should exist
             element.tagName.toLowerCase() !== "body" && // shouldn't be the body tag
             element.tagName.toLowerCase() !== "html" && // shouldn't be the HTML tag
-            !element.closest(`[${GLOBALS.PHCODE_INTERNAL_ATTR}]`) && // this attribute is used by phoenix internal elements
+            // this attribute is used by phoenix internal elements
+            !element.closest(`[${GLOBALS.PHCODE_INTERNAL_ATTR}]`) &&
             !_isInsideHeadTag(element)) { // shouldn't be inside the head tag like meta tags and all
             return true;
         }
@@ -1032,12 +1033,12 @@ function RemoteFunctions(config = {}) {
                 showPaddingMargin: true
             };
             var elementBounds = element.getBoundingClientRect(),
-                highlight = window.document.createElement("div"),
+                highlightDiv = window.document.createElement("div"),
                 elementStyling = window.getComputedStyle(element),
                 transitionDuration = parseFloat(elementStyling.getPropertyValue('transition-duration')),
                 animationDuration = parseFloat(elementStyling.getPropertyValue('animation-duration'));
 
-            highlight.trackingElement = element; // save which node are we highlighting
+            highlightDiv.trackingElement = element; // save which node are we highlighting
 
             if (doAnimation) {
                 if (transitionDuration) {
@@ -1162,19 +1163,19 @@ function RemoteFunctions(config = {}) {
                 drawMarginRect("left")
             ];
 
-            var setupVisualisations = function (arr, config) {
+            var setupVisualisations = function (arr, visualConfig) {
                 var i;
                 for (i = 0; i < arr.length; i++) {
                     setVisibility(arr[i]);
 
                     // Applies to every visualisationElement (padding or margin div)
                     arr[i]["transform"] = "none";
                     var el = window.document.createElement("div"),
-                        styles = Object.assign({}, config, arr[i]);
+                        styles = Object.assign({}, visualConfig, arr[i]);
 
                     _setStyleValues(styles, el.style);
 
-                    highlight.appendChild(el);
+                    highlightDiv.appendChild(el);
                 }
             };
 
@@ -1187,7 +1188,7 @@ function RemoteFunctions(config = {}) {
                 remoteHighlight.paddingStyling
             );
 
-            highlight.className = GLOBALS.HIGHLIGHT_CLASSNAME;
+            highlightDiv.className = GLOBALS.HIGHLIGHT_CLASSNAME;
 
             var offset = LivePreviewView.screenOffset(element);
 
@@ -1236,22 +1237,22 @@ function RemoteFunctions(config = {}) {
                 }
             }
 
-            _setStyleValues(mergedStyles, highlight.style);
+            _setStyleValues(mergedStyles, highlightDiv.style);
             _setStyleValues(
                 doAnimation ? animateStartValues : animateEndValues,
-                highlight.style
+                highlightDiv.style
             );
 
 
             if (doAnimation) {
-                _setStyleValues(transitionValues, highlight.style);
+                _setStyleValues(transitionValues, highlightDiv.style);
 
                 window.setTimeout(function () {
-                    _setStyleValues(animateEndValues, highlight.style);
+                    _setStyleValues(animateEndValues, highlightDiv.style);
                 }, 20);
             }
 
-            window.document.body.appendChild(highlight);
+            window.document.body.appendChild(highlightDiv);
         },
 
         add: function (element, doAnimation) {
@@ -1805,10 +1806,14 @@ function RemoteFunctions(config = {}) {
     /**
      * @private
      * @param {Node} node
-     * @return {boolean} true if node expects its content to be raw text (not parsed for entities) according to the HTML5 spec.
+     * @return {boolean} true if node expects its content to be
+     * raw text (not parsed for entities) according to the HTML5 spec.
      */
     function _isRawTextNode(node) {
-        return (node.nodeType === Node.ELEMENT_NODE && /script|style|noscript|noframes|noembed|iframe|xmp/i.test(node.tagName));
+        return (
+            node.nodeType === Node.ELEMENT_NODE &&
+            /script|style|noscript|noframes|noembed|iframe|xmp/i.test(node.tagName)
+        );
     }
 
     /**
@@ -1843,9 +1848,17 @@ function RemoteFunctions(config = {}) {
             end             = (edit.beforeID) ? this._queryBracketsID(edit.beforeID) : null,
             endMissing      = edit.beforeID && !end,
             moveNext        = start && nextIgnoringHighlights(start),
-            current         = moveNext || (end && prevIgnoringHighlights(end)) || lastChildIgnoringHighlights(targetElement),
+
+            current         = moveNext ||
+            (end && prevIgnoringHighlights(end)) || lastChildIgnoringHighlights(targetElement),
+
             next,
-            textNode        = (edit.content !== undefined) ? this.htmlDocument.createTextNode(_isRawTextNode(targetElement) ? edit.content : this._parseEntities(edit.content)) : null,
+
+            textNode        = (edit.content !== undefined) ?
+                this.htmlDocument.createTextNode(
+                    _isRawTextNode(targetElement) ? edit.content : this._parseEntities(edit.content)
+                ) : null,
+
             lastRemovedWasText,
             isText;
 
@@ -1902,7 +1915,8 @@ function RemoteFunctions(config = {}) {
         this.rememberedNodes = {};
 
         edits.forEach(function (edit) {
-            var editIsSpecialTag = edit.type === "elementInsert" && (edit.tag === "html" || edit.tag === "head" || edit.tag === "body");
+            var editIsSpecialTag = edit.type === "elementInsert" &&
+                (edit.tag === "html" || edit.tag === "head" || edit.tag === "body");
 
             if (edit.type === "rememberNodes") {
                 edit.tagIDs.forEach(function (tagID) {
@@ -1979,7 +1993,9 @@ function RemoteFunctions(config = {}) {
                 self._insertChildNode(targetElement, childElement, edit);
                 break;
             case "textInsert":
-                var textElement = self.htmlDocument.createTextNode(_isRawTextNode(targetElement) ? edit.content : self._parseEntities(edit.content));
+                var textElement = self.htmlDocument.createTextNode(
+                    _isRawTextNode(targetElement) ? edit.content : self._parseEntities(edit.content)
+                );
                 self._insertChildNode(targetElement, textElement, edit);
                 break;
             case "textReplace":