refactor: remoteHighlight var to fn scope instead of global

Author: abose

src/LiveDevelopment/BrowserScripts/RemoteFunctions.js

@@ -111,24 +111,6 @@ function RemoteFunctions(config = {}) {
      */
     var _editHandler;
 
-    let remoteHighlight = {
-        animateStartValue: {
-            "background-color": "rgba(0, 162, 255, 0.5)",
-            "opacity": 0
-        },
-        animateEndValue: {
-            "background-color": "rgba(0, 162, 255, 0)",
-            "opacity": 0.6
-        },
-        paddingStyling: {
-            "background-color": "rgba(200, 249, 197, 0.7)"
-        },
-        marginStyling: {
-            "background-color": "rgba(249, 204, 157, 0.7)"
-        },
-        borderColor: "rgba(200, 249, 197, 0.85)",
-        showPaddingMargin: true
-    };
     let strings = {}, icons = {}, cssStyles = {}; // these will be injected below
     // the below code comment is replaced by added scripts for extensibility
     // DONT_STRIP_MINIFY:REPLACE_WITH_ADDED_REMOTE_CONSTANT_SCRIPTS
@@ -4059,6 +4041,24 @@ function RemoteFunctions(config = {}) {
             return false;
         },
         _makeHighlightDiv: function (element, doAnimation) {
+            const remoteHighlight = {
+                animateStartValue: {
+                    "background-color": "rgba(0, 162, 255, 0.5)",
+                    "opacity": 0
+                },
+                animateEndValue: {
+                    "background-color": "rgba(0, 162, 255, 0)",
+                    "opacity": 0.6
+                },
+                paddingStyling: {
+                    "background-color": "rgba(200, 249, 197, 0.7)"
+                },
+                marginStyling: {
+                    "background-color": "rgba(249, 204, 157, 0.7)"
+                },
+                borderColor: "rgba(200, 249, 197, 0.85)",
+                showPaddingMargin: true
+            };
             var elementBounds = element.getBoundingClientRect(),
                 highlight = window.document.createElement("div"),
                 elementStyling = window.getComputedStyle(element),