fix: dirty marker appears after undo operation

devvaannsh · devvaannsh · commit 3f18d584acd2 · 2025-08-24T23:10:06.000+05:30
diff --git a/src/LiveDevelopment/BrowserScripts/RemoteFunctions.js b/src/LiveDevelopment/BrowserScripts/RemoteFunctions.js
@@ -137,19 +137,20 @@ function RemoteFunctions(config = {}) {
     }
 
     // helper function to check if an element is inside the HEAD tag
-    // we need this because we don't wanna trigger the element highlights on head tag and its children
+    // we need this because we don't wanna trigger the element highlights on head tag and its children,
+    // except for <style> tags which should be allowed
     function _isInsideHeadTag(element) {
         let parent = element;
         while (parent && parent !== window.document) {
             if (parent.tagName === "HEAD") {
-                return true;
+                // allow <style> tags inside <head>
+                return element.tagName !== "STYLE";
             }
             parent = parent.parentElement;
         }
         return false;
     }
 
-
     // compute the screen offset of an element
     function _screenOffset(element) {
         var elemBounds = element.getBoundingClientRect(),
diff --git a/src/LiveDevelopment/LivePreviewEdit.js b/src/LiveDevelopment/LivePreviewEdit.js
@@ -194,8 +194,12 @@ define(function (require, exports, module) {
         // this is a quick trick because as the code is changed for that element in the file,
         // the live preview for that element gets refreshed and the changes are discarded in the live preview
         if(!message.isEditSuccessful) {
-            editor.replaceRange(text, startPos, endPos);
-            editor.document._markClean();
+            editor.document.batchOperation(function () {
+                editor.replaceRange(text, startPos, endPos);
+                setTimeout(() => {
+                    editor.undo(); // undo the replaceRange so dirty icon won't appear and no net change in undo history
+                }, 0);
+            });
         } else {
 
             // if the edit operation was successful, we call a helper function that

Original file line number	Diff line number	Diff line change
`@@ -137,19 +137,20 @@ function RemoteFunctions(config = {}) {`
`137`	`137`	`}`
`138`	`138`
`139`	`139`	`// helper function to check if an element is inside the HEAD tag`
`140`		`- // we need this because we don't wanna trigger the element highlights on head tag and its children`
	`140`	`+ // we need this because we don't wanna trigger the element highlights on head tag and its children,`
	`141`	`+ // except for <style> tags which should be allowed`
`141`	`142`	`function _isInsideHeadTag(element) {`
`142`	`143`	`let parent = element;`
`143`	`144`	`while (parent && parent !== window.document) {`
`144`	`145`	`if (parent.tagName === "HEAD") {`
`145`		`- return true;`
	`146`	`+ // allow <style> tags inside <head>`
	`147`	`+ return element.tagName !== "STYLE";`
`146`	`148`	`}`
`147`	`149`	`parent = parent.parentElement;`
`148`	`150`	`}`
`149`	`151`	`return false;`
`150`	`152`	`}`
`151`	`153`
`152`		`-`
`153`	`154`	`// compute the screen offset of an element`
`154`	`155`	`function _screenOffset(element) {`
`155`	`156`	`var elemBounds = element.getBoundingClientRect(),`