fix: logger for node in dev and device licensing working in mac

Author: abose

src-node/utils.js

@@ -9,7 +9,7 @@ const {lintFile} = require("./ESLint/service");
 let openModule, open; // dynamic import when needed
 
 const options = { name: 'Phoenix Code' };
-const content = '{"licensedDevice": true}\n';
+const licenseFileContent = JSON.stringify({licensedDevice: true});
 
 async function _importOpen() {
     if(open){
@@ -303,21 +303,29 @@ function readFileUtf8(p) {
     });
 }
 
+/**
+ * Writes the license file in a world-readable location.
+ * Works on Windows, macOS, and Linux.
+ */
 async function addDeviceLicense() {
     const targetPath = getLicensePath();
     let command;
 
     if (os.platform() === 'win32') {
-        // PowerShell with explicit dirs and safe quoting
+        // Windows: write file and explicitly grant Everyone read rights
         const dir = 'C:\\Program Files\\Phoenix Code Control';
-        const psContent = content.replace(/'/g, "''");
-        command = `powershell -Command "New-Item -ItemType Directory -Force '${dir}' | Out-Null; Set-Content -Path '${targetPath}' -Value '${psContent}' -Encoding UTF8"`;
+        command =
+            `powershell -Command "` +
+            `New-Item -ItemType Directory -Force '${dir}' | Out-Null; ` +
+            `Set-Content -Path '${targetPath}' -Value '${licenseFileContent}' -Encoding UTF8; ` +
+            `icacls '${targetPath}' /inheritance:e /grant *S-1-1-0:RX | Out-Null"`;
     } else {
+        // macOS / Linux: mkdir + write + chmod 0644 (world-readable, owner-writable)
         const dir = path.dirname(targetPath);
-        // POSIX: mkdir + printf (use absolute paths)
-        const safe = content.replace(/'/g, `'\\''`);
-        // todo we need to chmod to make this world readable
-        command = `/bin/mkdir -p "${dir}" && /bin/printf '%s' '${safe}' > "${targetPath}"`;
+        command =
+            `/bin/mkdir -p "${dir}"` +
+            ` && printf '%s' '${licenseFileContent}' > "${targetPath}"` +
+            ` && /bin/chmod 0644 "${targetPath}"`;
     }
 
     await sudoExec(command);
@@ -363,6 +371,10 @@ async function _getLinuxDeviceID() {
  * @returns {Promise<string|null>}
  */
 function _getMacDeviceID() {
+    // to read this in mac bash, do:
+    // #!/bin/bash
+    // device_id=$(ioreg -rd1 -c IOPlatformExpertDevice | awk -F\" '/IOPlatformUUID/ {print $4}' | tr -d '[:space:]')
+    // echo "$device_id"
     return new Promise((resolve, reject) => {
         exec(
             'ioreg -rd1 -c IOPlatformExpertDevice | grep IOPlatformUUID',

src/loggerSetup.js

@@ -68,6 +68,8 @@
                 Bugsnag.notify(message?
                     new CustomBugSnagError(message, error)
                     :error);
+            } else {
+                console.error(message, error, error.nodeStack);
             }
         },
         /**
@@ -79,6 +81,8 @@
         reportErrorMessage: function (message) {
             if(isBugsnagEnabled) {
                 Bugsnag.notify(new CustomBugSnagError(message));
+            } else {
+                console.error(message);
             }
         },
 

src/nls/root/strings.js

@@ -1712,6 +1712,7 @@ define({
     "LICENSE_ACTIVATE_SUCCESS": "License activated system-wide. Please restart {APP_NAME} for the changes to take effect.",
     "LICENSE_ACTIVATE_SUCCESS_PARTIAL": "License activated for your account only (not system-wide). Please restart {APP_NAME} for the changes to take effect.",
     "LICENSE_ACTIVATE_FAIL": "Failed to activate license",
+    "LICENSE_ACTIVATE_FAIL_APPLY": "'Failed to apply license to device'",
     "LICENSE_ENTER_KEY": "Please enter a license key",
     "LICENSE_REAPPLY_TO_DEVICE": "Already activated? Reapply system-wide"
 });

src/services/manage-licenses.js

@@ -274,10 +274,10 @@ define(function (require, exports, module) {
                 // Refresh license status
                 await _loadLicenseStatus($dialog);
             } else {
-                _showActivationMessage($dialog, false, 'Failed to apply license to device');
+                _showActivationMessage($dialog, false, Strings.LICENSE_ACTIVATE_FAIL_APPLY);
             }
         } catch (error) {
-            _showActivationMessage($dialog, false, error.message || 'Failed to apply license to device');
+            _showActivationMessage($dialog, false, Strings.LICENSE_ACTIVATE_FAIL_APPLY);
         } finally {
             // Reset link state
             $link.html(originalText);