build: remove optional extension after build

Author: abose

gulpfile.js/index.js

@@ -91,19 +91,22 @@ function _cleanPhoenixProGitFolder() {
 
 function _deletePhoenixProSourceFolder() {
     return new Promise((resolve) => {
-        // todo we cant do this yet lots of issues happening due to missing files in dist test mainly
-        //  which i also suspect are actual issues
-        // const phoenixProFolders = [
-        //     'dist/extensionsIntegrated/phoenix-pro',
-        //     'dist-test/src/extensionsIntegrated/phoenix-pro'
-        // ];
-        //
-        // for (const folder of phoenixProFolders) {
-        //     if (fs.existsSync(folder)) {
-        //         fs.rmSync(folder, { recursive: true, force: true });
-        //         console.log(`Deleted phoenix-pro source folder: ${folder}`);
-        //     }
-        // }
+        const phoenixProFolders = [
+            // we only delete the source folder from the release build artifact and not the test artifact. why below?
+            'dist/extensionsIntegrated/phoenix-pro'
+            // 'dist-test/src/extensionsIntegrated/phoenix-pro' // ideally we should delete this too so that the tests
+            // test exactly the release build artifact, but the spec runner requires on these files during test start
+            // and i wasnt able to isolate them. so instead wehat we do now is that we have an additional test in prod
+            // that checks that the phoenix-pro source folder is not loaded in prod and loaded only from the inlines
+            // brackets-min file.
+        ];
+
+        for (const folder of phoenixProFolders) {
+            if (fs.existsSync(folder)) {
+                fs.rmSync(folder, { recursive: true, force: true });
+                console.log(`Deleted phoenix-pro source folder: ${folder}`);
+            }
+        }
         resolve();
     });
 }

src/extensionsIntegrated/phoenix-pro/README.md

@@ -0,0 +1,6 @@
+## Build notes
+All files this in this folder will be deleted in the prod build by the build script at `gulpfile.js/index.js`
+in phoenix code. This is because the code will be inlined in brackets-min.js. If you want to retain any files
+in this folder at distribution (strongly discouraged without reason), please update the function in
+build script `_deletePhoenixProSourceFolder()`. You may only do this for images,or other binary resources, which
+shouldn't be in the source in the first place.