Skip to content

Commit 5e16ccd

Browse files
devvaannshabose
authored andcommitted
chore: add missing strings for localization
1 parent 5c7362b commit 5e16ccd

File tree

3 files changed

+10
-1
lines changed

3 files changed

+10
-1
lines changed

src/command/Menus.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -737,6 +737,11 @@ define(function (require, exports, module) {
737737
logger.leaveTrail("UI Menu Click: " + menuItem._command.getID());
738738
MainViewManager.focusActivePane();
739739
if (menuItem._command._options.eventSource) {
740+
// NOTE: Ideally beforeExecuteCommand should be fired inside Command.execute itself.
741+
// But right now Command.execute() bypasses the event flow
742+
// So we run through CommandManager.execute() to keep things consistent
743+
// (keyboard + menu both go through the same path)
744+
// Read this for more info: https://github.com/phcode-dev/phoenix/pull/2356
740745
CommandManager.execute(menuItem._command.getID(), {
741746
eventSource: CommandManager.SOURCE_UI_MENU_CLICK,
742747
sourceType: self.id

src/extensionsIntegrated/CollapseFolders/main.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
define(function (require, exports, module) {
2525
const AppInit = require("utils/AppInit");
2626
const ProjectManager = require("project/ProjectManager");
27+
const Strings = require("strings");
2728

2829
/**
2930
* This is the main function that handles the closing of all the directories
@@ -64,7 +65,7 @@ define(function (require, exports, module) {
6465

6566
// create the collapse btn
6667
const $collapseBtn = $(`
67-
<div id="collapse-folders" class="btn-alt-quiet" title="Collapse All">
68+
<div id="collapse-folders" class="btn-alt-quiet" title="${Strings.COLLAPSE_ALL_FOLDERS}">
6869
<i class="fa-solid fa-chevron-down collapse-icon" aria-hidden="true"></i>
6970
<i class="fa-solid fa-chevron-up collapse-icon" aria-hidden="true"></i>
7071
</div>

src/nls/root/strings.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1608,6 +1608,9 @@ define({
16081608
"AI_QUOTA_USED": "AI quota used",
16091609
"LOGIN_REFRESH": "Check Login Status",
16101610

1611+
// Collapse Folders
1612+
"COLLAPSE_ALL_FOLDERS": "Collapse All Folders",
1613+
16111614
// Custom Snippets
16121615
"CUSTOM_SNIPPETS_MENU_ITEM_NAME": "Custom Snippets\u2026",
16131616
"CUSTOM_SNIPPETS_PANEL_TITLE": "Custom Snippets",

0 commit comments

Comments
 (0)