feat: add css lint integ tests

Author: abose

test/UnitTestSuite.js

@@ -120,6 +120,8 @@ define(function (require, exports, module) {
     require("spec/Extn-RemoteFileAdapter-integ-test");
     require("spec/Extn-NavigationAndHistory-integ-test");
     require("spec/Extn-RecentProjects-integ-test");
+    // extension integration tests
+    require("spec/Extn-CSSCodeHints-integ-test");
     // Node Tests
     require("spec/NodeConnection-test");
     // todo TEST_MODERN

test/spec/Extn-CSSCodeHints-integ-test.js

@@ -0,0 +1,150 @@
+/*
+ * GNU AGPL-3.0 License
+ *
+ * Copyright (c) 2021 - present core.ai . All rights reserved.
+ * Original work Copyright (c) 2013 - 2021 Adobe Systems Incorporated. All rights reserved.
+ *
+ * This program is free software: you can redistribute it and/or modify it
+ * under the terms of the GNU Affero General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public License
+ * for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program. If not, see https://opensource.org/licenses/AGPL-3.0.
+ *
+ */
+
+/*global describe, it, expect, beforeEach, awaitsFor, awaitsForDone, afterAll */
+
+define(function (require, exports, module) {
+
+
+    const SpecRunnerUtils    = require("spec/SpecRunnerUtils");
+
+    describe("integration:CSS Code Hints Language Service", function () {
+        let testFolder = SpecRunnerUtils.getTestPath("/spec/LanguageTools-test-files/css-language-service");
+
+        // load from testWindow
+        let testWindow,
+            brackets,
+            EditorManager,
+            QuickView,
+            editor,
+            testFile = "css-lint-errors.css";
+
+        beforeEach(async function () {
+            // Create a new window that will be shared by ALL tests in this spec.
+            if (!testWindow) {
+                testWindow = await SpecRunnerUtils.createTestWindowAndRun();
+
+                await SpecRunnerUtils.loadProjectInTestWindow(testFolder);
+            }
+
+            // Load module instances from brackets.test
+            brackets = testWindow.brackets;
+            EditorManager = brackets.test.EditorManager;
+            QuickView = brackets.test.QuickViewManager;
+
+            await awaitsForDone(SpecRunnerUtils.openProjectFiles([testFile]), "open test file: " + testFile);
+
+            editor  = EditorManager.getCurrentFullEditor();
+        }, 30000);
+
+        afterAll(async function () {
+            testWindow       = null;
+            brackets         = null;
+            EditorManager    = null;
+            QuickView        = null;
+            await SpecRunnerUtils.closeTestWindow();
+        }, 30000);
+
+        async function getPopoverAtPos(lineNum, columnNum) {
+            editor  = EditorManager.getCurrentFullEditor();
+            let cm = editor._codeMirror,
+                pos = { line: lineNum, ch: columnNum },
+                token;
+
+            editor.setCursorPos(pos);
+            token = cm.getTokenAt(pos, true);
+
+            return QuickView._queryPreviewProviders(editor, pos, token);
+        }
+
+        async function expectNoCSSLintQuickViewAtPos(line, ch) {
+            let popoverInfo = await getPopoverAtPos(line, ch);
+            if(popoverInfo){
+                expect(popoverInfo.content.find(".code-inspection-item").length).toBe(0);
+            }
+        }
+
+        async function checkCSSWarningAtPos(expectedWarning, line, ch) {
+            await awaitsFor(async ()=>{
+                return await getPopoverAtPos(line, ch);
+            }, "popover to be present");
+            let popoverInfo = await getPopoverAtPos(line, ch);
+            expect(popoverInfo.content.find(".code-inspection-item").text().trim()).toBe(expectedWarning);
+        }
+
+        describe("CSS warnings quick view", function () {
+            it("Should show warning", async function () {
+                await checkCSSWarningAtPos("Do not use empty rulesets (emptyRules)", 2, 0);
+            });
+
+            it("Should show no warning for imports", async function () {
+                await expectNoCSSLintQuickViewAtPos(1, 1);
+            });
+
+            it("Should show duplicate properties warning", async function () {
+                await checkCSSWarningAtPos("Do not use duplicate style definitions (duplicateProperties)",
+                    5, 8);
+                await checkCSSWarningAtPos("Do not use duplicate style definitions (duplicateProperties)",
+                    6, 8);
+            });
+
+            it("Should show duplicate properties warning", async function () {
+                await checkCSSWarningAtPos("No unit for zero needed (zeroUnits)",
+                    10, 11);
+            });
+
+            it("Should show no warning for box model", async function () {
+                // dont use width and height when using padding
+                await expectNoCSSLintQuickViewAtPos(14, 8);
+                await expectNoCSSLintQuickViewAtPos(15, 8);
+                await expectNoCSSLintQuickViewAtPos(16, 8);
+            });
+
+            it("Should show unknown properties warning", async function () {
+                await checkCSSWarningAtPos("Unknown property: 'doesntExist' (unknownProperties)",
+                    20, 8);
+            });
+
+            it("Should show ie hack warning", async function () {
+                await checkCSSWarningAtPos("IE hacks are only necessary when supporting IE7 and older (ieHack)",
+                    25, 8);
+            });
+
+            it("Should show ignored due to display warning", async function () {
+                await checkCSSWarningAtPos("inline-block is ignored due to the float. If 'float' has a value other than 'none', the box is floated and 'display' is treated as 'block' (propertyIgnoredDueToDisplay)",
+                    30, 8);
+            });
+
+            it("Should show no warning on !important", async function () {
+                await expectNoCSSLintQuickViewAtPos(34, 8);
+                await expectNoCSSLintQuickViewAtPos(35, 8);
+            });
+
+            it("Should show font-face warning", async function () {
+                await checkCSSWarningAtPos("@font-face rule must define 'src' and 'font-family' properties (fontFaceProperties)",
+                    38, 8);
+                await checkCSSWarningAtPos("@font-face rule must define 'src' and 'font-family' properties (fontFaceProperties)",
+                    39, 8);
+            });
+        });
+
+    });
+});

test/spec/LanguageTools-test-files/css-language-service/css-lint-errors.css

@@ -0,0 +1,45 @@
+@import "no-error.css";
+
+.empty-css-error {}
+
+.duplicate-properties-warning {
+    color: red;
+    color: blue;
+}
+
+.zero-units-warning {
+    width: 0px;
+}
+
+.box-model-no-warning {
+    width: 300px;
+    padding: 50px;
+    border: 5px solid black;
+}
+
+.unknown-properties-warning {
+    doesntExist: 300px;
+}
+
+.ie-hack-warning {
+    color: blue; /* For modern browsers */
+    _color: red; /* This color is only for IE 6 and below */
+}
+
+.property-ignored-due-to-display-warning {
+    display: inline-block;
+    float: right;
+}
+
+.no-warnings-on-important {
+    width: 0 !important;
+    height: 0 !important;
+}
+
+@font-face {
+    font-family: 'needa default font warning';
+}
+
+.unknown-vendor-prefix-warning {
+    -microsoft-border-radius: 5px;
+}