Skip to content

Commit 73f2ac2

Browse files
committed
fix: prevent more options dropdown from resizing because of checkmark
1 parent bc6972d commit 73f2ac2

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

src/LiveDevelopment/BrowserScripts/RemoteFunctions.js

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1946,10 +1946,10 @@ function RemoteFunctions(config = {}) {
19461946
enabled: config.showRulerLines
19471947
});
19481948

1949-
// add checkmark in the dropdown
1949+
// toggle checkmark visibility in the dropdown
19501950
const checkmark = dropdown._shadow.querySelector('[data-action="toggle-ruler-lines"] .item-checkmark');
19511951
if (checkmark) {
1952-
checkmark.textContent = config.showRulerLines ? '' : '';
1952+
checkmark.style.visibility = config.showRulerLines ? 'visible' : 'hidden';
19531953
}
19541954

19551955
// to apply the ruler lines or remove it when option is toggled
@@ -2075,7 +2075,7 @@ function RemoteFunctions(config = {}) {
20752075
<div class="dropdown-item" data-action="toggle-ruler-lines">
20762076
<span class="item-icon">${ICONS.ruler}</span>
20772077
<span class="item-label">${config.strings.showRulerLines}</span>
2078-
<span class="item-checkmark">${config.showRulerLines ? '' : ''}</span>
2078+
<span class="item-checkmark" style="visibility: ${config.showRulerLines ? 'visible' : 'hidden'}">✓</span>
20792079
</div>
20802080
</div>
20812081
`;
@@ -2151,7 +2151,6 @@ function RemoteFunctions(config = {}) {
21512151
margin-left: auto !important;
21522152
padding-left: 4px !important;
21532153
font-size: 14px !important;
2154-
margin-top: -4px !important;
21552154
}
21562155
`;
21572156

@@ -2206,10 +2205,10 @@ function RemoteFunctions(config = {}) {
22062205
},
22072206

22082207
refresh: function() {
2209-
// update the checkmark state when config changes
2208+
// update the checkmark visibility when config changes
22102209
const checkmark = this._shadow.querySelector('[data-action="toggle-ruler-lines"] .item-checkmark');
22112210
if (checkmark) {
2212-
checkmark.textContent = config.showRulerLines ? '' : '';
2211+
checkmark.style.visibility = config.showRulerLines ? 'visible' : 'hidden';
22132212
}
22142213
}
22152214
};

0 commit comments

Comments
 (0)