Skip to content

Commit 743e87f

Browse files
committed
refactor: remove redundant dismissed tracking
1 parent 778d41c commit 743e87f

File tree

1 file changed

+5
-30
lines changed

1 file changed

+5
-30
lines changed

src/LiveDevelopment/BrowserScripts/RemoteFunctions.js

Lines changed: 5 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -4003,41 +4003,32 @@ function RemoteFunctions(config = {}) {
40034003

40044004
/**
40054005
* Helper function to dismiss NodeMoreOptionsBox if it exists
4006-
* @return {boolean} true if box was dismissed, false if it didn't exist
40074006
*/
40084007
function dismissNodeMoreOptionsBox() {
40094008
if (_nodeMoreOptionsBox) {
40104009
_nodeMoreOptionsBox.remove();
40114010
_nodeMoreOptionsBox = null;
4012-
return true;
40134011
}
4014-
return false;
40154012
}
40164013

40174014
/**
40184015
* Helper function to dismiss NodeInfoBox if it exists
4019-
* @return {boolean} true if box was dismissed, false if it didn't exist
40204016
*/
40214017
function dismissNodeInfoBox() {
40224018
if (_nodeInfoBox) {
40234019
_nodeInfoBox.remove();
40244020
_nodeInfoBox = null;
4025-
return true;
40264021
}
4027-
return false;
40284022
}
40294023

40304024
/**
40314025
* Helper function to dismiss AIPromptBox if it exists
4032-
* @return {boolean} true if box was dismissed, false if it didn't exist
40334026
*/
40344027
function dismissAIPromptBox() {
40354028
if (_aiPromptBox) {
40364029
_aiPromptBox.remove();
40374030
_aiPromptBox = null;
4038-
return true;
40394031
}
4040-
return false;
40414032
}
40424033

40434034
/**
@@ -4047,26 +4038,20 @@ function RemoteFunctions(config = {}) {
40474038
if (_imageRibbonGallery) {
40484039
_imageRibbonGallery.remove();
40494040
_imageRibbonGallery = null;
4050-
return true;
40514041
}
4052-
return false;
40534042
}
40544043

40554044
/**
40564045
* Helper function to dismiss all UI boxes at once
4057-
* @return {boolean} true if any boxes were dismissed, false otherwise
40584046
*/
40594047
function dismissAllUIBoxes() {
4060-
let dismissed = false;
4061-
dismissed = dismissNodeMoreOptionsBox() || dismissed;
4062-
dismissed = dismissAIPromptBox() || dismissed;
4063-
dismissed = dismissNodeInfoBox() || dismissed;
4064-
return dismissed;
4048+
dismissNodeMoreOptionsBox();
4049+
dismissAIPromptBox();
4050+
dismissNodeInfoBox();
40654051
}
40664052

40674053
/**
40684054
* Helper function to cleanup previously clicked element highlighting and state
4069-
* @return {boolean} true if cleanup was performed, false if no element to cleanup
40704055
*/
40714056
function cleanupPreviousElementState() {
40724057
if (previouslyClickedElement) {
@@ -4083,26 +4068,16 @@ function RemoteFunctions(config = {}) {
40834068
}
40844069

40854070
previouslyClickedElement = null;
4086-
return true;
40874071
}
4088-
return false;
40894072
}
40904073

40914074
/**
40924075
* This function dismisses all UI elements and cleans up application state
40934076
* Called when user presses Esc key, clicks on HTML/Body tags, or other dismissal events
4094-
* @return {boolean} true if any cleanup was performed, false otherwise
40954077
*/
40964078
function dismissUIAndCleanupState() {
4097-
let dismissed = false;
4098-
4099-
// Dismiss all UI boxes
4100-
dismissed = dismissAllUIBoxes() || dismissed;
4101-
4102-
// Cleanup previously clicked element state and highlighting
4103-
dismissed = cleanupPreviousElementState() || dismissed;
4104-
4105-
return dismissed;
4079+
dismissAllUIBoxes();
4080+
cleanupPreviousElementState();
41064081
}
41074082

41084083

0 commit comments

Comments
 (0)