feat: add tab bar toggle option inside view menu

Author: devvaannsh

src/command/Commands.js

@@ -260,6 +260,10 @@ define(function (require, exports, module) {
     /** Toggles sidebar visibility */
     exports.VIEW_HIDE_SIDEBAR           = "view.toggleSidebar";         // SidebarView.js               toggle()
 
+    /** Toggles tabbar visibility */
+    exports.TOGGLE_TABBAR            = "view.toggleTabbar";
+    // extensionsIntegrated/TabBar/main.js
+
     /** Zooms in the editor view */
     exports.VIEW_ZOOM_IN                = "view.zoomIn";                // ViewCommandHandlers.js       _handleZoomIn()
 

src/extensionsIntegrated/TabBar/main.js

@@ -10,6 +10,8 @@ define(function (require, exports, module) {
     const Commands = require("command/Commands");
     const DocumentManager = require("document/DocumentManager");
     const WorkspaceManager = require("view/WorkspaceManager");
+    const Menus = require("command/Menus");
+    const Strings = require("strings");
 
     const Global = require("./global");
     const Helper = require("./helper");
@@ -458,24 +460,50 @@ define(function (require, exports, module) {
 
 
     /**
-     * This is called when the tab bar preference is changed
+     * This is called when the tab bar preference is changed either,
+     * from the preferences file or the menu bar
      * It takes care of creating or cleaning up the tab bar
      */
     function preferenceChanged() {
-        Preference.tabBarEnabled = PreferencesManager.get(Preference.PREFERENCES_TAB_BAR).showTabBar;
-        Preference.tabBarNumberOfTabs = PreferencesManager.get(Preference.PREFERENCES_TAB_BAR).numberOfTabs;
+        const prefs = PreferencesManager.get(Preference.PREFERENCES_TAB_BAR);
+        Preference.tabBarEnabled = prefs.showTabBar;
+        Preference.tabBarNumberOfTabs = prefs.numberOfTabs;
+
+        // Update menu checkmark
+        CommandManager.get(Commands.TOGGLE_TABBAR).setChecked(prefs.showTabBar);
 
-        // preference should be enabled and number of tabs should be greater than 0
         if (Preference.tabBarEnabled && Preference.tabBarNumberOfTabs !== 0) {
             createTabBar();
         } else {
             cleanupTabBar();
         }
     }
 
+    /**
+     * Registers the commands,
+     * for toggling the tab bar from the menu bar
+     */
+    function _registerCommands() {
+        CommandManager.register(
+            Strings.CMD_TOGGLE_TABBAR,
+            Commands.TOGGLE_TABBAR,
+            () => {
+                const currentPref = PreferencesManager.get(Preference.PREFERENCES_TAB_BAR);
+                PreferencesManager.set(Preference.PREFERENCES_TAB_BAR, {
+                    ...currentPref,
+                    showTabBar: !currentPref.showTabBar
+                });
+            }
+        );
+    }
 
 
     AppInit.appReady(function () {
+        _registerCommands();
+
+        // add the toggle tab bar command to the view menu
+        const viewMenu = Menus.getMenu(Menus.AppMenuBar.VIEW_MENU);
+        viewMenu.addMenuItem(Commands.TOGGLE_TABBAR, "", Menus.AFTER, Commands.VIEW_HIDE_SIDEBAR);
 
         PreferencesManager.on("change", Preference.PREFERENCES_TAB_BAR, preferenceChanged);
         // calling preference changed here itself to check if the tab bar is enabled,

src/extensionsIntegrated/TabBar/preference.js

@@ -1,7 +1,6 @@
 
 /*
  * This script contains the preference settings for the tab bar.
- * TODO: It also will have the tab bar options that will be added in menu bar and other places.
  */
 define(function (require, exports, module) {
     const PreferencesManager = require("preferences/PreferencesManager");

src/nls/root/strings.js

@@ -552,6 +552,7 @@ define({
     "CMD_HIDE_SIDEBAR": "Hide Sidebar",
     "CMD_SHOW_SIDEBAR": "Show Sidebar",
     "CMD_TOGGLE_SIDEBAR": "Toggle Sidebar",
+    "CMD_TOGGLE_TABBAR": "Toggle Tab Bar",
     "CMD_TOGGLE_PANELS": "Toggle Panels",
     "CMD_TOGGLE_PURE_CODE": "No Distractions",
     "CMD_TOGGLE_FULLSCREEN": "Fullscreen",