chore: remove jshint as default linter to prepare for eslint

Author: abose

src/extensions/default/JSHint/main.js

@@ -46,6 +46,8 @@ define(function (require, exports, module) {
         projectSpecificOptions = null,
         jsHintConfigFileErrorMessage = null;
 
+    const PREFS_JSHINT_DISABLED = "disabled";
+
     // We don't provide default options in the preferences as preferences will try to mixin default options with
     // user defined options leading to unexpected results. Either we take user defined options or default, no mixin.
     let DEFAULT_OPTIONS = {
@@ -58,8 +60,8 @@ define(function (require, exports, module) {
         "devel": false
     };
 
-    prefs.definePreference("options", "object", {}, {
-        description: Strings.DESCRIPTION_JSHINT_OPTIONS
+    prefs.definePreference(PREFS_JSHINT_DISABLED, "boolean", false, {
+        description: Strings.DESCRIPTION_JSHINT_DISABLE
     }).on("change", function () {
         CodeInspection.requestRun(Strings.JSHINT_NAME);
     });
@@ -86,9 +88,7 @@ define(function (require, exports, module) {
             // If a line contains only whitespace (here spaces or tabs), remove the whitespace
             text = text.replace(/^[ \t]+$/gm, "");
 
-            let userPrefOptions = _.isEmpty(prefs.get("options")) ? DEFAULT_OPTIONS : prefs.get("options");
-
-            let options = projectSpecificOptions || userPrefOptions;
+            let options = projectSpecificOptions || DEFAULT_OPTIONS;
 
             IndexingWorker.execPeer("jsHint", {
                 text,
@@ -230,6 +230,7 @@ define(function (require, exports, module) {
             _reloadOptions();
         } else if(_isFileInArray(configFilePath, removed)){
             projectSpecificOptions = null;
+            jsHintConfigFileErrorMessage = null;
         }
     }
 
@@ -244,7 +245,8 @@ define(function (require, exports, module) {
         name: Strings.JSHINT_NAME,
         scanFileAsync: lintOneFile,
         canInspect: function (fullPath) {
-            return fullPath && !fullPath.endsWith(".min.js");
+            return !prefs.get(PREFS_JSHINT_DISABLED) && (projectSpecificOptions || jsHintConfigFileErrorMessage)
+                && fullPath && !fullPath.endsWith(".min.js");
         }
     });
 });

src/nls/root/strings.js

@@ -952,7 +952,7 @@ define({
     "DESCRIPTION_HIGHLIGHT_MATCHES_WORDS_ONLY": "Highlight only when selection is a complete token",
     "DESCRIPTION_INSERT_HINT_ON_TAB": "true to insert the currently selected code hint on tab",
     "DESCRIPTION_NO_HINTS_ON_DOT": "true to not automatically show JS code hints when . is typed",
-    "DESCRIPTION_JSHINT_OPTIONS": "An object with the default options for JSHint. Please see the following URL for all available JSHint Options: https://jshint.com/docs/options/",
+    "DESCRIPTION_JSHINT_DISABLE": "true to disable JSHints linter in problems panel",
     "DESCRIPTION_LANGUAGE": "Language specific settings",
     "DESCRIPTION_LANGUAGE_FILE_EXTENSIONS": "Additional mappings from file extension to language name",
     "DESCRIPTION_LANGUAGE_FILE_NAMES": "Additional mappings from file name to language name",