fix: entitlments cache misses for valid null entitlement

Author: abose

src/services/EntitlementsManager.js

@@ -73,13 +73,13 @@ define(function (require, exports, module) {
             });
     }
 
-    let effectiveEntitlements = null;
+    let effectiveEntitlementsCached = undefined; // entitlements can be null and its valid if no login/trial
     async function _getEffectiveEntitlements() {
-        if(effectiveEntitlements){
-            return effectiveEntitlements;
+        if(effectiveEntitlementsCached !== undefined){
+            return effectiveEntitlementsCached;
         }
         const entitlements = await LoginService.getEffectiveEntitlements();
-        effectiveEntitlements = entitlements;
+        effectiveEntitlementsCached = entitlements;
         return entitlements;
     }
 
@@ -178,7 +178,7 @@ define(function (require, exports, module) {
         LoginService = KernalModeTrust.loginService;
         // Set up event forwarding from LoginService
         LoginService.on(LoginService.EVENT_ENTITLEMENTS_CHANGED, function() {
-            effectiveEntitlements = null;
+            effectiveEntitlementsCached = null;
             EntitlementsManager.trigger(EVENT_ENTITLEMENTS_CHANGED);
         });
         AIControl.init();

src/services/login-service.js

@@ -72,7 +72,7 @@ define(function (require, exports, module) {
     const EVENT_ENTITLEMENTS_CHANGED = "entitlements_changed";
 
     // Cached entitlements data
-    let cachedEntitlements = null;
+    let cachedEntitlements = undefined;
 
     // Last recorded state for entitlements monitoring
     let lastRecordedState = null;
@@ -266,7 +266,7 @@ define(function (require, exports, module) {
         }
 
         // Return cached data if available and not forcing refresh
-        if (cachedEntitlements && !forceRefresh) {
+        if (cachedEntitlements !== undefined && !forceRefresh) {
             return cachedEntitlements;
         }
 
@@ -388,7 +388,7 @@ define(function (require, exports, module) {
      */
     async function clearEntitlements() {
         if (cachedEntitlements) {
-            cachedEntitlements = null;
+            cachedEntitlements = undefined;
             _debounceEntitlementsChanged();
         }
         // Reset device license state so it's re-evaluated on next entitlement check