chore: null checks/fensing

Author: abose

src/extensionsIntegrated/Phoenix-live-preview/main.js

@@ -162,12 +162,17 @@ define(function (require, exports, module) {
     let connectingOverlayTimer = null; // this is needed as we show the connecting overlay after 3s
     let connectingOverlayTimeDuration = 3000;
 
+    function _getLiveEditEntitlement() {
+        // in community edition, this may not be present;
+        return KernalModeTrust.EntitlementsManager && KernalModeTrust.EntitlementsManager.getLiveEditEntitlement();
+    }
+
     let isProEditUser = false;
     // this is called everytime there is a change in entitlements
     async function _entitlementsChanged() {
         try {
-            const entitlement = await KernalModeTrust.EntitlementsManager.getLiveEditEntitlement();
-            isProEditUser = entitlement.activated;
+            const entitlement = await _getLiveEditEntitlement();
+            isProEditUser = entitlement && entitlement.activated;
         } catch (error) {
             console.error("Error updating pro user status:", error);
             isProEditUser = false;
@@ -1317,7 +1322,8 @@ define(function (require, exports, module) {
         _projectOpened();
         if(!Phoenix.isSpecRunnerWindow){
             _entitlementsChanged();
-            KernalModeTrust.EntitlementsManager.on(
+            // in community edition EntitlementsManager may be null
+            KernalModeTrust.EntitlementsManager && KernalModeTrust.EntitlementsManager.on(
                 KernalModeTrust.EntitlementsManager.EVENT_ENTITLEMENTS_CHANGED,
                 _entitlementsChanged
             );

src/extensionsIntegrated/Phoenix/guided-tour.js

@@ -235,13 +235,23 @@ define(function (require, exports, module) {
         PhStore.setItem(GUIDED_TOUR_LOCAL_STORAGE_KEY, JSON.stringify(userAlreadyDidAction));
     }
 
+    function _isLoggedIn() {
+        // in community edition entitlements for pro is null
+        return KernalModeTrust.EntitlementsManager && KernalModeTrust.EntitlementsManager.isLoggedIn();
+    }
+
+    function _isPaidSubscriber() {
+        // in community edition entitlements for pro is null
+        return KernalModeTrust.EntitlementsManager && KernalModeTrust.EntitlementsManager.isPaidSubscriber();
+    }
+
     async function _resolvePowerUserSurveyURL(surveyJson) {
         try {
-            const isLoggedIn = KernalModeTrust.EntitlementsManager.isLoggedIn();
+            const isLoggedIn = _isLoggedIn();
             if(!isLoggedIn) {
                 return surveyJson.powerUser;
             }
-            const paidSubscriber = await KernalModeTrust.EntitlementsManager.isPaidSubscriber();
+            const paidSubscriber = await _isPaidSubscriber();
             if(paidSubscriber && surveyJson.powerUserPaid) {
                 return surveyJson.powerUserPaid;
             }

src/utils/Metrics.js

@@ -268,15 +268,15 @@ define(function (require, exports, module) {
 
     async function _setPowerUserPrefix() {
         powerUserPrefix = null;
-        const EntitlementsManager = KernalModeTrust.EntitlementsManager;
+        const EntitlementsManager = KernalModeTrust.EntitlementsManager; // can be null in free builds
         if(cachedIsPowerUser){
             // A power user is someone who used Phoenix at least 3 days/8 hours in the last two weeks
             powerUserPrefix = "P";
         } else if(!isFirstUseDay){
             // A repeat user is a user who has used phoenix at least one other day before
             powerUserPrefix = "R";
         }
-        if(EntitlementsManager.isLoggedIn()){
+        if(EntitlementsManager && EntitlementsManager.isLoggedIn()){
             if(await EntitlementsManager.isPaidSubscriber()){
                 powerUserPrefix = "S"; // subscriber
                 return;
@@ -306,8 +306,8 @@ define(function (require, exports, module) {
                 _setPowerUserPrefix();
             }, ONE_DAY);
         }
-        KernalModeTrust.EntitlementsManager.on(KernalModeTrust.EntitlementsManager.EVENT_ENTITLEMENTS_CHANGED,
-            _setPowerUserPrefix);
+        KernalModeTrust.EntitlementsManager && KernalModeTrust.EntitlementsManager.on(
+            KernalModeTrust.EntitlementsManager.EVENT_ENTITLEMENTS_CHANGED, _setPowerUserPrefix);
     }
 
     // some events generate too many ga events that ga can't handle. ignore them.