Skip to content

Commit 805aa90

Browse files
committed
chore: metrics for git next, prev change and history
1 parent 8f3797d commit 805aa90

File tree

3 files changed

+21
-3
lines changed

3 files changed

+21
-3
lines changed

src/extensions/default/Git/src/History.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ define(function (require) {
66
FileUtils = brackets.getModule("file/FileUtils"),
77
LocalizationUtils = brackets.getModule("utils/LocalizationUtils"),
88
Strings = brackets.getModule("strings"),
9+
Metrics = brackets.getModule("utils/Metrics"),
910
Mustache = brackets.getModule("thirdparty/mustache/mustache");
1011

1112
// Local modules
@@ -315,9 +316,11 @@ define(function (require) {
315316
});
316317
EventEmitter.on(Events.HISTORY_SHOW_FILE, function () {
317318
handleToggleHistory("FILE");
319+
Metrics.countEvent(Metrics.EVENT_TYPE.GIT, 'panel', "fileHistory");
318320
});
319321
EventEmitter.on(Events.HISTORY_SHOW_GLOBAL, function () {
320322
handleToggleHistory("GLOBAL");
323+
Metrics.countEvent(Metrics.EVENT_TYPE.GIT, 'panel', "history");
321324
});
322325
EventEmitter.on(Events.REFRESH_HISTORY, function () {
323326
handleToggleHistory("REFRESH");

src/extensions/default/Git/src/HistoryViewer.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ define(function (require, exports) {
55
Mustache = brackets.getModule("thirdparty/mustache/mustache"),
66
WorkspaceManager = brackets.getModule("view/WorkspaceManager"),
77
Strings = brackets.getModule("strings"),
8+
Metrics = brackets.getModule("utils/Metrics"),
89
marked = brackets.getModule('thirdparty/marked.min').marked;
910

1011
const ErrorHandler = require("src/ErrorHandler"),
@@ -232,6 +233,7 @@ define(function (require, exports) {
232233
}
233234

234235
function show(commitInfo, doc, options) {
236+
Metrics.countEvent(Metrics.EVENT_TYPE.GIT, 'history', "detailView");
235237
initialize();
236238

237239
commit = commitInfo;

src/extensions/default/Git/src/Panel.js

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -453,8 +453,15 @@ define(function (require, exports) {
453453
dialog = Dialogs.showModalDialogUsingTemplate(compiledTemplate),
454454
$dialog = dialog.getElement();
455455
_makeDialogBig($dialog);
456-
$dialog.find(".commit-diff").append(Utils.formatDiff(diff));
456+
const diffVal = Utils.formatDiff(diff);
457+
if(diffVal === Utils.FORMAT_DIFF_TOO_LARGE) {
458+
Metrics.countEvent(Metrics.EVENT_TYPE.GIT, 'diffBtn', "diffTooLarge");
459+
} else {
460+
Metrics.countEvent(Metrics.EVENT_TYPE.GIT, 'diffBtn', "success");
461+
}
462+
$dialog.find(".commit-diff").append(Utils.formatDiff(diffVal));
457463
}).catch(function (err) {
464+
Metrics.countEvent(Metrics.EVENT_TYPE.GIT, 'diffBtn', "error");
458465
ErrorHandler.showError(err, Strings.ERROR_GIT_DIFF_FAILED);
459466
});
460467
}
@@ -1237,8 +1244,14 @@ define(function (require, exports) {
12371244
.on("click", ".git-commit-merge", commitMerge)
12381245
.on("click", ".git-merge-abort", abortMerge)
12391246
.on("click", ".git-find-conflicts", findConflicts)
1240-
.on("click", ".git-prev-gutter", GutterManager.goToPrev)
1241-
.on("click", ".git-next-gutter", GutterManager.goToNext)
1247+
.on("click", ".git-prev-gutter", ()=>{
1248+
Metrics.countEvent(Metrics.EVENT_TYPE.GIT, 'panel', "prevBtn");
1249+
GutterManager.goToPrev();
1250+
})
1251+
.on("click", ".git-next-gutter", ()=>{
1252+
Metrics.countEvent(Metrics.EVENT_TYPE.GIT, 'panel', "nextBtn");
1253+
GutterManager.goToNext();
1254+
})
12421255
.on("click", ".git-file-history", EventEmitter.getEmitter(Events.HISTORY_SHOW_FILE))
12431256
.on("click", ".git-history-toggle", EventEmitter.getEmitter(Events.HISTORY_SHOW_GLOBAL))
12441257
.on("click", ".git-fetch", EventEmitter.getEmitter(Events.HANDLE_FETCH))

0 commit comments

Comments
 (0)