refactor: login popup strings

Author: abose

src/nls/root/strings.js

@@ -1580,5 +1580,8 @@ define({
     "VALIDATION_CODE_MESSAGE": "Please use this Verification code to sign in to your {APP_NAME} account:",
     "COPY_VALIDATION_CODE": "Copy Code",
     "VALIDATION_CODE_COPIED": "Copied",
-    "OPEN_SIGN_IN_URL": "Open Sign In Page"
+    "OPEN_SIGN_IN_URL": "Open Sign In Page",
+    "PROFILE_POP_TITLE": "{APP_NAME} Account",
+    "PROFILE_SIGN_IN": "Sign in to your account",
+    "CONTACT_SUPPORT": "Contact support"
 });

src/services/html/login-popup.html

@@ -1,16 +1,16 @@
 <div class="profile-popup">
     <div class="popup-header">
-        <h1 class="popup-title">{{welcomeTitle}}</h1>
+        <h1 class="popup-title">{{Strings.PROFILE_POP_TITLE}}</h1>
     </div>
     <div class="popup-body">
         <button id="phoenix-signin-btn" class="btn dialog-button primary">
             <i class="fa fa-sign-in-alt"></i>
-            {{signInBtnText}}
+            {{Strings.PROFILE_SIGN_IN}}
         </button>
         <div class="support-link">
             <button id="phoenix-support-btn" class="text-link">
                 <i class="fa fa-question-circle"></i>
-                {{supportBtnText}}
+                {{Strings.CONTACT_SUPPORT}}
             </button>
         </div>
     </div>

src/services/profile-menu.js

@@ -153,23 +153,19 @@ define(function (require, exports, module) {
 
     /**
      * Shows the sign-in popup when the user is not logged in
-     * @param {Object} loginData - Data to populate the template (optional)
      */
-    function showLoginPopup(loginData) {
+    function showLoginPopup() {
         // If popup is already visible, just close it
         if (isPopupVisible) {
             closePopup();
             return;
         }
 
-        // Merge provided data with defaults
-        const templateData = $.extend({}, defaultLoginData, loginData || {});
-
         // create the popup element
         closePopup(); // close any existing popup first
 
         // Render template with data
-        const renderedTemplate = Mustache.render(loginTemplate, templateData);
+        const renderedTemplate = Mustache.render(loginTemplate, {Strings});
         $popup = $(renderedTemplate);
 
         $("body").append($popup);
@@ -272,7 +268,7 @@ define(function (require, exports, module) {
         if (KernalModeTrust.loginService.isLoggedIn()) {
             showProfilePopup(data);
         } else {
-            showLoginPopup(data);
+            showLoginPopup();
         }
     }
 

src/styles/Extn-UserProfile.less src/styles/UserProfile.lesssrc/styles/Extn-UserProfile.less renamed to src/styles/UserProfile.less

@@ -44,7 +44,7 @@
 @import "Extn-TabBar.less";
 @import "Extn-DisplayShortcuts.less";
 @import "Extn-CSSColorPreview.less";
-@import "Extn-UserProfile.less";
+@import "UserProfile.less";
 
 /* Overall layout */