fix: git panel not getting updated when phoenix gains focus

Author: devvaannsh

src/extensions/default/Git/src/Main.js

@@ -399,32 +399,29 @@ define(function (require, exports) {
         }
     }
 
-    let lastExecutionTime = 0;
     let isCommandExecuting = false;
-    const FOCUS_SWITCH_DEDUPE_TIME = 5000;
     function refreshOnFocusChange() {
         // to sync external git changes after switching to app.
         if (gitEnabled) {
-            const now = Date.now();
+            const isGitPanelVisible = Panel.getPanel().is(":visible");
 
             if (isCommandExecuting) {
                 return;
             }
-
-            if (now - lastExecutionTime > FOCUS_SWITCH_DEDUPE_TIME) {
-                isCommandExecuting = true;
-                lastExecutionTime = Date.now();
-                Git.hasStatusChanged().then((hasChanged) => {
-                    if(!hasChanged){
-                        return;
-                    }
-
-                    CommandManager.execute(Constants.CMD_GIT_REFRESH).fail((err) => {
-                        console.error("error refreshing on focus switch", err);
-                    });
-                }).finally(()=>{
+            isCommandExecuting = true;
+
+            // if the git panel is visible, its very likely user is working with git (maybe external)
+            // so when Phoenix gains focus, we do a complete git refresh to show latest status
+            if(isGitPanelVisible) {
+                CommandManager.execute(Constants.CMD_GIT_REFRESH).fail((err) => {
+                    console.error("error refreshing on focus switch", err);
+                }).always(() => {
                     isCommandExecuting = false;
                 });
+            } else {
+                // if panel not visible, we just refresh the git branch (shown in sidebar)
+                Branch.refresh();
+                isCommandExecuting = false;
             }
         }
     }

src/extensions/default/Git/src/git/GitCli.js

@@ -797,6 +797,8 @@ define(function (require, exports) {
         });
     }
 
+    // this function right now is not being used anywhere,
+    // but leaving it here (we might need it in the future)
     function hasStatusChanged() {
         const prevStatus = lastGitStatusResults;
         return status().then(function (currentStatus) {