feat: way to not load first party deprecated extensions

Author: abose

src/extensibility/ExtensionManagerViewModel.js

@@ -26,11 +26,13 @@ define(function (require, exports, module) {
 
     var _ = require("thirdparty/lodash");
 
-    var ExtensionManager    = require("extensibility/ExtensionManager"),
-        registry_utils      = require("extensibility/registry_utils"),
-        EventDispatcher     = require("utils/EventDispatcher"),
-        Strings             = require("strings"),
-        PreferencesManager  = require("preferences/PreferencesManager");
+    const ExtensionManager    = require("extensibility/ExtensionManager"),
+        registry_utils        = require("extensibility/registry_utils"),
+        EventDispatcher        = require("utils/EventDispatcher"),
+        Strings                = require("strings"),
+        PreferencesManager     = require("preferences/PreferencesManager"),
+        DefaultExtensions      = JSON.parse(require("text!extensions/default/DefaultExtensions.json")),
+        dontLoadExtensionIDs   = new Set(DefaultExtensions.dontLoadExtensions.extensionIDs);
 
     /**
      * @private
@@ -307,6 +309,9 @@ define(function (require, exports, module) {
                 return entry.registryInfo && entry.registryInfo.metadata.theme;
 
             })
+            .filter(function (entry) {
+                return !dontLoadExtensionIDs.has(entry.registryInfo.metadata.name);
+            })
             .map(function (entry) {
                 return entry.registryInfo.metadata.name;
             });
@@ -555,6 +560,9 @@ define(function (require, exports, module) {
             .filter(function (key) {
                 return self.extensions[key].installInfo &&
                     self.extensions[key].installInfo.locationType === ExtensionManager.LOCATION_DEFAULT;
+            })
+            .filter(function (key) {
+                return !dontLoadExtensionIDs.has(key);
             });
         this._sortFullSet();
         this._setInitialFilter();

src/utils/ExtensionLoader.js

@@ -57,6 +57,7 @@ define(function (require, exports, module) {
         DefaultExtensions = JSON.parse(require("text!extensions/default/DefaultExtensions.json"));
 
     const desktopOnlyExtensions = DefaultExtensions.desktopOnly;
+    const dontLoadExtensionIDs = new Set(DefaultExtensions.dontLoadExtensions.extensionIDs);
     const DefaultExtensionsList = Phoenix.isNativeApp ?
         [...DefaultExtensions.defaultExtensionsList, ...desktopOnlyExtensions]:
         DefaultExtensions.defaultExtensionsList;
@@ -420,6 +421,11 @@ define(function (require, exports, module) {
                 if (metadata && metadata.theme) {
                     return;
                 }
+                if (dontLoadExtensionIDs.has(metadata.name)) {
+                    logger.leaveTrail("skipping extension in dontLoadExtensions list: " + metadata.name);
+                    console.warn("skipping extension in dontLoadExtensions list: " + metadata.name);
+                    return new $.Deferred().reject("disabled").promise();
+                }
 
                 if (!metadata.disabled) {
                     return loadExtensionModule(name, config, entryPoint, metadata);