refactor: login desktop and browser tests common code

Author: abose

test/spec/login-browser-integ-test.js

@@ -23,6 +23,7 @@
 define(function (require, exports, module) {
 
     const SpecRunnerUtils = require("spec/SpecRunnerUtils");
+    const LoginShared = require("./login-shared");
 
     describe("integration: login/logout browser app tests", function () {
 
@@ -39,7 +40,9 @@ define(function (require, exports, module) {
             LoginBrowserExports,
             ProDialogsExports,
             originalOpen,
-            originalFetch;
+            originalFetch,
+            SharedUtils,
+            setupTrialState;
 
         beforeAll(async function () {
             testWindow = await SpecRunnerUtils.createTestWindowAndRun();
@@ -72,6 +75,8 @@ define(function (require, exports, module) {
                 "Profile button to be available",
                 3000
             );
+            SharedUtils = LoginShared.getSharedUtils(testWindow);
+            setupTrialState = SharedUtils.setupTrialState;
         }, 30000);
 
         afterAll(async function () {
@@ -97,19 +102,6 @@ define(function (require, exports, module) {
             // Note: We can't easily reset login state, so tests should handle this
         });
 
-        // Helper functions for promotion testing (browser-specific)
-        async function setupTrialState(daysRemaining) {
-            const PromotionExports = testWindow._test_promo_login_exports;
-            const mockNow = Date.now();
-            await PromotionExports._setTrialData({
-                proVersion: "3.1.0",
-                endDate: mockNow + (daysRemaining * PromotionExports.TRIAL_CONSTANTS.MS_PER_DAY)
-            });
-            // Trigger entitlements changed event to update branding
-            const LoginService = PromotionExports.LoginService;
-            LoginService.trigger(LoginService.EVENT_ENTITLEMENTS_CHANGED);
-        }
-
         async function setupExpiredTrial() {
             const PromotionExports = testWindow._test_promo_login_exports;
             const mockNow = Date.now();

test/spec/login-desktop-integ-test.js

@@ -23,6 +23,7 @@
 define(function (require, exports, module) {
 
     const SpecRunnerUtils = require("spec/SpecRunnerUtils");
+    const LoginShared = require("./login-shared");
 
     describe("integration: login/logout desktop app tests", function () {
 
@@ -47,7 +48,9 @@ define(function (require, exports, module) {
             ProDialogsExports,
             originalOpenURLInDefaultBrowser,
             originalCopyToClipboard,
-            originalFetch;
+            originalFetch,
+            SharedUtils,
+            setupTrialState;
 
         beforeAll(async function () {
             testWindow = await SpecRunnerUtils.createTestWindowAndRun();
@@ -80,6 +83,8 @@ define(function (require, exports, module) {
                 "Profile button to be available",
                 3000
             );
+            SharedUtils = LoginShared.getSharedUtils(testWindow);
+            setupTrialState = SharedUtils.setupTrialState;
         }, 30000);
 
         afterAll(async function () {
@@ -107,19 +112,6 @@ define(function (require, exports, module) {
             // Note: We can't easily reset login state, so tests should handle this
         });
 
-        // Helper functions for desktop login testing
-        async function setupTrialState(daysRemaining) {
-            const PromotionExports = testWindow._test_promo_login_exports;
-            const mockNow = Date.now();
-            await PromotionExports._setTrialData({
-                proVersion: "3.1.0",
-                endDate: mockNow + (daysRemaining * PromotionExports.TRIAL_CONSTANTS.MS_PER_DAY)
-            });
-            // Trigger entitlements changed event to update branding
-            const LoginService = PromotionExports.LoginService;
-            LoginService.trigger(LoginService.EVENT_ENTITLEMENTS_CHANGED);
-        }
-
         async function setupExpiredTrial() {
             const PromotionExports = testWindow._test_promo_login_exports;
             const mockNow = Date.now();

test/spec/login-shared.js

@@ -0,0 +1,22 @@
+define(function (require, exports, module) {
+
+    function getSharedUtils(testWindow) {
+        // Helper functions for promotion testing (browser-specific)
+        async function setupTrialState(daysRemaining) {
+            const PromotionExports = testWindow._test_promo_login_exports;
+            const mockNow = Date.now();
+            await PromotionExports._setTrialData({
+                proVersion: "3.1.0",
+                endDate: mockNow + (daysRemaining * PromotionExports.TRIAL_CONSTANTS.MS_PER_DAY)
+            });
+            // Trigger entitlements changed event to update branding
+            const LoginService = PromotionExports.LoginService;
+            LoginService.trigger(LoginService.EVENT_ENTITLEMENTS_CHANGED);
+        }
+        return {
+            setupTrialState
+        };
+    }
+
+    exports.getSharedUtils = getSharedUtils;
+});