refactor: remove remote styles config passing as it can be passed directly in code

Author: abose

src/LiveDevelopment/BrowserScripts/RemoteFunctions.js

@@ -106,6 +106,24 @@ function RemoteFunctions(config = {}) {
      */
     var _editHandler;
 
+    let remoteHighlight = {
+        animateStartValue: {
+            "background-color": "rgba(0, 162, 255, 0.5)",
+            "opacity": 0
+        },
+        animateEndValue: {
+            "background-color": "rgba(0, 162, 255, 0)",
+            "opacity": 0.6
+        },
+        paddingStyling: {
+            "background-color": "rgba(200, 249, 197, 0.7)"
+        },
+        marginStyling: {
+            "background-color": "rgba(249, 204, 157, 0.7)"
+        },
+        borderColor: "rgba(200, 249, 197, 0.85)",
+        showPaddingMargin: true
+    };
     let strings = {}, icons = {}, cssStyles = {}; // these will be injected below
     // the below code comment is replaced by added scripts for extensibility
     // DONT_STRIP_MINIFY:REPLACE_WITH_ADDED_REMOTE_CONSTANT_SCRIPTS
@@ -3816,7 +3834,7 @@ function RemoteFunctions(config = {}) {
 
             var setVisibility = function (el) {
                 if (
-                    !config.remoteHighlight.showPaddingMargin ||
+                    !remoteHighlight.showPaddingMargin ||
                     parseInt(el.height, 10) <= 0 ||
                     parseInt(el.width, 10) <= 0
                 ) {
@@ -3826,8 +3844,6 @@ function RemoteFunctions(config = {}) {
                 }
             };
 
-            var mainBoxStyles = config.remoteHighlight.stylesToSet;
-
             var paddingVisualisations = [
               drawPaddingRect('top'),
               drawPaddingRect('right'),
@@ -3864,11 +3880,11 @@ function RemoteFunctions(config = {}) {
 
             setupVisualisations(
                 marginVisualisations,
-                config.remoteHighlight.marginStyling
+                remoteHighlight.marginStyling
             );
             setupVisualisations(
                 paddingVisualisations,
-                config.remoteHighlight.paddingStyling
+                remoteHighlight.paddingStyling
             );
 
             highlight.className = GLOBALS.HIGHLIGHT_CLASSNAME;
@@ -3898,14 +3914,14 @@ function RemoteFunctions(config = {}) {
                 "border-left": elementStyling.getPropertyValue('border-left'),
                 "border-top": elementStyling.getPropertyValue('border-top'),
                 "border-bottom": elementStyling.getPropertyValue('border-bottom'),
-                "border-color": config.remoteHighlight.borderColor
+                "border-color": remoteHighlight.borderColor
             };
 
-            var mergedStyles = Object.assign({}, stylesToSet,  config.remoteHighlight.stylesToSet);
+            var mergedStyles = Object.assign({}, stylesToSet,  remoteHighlight.stylesToSet);
 
-            var animateStartValues = config.remoteHighlight.animateStartValue;
+            var animateStartValues = remoteHighlight.animateStartValue;
 
-            var animateEndValues = config.remoteHighlight.animateEndValue;
+            var animateEndValues = remoteHighlight.animateEndValue;
 
             var transitionValues = {
                 "transition-property": "opacity, background-color, transform",

src/LiveDevelopment/main.js

@@ -100,31 +100,6 @@ define(function main(require, exports, module) {
 
     var _$btnGoLive; // reference to the GoLive button
 
-    var prefs = PreferencesManager.getExtensionPrefs("livedev");
-
-    // "livedev.remoteHighlight" preference
-    var PREF_REMOTEHIGHLIGHT = "remoteHighlight"; // todo remove this and put it inside remotefn itself
-    var remoteHighlightPref = prefs.definePreference(PREF_REMOTEHIGHLIGHT, "object", {
-        animateStartValue: {
-            "background-color": "rgba(0, 162, 255, 0.5)",
-            "opacity": 0
-        },
-        animateEndValue: {
-            "background-color": "rgba(0, 162, 255, 0)",
-            "opacity": 0.6
-        },
-        "paddingStyling": {
-            "background-color": "rgba(200, 249, 197, 0.7)"
-        },
-        "marginStyling": {
-            "background-color": "rgba(249, 204, 157, 0.7)"
-        },
-        "borderColor": "rgba(200, 249, 197, 0.85)",
-        "showPaddingMargin": true
-    }, {
-        description: Strings.DESCRIPTION_LIVE_DEV_HIGHLIGHT_SETTINGS
-    });
-
     /** Load Live Development LESS Style */
     function _loadStyles() {
         var lessText = require("text!LiveDevelopment/main.less");
@@ -331,7 +306,6 @@ define(function main(require, exports, module) {
     /** Initialize LiveDevelopment */
     AppInit.appReady(function () {
         params.parse();
-        config.remoteHighlight = prefs.get(PREF_REMOTEHIGHLIGHT);
         config.mode = getCurrentMode(); // update config.mode with current preference value
 
         // init experimental multi-browser implementation
@@ -366,14 +340,6 @@ define(function main(require, exports, module) {
         _setupGoLiveButton();
         _setupGoLiveMenu();
 
-        remoteHighlightPref
-            .on("change", function () {
-                config.remoteHighlight = prefs.get(PREF_REMOTEHIGHLIGHT);
-                if (MultiBrowserLiveDev && MultiBrowserLiveDev.status >= MultiBrowserLiveDev.STATUS_ACTIVE) {
-                    MultiBrowserLiveDev.updateConfig(JSON.stringify(config));
-                }
-            });
-
         MultiBrowserLiveDev.on(MultiBrowserLiveDev.EVENT_OPEN_PREVIEW_URL, function (event, previewDetails) {
             exports.trigger(exports.EVENT_OPEN_PREVIEW_URL, previewDetails);
         });

src/nls/root/strings.js

@@ -1141,7 +1141,6 @@ define({
     "DESCRIPTION_INDENT_LINE_COMMENT": "true to enable indenting of line comments",
     "DESCRIPTION_RECENT_FILES_NAV": "Enable/disable navigation in recent files",
     "DESCRIPTION_LIVEDEV_WEBSOCKET_PORT": "Port on which WebSocket Server runs for Live Preview",
-    "DESCRIPTION_LIVE_DEV_HIGHLIGHT_SETTINGS": "Live Preview Highlight settings",
     "DESCRIPTION_LIVEDEV_ENABLE_REVERSE_INSPECT": "false to disable live preview reverse inspect",
     "DESCRIPTION_LIVEDEV_NO_PREVIEW": "Nothing to preview!",
     "DESCRIPTION_LIVEDEV_EXCLUDED": "Custom Server Cannot Serve This file",