feat: drag and drop experimental menu in linux

Author: abose

src/extensions/default/DebugCommands/main.js

@@ -35,7 +35,7 @@ define(function (require, exports, module) {
         PerfUtils              = brackets.getModule("utils/PerfUtils"),
         StringUtils            = brackets.getModule("utils/StringUtils"),
         Dialogs                = brackets.getModule("widgets/Dialogs"),
-        DefaultDialogs         = brackets.getModule("widgets/DefaultDialogs"),
+        DragAndDrop            = brackets.getModule("utils/DragAndDrop"),
         Strings                = brackets.getModule("strings"),
         PreferencesManager     = brackets.getModule("preferences/PreferencesManager"),
         LocalizationUtils      = brackets.getModule("utils/LocalizationUtils"),
@@ -53,7 +53,8 @@ define(function (require, exports, module) {
 
     const KeyboardPrefs = JSON.parse(require("text!keyboard.json"));
 
-    const DIAGNOSTICS_SUBMENU = "debug-diagnostics-sub-menu";
+    const DIAGNOSTICS_SUBMENU = "debug-diagnostics-sub-menu",
+        EXPERIMENTAL_FEATURES_SUB_MENU = "debug-experimental-features";
 
     // default preferences file name
     const DEFAULT_PREFERENCES_FILENAME = "defaultPreferences.json",
@@ -81,7 +82,8 @@ define(function (require, exports, module) {
         DEBUG_OPEN_VFS                        = "debug.openVFS",
         DEBUG_OPEN_EXTENSION_FOLDER           = "debug.openExtensionFolders",
         DEBUG_OPEN_VIRTUAL_SERVER             = "debug.openVirtualServer",
-        DEBUG_OPEN_PREFERENCES_IN_SPLIT_VIEW  = "debug.openPrefsInSplitView";
+        DEBUG_OPEN_PREFERENCES_IN_SPLIT_VIEW  = "debug.openPrefsInSplitView",
+        DEBUG_DRAG_AND_DROP                   = "debug.dragAndDrop";
 
     const LOG_TO_CONSOLE_KEY = logger.loggingOptions.LOCAL_STORAGE_KEYS.LOG_TO_CONSOLE_KEY,
         LOG_LIVE_PREVIEW_KEY = logger.loggingOptions.LOCAL_STORAGE_KEYS.LOG_LIVE_PREVIEW;
@@ -824,6 +826,19 @@ define(function (require, exports, module) {
         hideWhenCommandDisabled: true
     });
 
+    if(Phoenix.isNativeApp && Phoenix.platform === "linux") {
+        // there is only one experimental feature- drag and drop available in native linux apps only.
+        const experimentalSubmenu = debugMenu.addSubMenu(Strings.CMD_EXPERIMENTAL_FEATURES, EXPERIMENTAL_FEATURES_SUB_MENU);
+        CommandManager.register(Strings.CMD_ENABLE_DRAG_AND_DROP, DEBUG_DRAG_AND_DROP, ()=>{
+            PreferencesManager.set(DragAndDrop._PREF_DRAG_AND_DROP,
+                !PreferencesManager.get(DragAndDrop._PREF_DRAG_AND_DROP));
+        });
+        PreferencesManager.on("change", DragAndDrop._PREF_DRAG_AND_DROP, function () {
+            CommandManager.get(DEBUG_DRAG_AND_DROP).setChecked(PreferencesManager.get(DragAndDrop._PREF_DRAG_AND_DROP));
+        });
+        experimentalSubmenu.addMenuItem(DEBUG_DRAG_AND_DROP);
+    }
+
     CommandManager.get(DEBUG_UNLOAD_CURRENT_EXTENSION)
         .setEnabled(extensionDevelopment.isProjectLoadedAsExtension());
     CommandManager.get(DEBUG_OPEN_EXTENSION_FOLDER)

src/nls/root/strings.js

@@ -579,6 +579,8 @@ define({
     // Debug menu commands
     "CMD_OPEN_VFS": "Open Virtual File System",
     "CMD_DIAGNOSTIC_TOOLS": "{APP_NAME} Diagnostic Tools",
+    "CMD_EXPERIMENTAL_FEATURES": "Experimental Features",
+    "CMD_ENABLE_DRAG_AND_DROP": "Drag And Drop Files",
     "CMD_OPEN_EXTENSIONS_FOLDER": "Open Extensions Folder\u2026",
     "CMD_OPEN_VIRTUAL_SERVER": "Open Virtual Server",
 
@@ -1001,6 +1003,7 @@ define({
     "DESCRIPTION_RULERS_COLUMNS": "An array of column numbers to draw vertical rulers in the editor. Eg: [80, 100]",
     "DESCRIPTION_RULERS_COLORS": "An array of ruler colors corresponding to the rulers option in the editor. Eg: [\"#3d3d3d\", \"red\"]",
     "DESCRIPTION_RULERS_ENABLED": "true to enable editor rulers, else false",
+    "DESCRIPTION_DRAG_AND_DROP_ENABLED": "true to enable drag and drop functionality for files and folders from the file explorer or Finder",
     "DESCRIPTION_SMART_INDENT": "Automatically indent when creating a new block",
     "DESCRIPTION_SOFT_TABS": "false to turn off soft tabs behavior",
     "DESCRIPTION_SORT_DIRECTORIES_FIRST": "true to sort the directories first in the project tree",

src/utils/DragAndDrop.js

@@ -29,11 +29,17 @@ define(function (require, exports, module) {
         DefaultDialogs  = require("widgets/DefaultDialogs"),
         MainViewManager = require("view/MainViewManager"),
         FileSystem      = require("filesystem/FileSystem"),
+        PreferencesManager  = require("preferences/PreferencesManager"),
         FileUtils       = require("file/FileUtils"),
         ProjectManager  = require("project/ProjectManager"),
         Strings         = require("strings"),
         StringUtils     = require("utils/StringUtils");
 
+    const _PREF_DRAG_AND_DROP = "dragAndDrop"; // used in debug menu
+    PreferencesManager.definePreference(_PREF_DRAG_AND_DROP, "boolean",
+        Phoenix.isNativeApp && Phoenix.platform !== "linux", {description: Strings.DESCRIPTION_DRAG_AND_DROP_ENABLED}
+    );
+
     /**
      * Returns true if the drag and drop items contains valid drop objects.
      * @param {Array.<DataTransferItem>} items Array of items being dragged
@@ -265,7 +271,7 @@ define(function (require, exports, module) {
             var files = event.dataTransfer.files;
 
             stopURIListPropagation(files, event);
-            if(Phoenix.isNativeApp && Phoenix.platform !== "linux" &&
+            if(PreferencesManager.get(_PREF_DRAG_AND_DROP) &&
                 event.dataTransfer.types && event.dataTransfer.types.includes("Files")){
                 // in linux, there is a bug in ubuntu 24 where dropping a file will cause a ghost icon which only
                 // goes away on reboot. So we dont support drop files in linux for now.
@@ -333,4 +339,7 @@ define(function (require, exports, module) {
     exports.attachHandlers      = attachHandlers;
     exports.isValidDrop         = isValidDrop;
     exports.openDroppedFiles    = openDroppedFiles;
+
+    // private exports
+    exports._PREF_DRAG_AND_DROP = _PREF_DRAG_AND_DROP;
 });