Skip to content

Commit a9db70d

Browse files
committed
fix: drag operating affecting styles permanently for some elements
1 parent e63a372 commit a9db70d

File tree

1 file changed

+21
-3
lines changed

1 file changed

+21
-3
lines changed

src/LiveDevelopment/BrowserScripts/RemoteFunctions.js

Lines changed: 21 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -847,9 +847,19 @@ function RemoteFunctions(config = {}) {
847847
let elements = window.document.querySelectorAll("[data-brackets-id]");
848848
for (let j = 0; j < elements.length; j++) {
849849
delete elements[j]._dropMarker;
850-
// Remove any hover effects
851-
elements[j].style.backgroundColor = "";
852-
elements[j].style.transform = "";
850+
// only restore the styles that were modified by drag operations
851+
if (elements[j]._originalDragBackgroundColor !== undefined) {
852+
elements[j].style.backgroundColor = elements[j]._originalDragBackgroundColor;
853+
delete elements[j]._originalDragBackgroundColor;
854+
}
855+
if (elements[j]._originalDragTransform !== undefined) {
856+
elements[j].style.transform = elements[j]._originalDragTransform;
857+
delete elements[j]._originalDragTransform;
858+
}
859+
if (elements[j]._originalDragTransition !== undefined) {
860+
elements[j].style.transition = elements[j]._originalDragTransition;
861+
delete elements[j]._originalDragTransition;
862+
}
853863
}
854864
}
855865

@@ -887,6 +897,14 @@ function RemoteFunctions(config = {}) {
887897
return;
888898
}
889899

900+
// Store original styles before modifying them
901+
if (target._originalDragBackgroundColor === undefined) {
902+
target._originalDragBackgroundColor = target.style.backgroundColor;
903+
}
904+
if (target._originalDragTransition === undefined) {
905+
target._originalDragTransition = target.style.transition;
906+
}
907+
890908
// Add subtle hover effect to target element
891909
target.style.backgroundColor = "rgba(66, 133, 244, 0.1)";
892910
target.style.transition = "background-color 0.2s ease";

0 commit comments

Comments
 (0)