refactor: live preview setting server type unknown to custom

Author: abose

src/extensionsIntegrated/Phoenix-live-preview/LivePreviewSettings.js

@@ -53,7 +53,7 @@ define(function (require, exports, module) {
 
     EventDispatcher.makeEventDispatcher(exports);
 
-    const FRAMEWORK_UNKNOWN = "unknown",
+    const FRAMEWORK_CUSTOM = "Custom",
         FRAMEWORK_DOCUSAURUS = "Docusaurus";
 
     const EVENT_SERVER_CHANGED = "customServerChanged";
@@ -99,7 +99,7 @@ define(function (require, exports, module) {
                 return;
             }
         }
-        $frameworkSelect.val(FRAMEWORK_UNKNOWN);
+        $frameworkSelect.val(FRAMEWORK_CUSTOM);
         $hotReloadChk.prop('checked', false);
     }
 
@@ -108,9 +108,7 @@ define(function (require, exports, module) {
         PreferencesManager.set(PREFERENCE_PROJECT_SERVER_URL, liveServerURL, PreferencesManager.PROJECT_SCOPE);
         PreferencesManager.set(PREFERENCE_PROJECT_SERVER_PATH, serveRoot, PreferencesManager.PROJECT_SCOPE);
         PreferencesManager.set(PREFERENCE_PROJECT_SERVER_HOT_RELOAD_SUPPORTED, hotReloadSupported, PreferencesManager.PROJECT_SCOPE);
-        if(framework !== FRAMEWORK_UNKNOWN) {
-            PreferencesManager.set(PREFERENCE_PROJECT_PREVIEW_FRAMEWORK, framework, PreferencesManager.PROJECT_SCOPE);
-        }
+        PreferencesManager.set(PREFERENCE_PROJECT_PREVIEW_FRAMEWORK, framework, PreferencesManager.PROJECT_SCOPE);
     }
 
     function showSettingsDialog() {

src/extensionsIntegrated/Phoenix-live-preview/livePreviewSettings.html

@@ -18,7 +18,7 @@ <h1 class="dialog-title">{{Strings.LIVE_DEV_SETTINGS_TITLE}}</h1>
                        value="{{settings.fontSize}}" placeholder="{{Strings.LIVE_DEV_SETTINGS_SERVER_ROOT_HELP}}">
                 <label id="frameworkLabel" class="forced-hidden" style="margin-left: 20px;">{{Strings.LIVE_DEV_SETTINGS_FRAMEWORK}}</label>
                 <select id="frameworkSelect" class="forced-hidden" style="width: 20%; margin-left: 20px;">
-                    <option style="text-align:left;" value="unknown">{{Strings.LIVE_DEV_SETTINGS_FRAMEWORK_UNKNOWN}}</option>
+                    <option style="text-align:left;" value="Custom">{{Strings.LIVE_DEV_SETTINGS_FRAMEWORK_CUSTOM}}</option>
                     <option style="text-align:left;" value="Docusaurus">Docusaurus</option>
                 </select>
 

src/nls/root/strings.js

@@ -169,7 +169,7 @@ define({
     "LIVE_DEV_SETTINGS_RELOAD": "Server supports hot reload",
     "LIVE_DEV_SETTINGS_RELOAD_HELP": "Some servers support hot reload where code changes are pushed to page without a full page reload.\nEnable this feature if you do not want {APP_NAME} to reload the page on every save.",
     "LIVE_DEV_SETTINGS_FRAMEWORK": "Server Framework",
-    "LIVE_DEV_SETTINGS_FRAMEWORK_UNKNOWN": "Unknown",
+    "LIVE_DEV_SETTINGS_FRAMEWORK_CUSTOM": "Custom",
     "LIVE_DEV_SETTINGS_FRAMEWORK_PREFERENCES": "Server Framework, currently supports only docusaurus",
 
     "LIVE_DEV_DETACHED_REPLACED_WITH_DEVTOOLS": "Live Preview was canceled because the browser's developer tools were opened",

test/spec/LiveDevelopmentCustomServer-test.js

@@ -169,7 +169,7 @@ define(function (require, exports, module) {
             expect(testWindow.$("#serveRoot").is(":visible")).toBeTrue();
             expect(testWindow.$("#frameworkSelect").is(":visible")).toBeTrue();
             expect(testWindow.$("#hotReloadChk").is(":visible")).toBeTrue();
-            expect(testWindow.$("#frameworkSelect").val()).toBe("unknown");
+            expect(testWindow.$("#frameworkSelect").val()).toBe("Custom");
 
             // close-cancel dialog
             await SpecRunnerUtils.clickDialogButton(Dialogs.DIALOG_BTN_CANCEL);
@@ -470,7 +470,7 @@ define(function (require, exports, module) {
             PreferencesManager.set(PREFERENCE_PROJECT_SERVER_ENABLED, true, PreferencesManager.PROJECT_SCOPE);
             PreferencesManager.set(PREFERENCE_PROJECT_SERVER_URL, "http://localhost:43768", PreferencesManager.PROJECT_SCOPE);
             PreferencesManager.set(PREFERENCE_PROJECT_SERVER_PATH, "", PreferencesManager.PROJECT_SCOPE);
-            PreferencesManager.set(PREFERENCE_PROJECT_PREVIEW_FRAMEWORK, "unknown", PreferencesManager.PROJECT_SCOPE);
+            PreferencesManager.set(PREFERENCE_PROJECT_PREVIEW_FRAMEWORK, "Custom", PreferencesManager.PROJECT_SCOPE);
             PreferencesManager.set(PREFERENCE_PROJECT_SERVER_HOT_RELOAD_SUPPORTED, true, PreferencesManager.PROJECT_SCOPE);
 
             await awaitsForDone(SpecRunnerUtils.openProjectFiles(["readme.md"]),
@@ -499,7 +499,7 @@ define(function (require, exports, module) {
             PreferencesManager.set(PREFERENCE_PROJECT_SERVER_ENABLED, true, PreferencesManager.PROJECT_SCOPE);
             PreferencesManager.set(PREFERENCE_PROJECT_SERVER_URL, "http://localhost:43768", PreferencesManager.PROJECT_SCOPE);
             PreferencesManager.set(PREFERENCE_PROJECT_SERVER_PATH, sub, PreferencesManager.PROJECT_SCOPE);
-            PreferencesManager.set(PREFERENCE_PROJECT_PREVIEW_FRAMEWORK, "unknown", PreferencesManager.PROJECT_SCOPE);
+            PreferencesManager.set(PREFERENCE_PROJECT_PREVIEW_FRAMEWORK, "Custom", PreferencesManager.PROJECT_SCOPE);
             PreferencesManager.set(PREFERENCE_PROJECT_SERVER_HOT_RELOAD_SUPPORTED, supportsHotReload, PreferencesManager.PROJECT_SCOPE);
             await awaits(1000); // this is here so that the preferences json is properly created and loaded
             return testTempDir;