test: with extension registry cache using file

Author: abose

src/extensibility/ExtensionManager.js

@@ -61,8 +61,10 @@ define(function (require, exports, module) {
     // next update. This migration code can be removed after July 2025(6 Months).
     localStorage.removeItem(EXTENSION_REGISTRY_LOCAL_STORAGE_KEY);
 
+    const REGISTRY_CACHE_FILE = Phoenix.isTestWindow ?
+        "test_registry_cache.json" : "registry_cache.json";
     const REGISTRY_CACHE_PATH = path.normalize(
-        Phoenix.app.getExtensionsDirectory() + "/" + "registry_cache.json");
+        Phoenix.app.getExtensionsDirectory() + "/" + REGISTRY_CACHE_FILE);
     function _getCachedRegistry() {
         // never rejects
         return new Promise((resolve) => {
@@ -89,6 +91,11 @@ define(function (require, exports, module) {
         });
     }
 
+    function _removeCachedRegistry() {
+        const registryFile = FileSystem.getFileForPath(REGISTRY_CACHE_PATH);
+        return registryFile.unlinkAsync();
+    }
+
     // semver.browser is an AMD-compatible module
     var semver = require("thirdparty/semver.browser");
 
@@ -964,6 +971,8 @@ define(function (require, exports, module) {
     exports._reset                  = _reset;
     exports._setExtensions          = _setExtensions;
     if(Phoenix.isTestWindow){
-        exports.EXTENSION_REGISTRY_LOCAL_STORAGE_KEY = EXTENSION_REGISTRY_LOCAL_STORAGE_KEY;
+        exports._getCachedRegistry = _getCachedRegistry;
+        exports._putCachedRegistry = _putCachedRegistry;
+        exports._removeCachedRegistry = _removeCachedRegistry;
     }
 });

test/spec/ExtensionManager-test.js

@@ -176,9 +176,9 @@ define(function (require, exports, module) {
             });
 
             it("should registry update cache registry locally", async function () {
-                localStorage.removeItem(ExtensionManager.EXTENSION_REGISTRY_LOCAL_STORAGE_KEY);
+                await ExtensionManager._removeCachedRegistry();
                 await awaitsForDone(ExtensionManager.downloadRegistry(true), "fetching registry");
-                expect(localStorage.getItem(ExtensionManager.EXTENSION_REGISTRY_LOCAL_STORAGE_KEY)).not.toBeNull();
+                expect(await ExtensionManager._getCachedRegistry()).not.toBeNull();
             });
 
             it("should fail if it can't access the registry", async function () {
@@ -419,7 +419,7 @@ define(function (require, exports, module) {
                 var model;
 
                 beforeEach(async function () {
-                    localStorage.removeItem(ExtensionManager.EXTENSION_REGISTRY_LOCAL_STORAGE_KEY);
+                    await ExtensionManager._removeCachedRegistry();
                     mockRegistry = JSON.parse(mockRegistryForSearch);
                     model = new ExtensionManagerViewModel.RegistryViewModel();
                     await awaitsForDone(model.initialize(), "model initialization");
@@ -515,7 +515,7 @@ define(function (require, exports, module) {
                 var model;
 
                 beforeEach(async function () {
-                    localStorage.removeItem(ExtensionManager.EXTENSION_REGISTRY_LOCAL_STORAGE_KEY);
+                    await ExtensionManager._removeCachedRegistry();
                     mockRegistry = JSON.parse(mockRegistryThemesText);
                     model = new ExtensionManagerViewModel.ThemesViewModel();
                     await awaitsForDone(model.initialize(), "model initialization");