chore: integration tests for external style sheets

abose · abose · commit bd169715ada5 · 2024-04-23T00:04:30.000+05:30
diff --git a/src/extensions/default/HTMLCodeHints/integ-tests.js b/src/extensions/default/HTMLCodeHints/integ-tests.js
@@ -286,6 +286,14 @@ define(function (require, exports, module) {
             await _validateCssEdit("cssLive1.scss");
         });
 
+        it("should get external https css style sheet", async function () {
+            await openFile("htmlOther/externalStyle.html", true);
+            await awaitsFor(async function () {
+                const allSelectors = await CSSUtils.getAllCssSelectorsInProject();
+                return allSelectors.includes(".devicon-aarch64-original-wordmark");
+            }, "external style sheet hints to be loaded");
+        });
+
         async function _testCssClassHintInFile(htmlLikeFile) {
             await openFile(htmlLikeFile, true);
             await openFile("cssLive.css", true);
diff --git a/src/language/CSSUtils.js b/src/language/CSSUtils.js
@@ -1954,7 +1954,7 @@ define(function (require, exports, module) {
         cacheInProgress.delete(link);
     }
 
-    const MAX_ALLOWED_EXTERNAL_STYLE_SHEETS = 20;
+    const MAX_ALLOWED_EXTERNAL_STYLE_SHEETS = 30;
 
     /**
      * html files may have embedded link style sheets to external CDN urls. We will parse them to get all selectors.
diff --git a/test/spec/LiveDevelopment-MultiBrowser-test-files/htmlOther/externalStyle.html b/test/spec/LiveDevelopment-MultiBrowser-test-files/htmlOther/externalStyle.html
@@ -0,0 +1,19 @@
+<!DOCTYPE html>
+<html lang="en">
+<head>
+    <meta charset="UTF-8">
+    <title>inline styles test</title>
+    <link rel="stylesheet" type="text/css"
+            href="https://cdn.jsdelivr.net/gh/devicons/devicon@latest/devicon.min.css" />
+    <style>
+        .integratedStyle {
+            color: blue;
+        }
+    </style>
+</head>
+<body>
+    <div class="integratedStyle">
+        this file has integrated html styles
+    </div>
+</body>
+</html>

Original file line number	Diff line number	Diff line change
`@@ -1954,7 +1954,7 @@ define(function (require, exports, module) {`
`1954`	`1954`	`cacheInProgress.delete(link);`
`1955`	`1955`	`}`
`1956`	`1956`
`1957`		`- const MAX_ALLOWED_EXTERNAL_STYLE_SHEETS = 20;`
	`1957`	`+ const MAX_ALLOWED_EXTERNAL_STYLE_SHEETS = 30;`
`1958`	`1958`
`1959`	`1959`	`/**`
`1960`	`1960`	`* html files may have embedded link style sheets to external CDN urls. We will parse them to get all selectors.`