fix: bugsnag errors in git workflows due to race conditions

The catch block was attached after a delay in some cases and errors before attaching the
catch block in progress dialog used to get treated as uncaught exceptions and get logged in bugsnag
fixed by modifying the timing chain and have a catch handler attached to promise at first itself.

Author: abose

src/extensions/default/Git/src/dialogs/Progress.js

@@ -85,16 +85,17 @@ define(function (require, exports) {
                 onProgress();
             }
 
+            let finalValue, finalError;
             function finish() {
                 finished = true;
                 if (dialog) {
                     dialog.close();
                 }
-                promise.then(function (val) {
-                    resolve(val);
-                }).catch(function (err) {
-                    reject(err);
-                });
+                if(finalError){
+                    reject(finalError);
+                } else {
+                    resolve(finalValue);
+                }
             }
 
             if (!options.preDelay) {
@@ -109,17 +110,24 @@ define(function (require, exports) {
             progressTracker.on(`${Events.GIT_PROGRESS_EVENT}.progressDlg`, (_evt, data)=>{
                 onProgress(data);
             });
-            promise.finally(function () {
-                progressTracker.off(`${Events.GIT_PROGRESS_EVENT}.progressDlg`);
-                onProgress("Finished!");
-                if (!options.postDelay || !dialog) {
-                    finish();
-                } else {
-                    setTimeout(function () {
+            promise
+                .then(val => {
+                    finalValue = val;
+                })
+                .catch(err => {
+                    finalError = err;
+                })
+                .finally(function () {
+                    progressTracker.off(`${Events.GIT_PROGRESS_EVENT}.progressDlg`);
+                    onProgress("Finished!");
+                    if (!options.postDelay || !dialog) {
                         finish();
-                    }, options.postDelay * 1000);
-                }
-            });
+                    } else {
+                        setTimeout(function () {
+                            finish();
+                        }, options.postDelay * 1000);
+                    }
+                });
 
         });
     }

src/loggerSetup.js

@@ -18,7 +18,7 @@
  *
  */
 
-/*globals Bugsnag, AppConfig, Phoenix*/
+/*globals Bugsnag, AppConfig*/
 // window.AppConfig comes from appConfig.js built by gulp scripts at build time
 
 (function(){
@@ -32,7 +32,7 @@
         "https://dev.phcode.dev", // dev url
         "https://staging.phcode.dev" // staging url
     ];
-    let isBugsnagLoggableURL = false;
+    let isBugsnagLoggableURL = false; // to test bugsnag in dev builds, set this to true
     for(let loggableURL of loggableURLS){
         if(window.location.href.startsWith(loggableURL)){
             isBugsnagLoggableURL = true;