fix: leaky listeners/event handlers in live document

also removed a reset function that doesnt seem to be userd rather than when thne live preview page
was loaded, and at load time, the page is resetted/has no state anyway

Author: abose

src/LiveDevelopment/BrowserScripts/RemoteFunctions.js

@@ -5332,38 +5332,6 @@ function RemoteFunctions(config = {}) {
         cleanupPreviousElementState();
     }
 
-    /**
-     * this is a hard reset function, it resets every live preview edit thing, whether it be UI boxes
-     * highlighting, any timers or anything
-     */
-    function resetState() {
-        _stopAutoScroll();
-
-        if (_hoverHighlight) {
-            _hoverHighlight.clear();
-            _hoverHighlight = null;
-        }
-        if (_clickHighlight) {
-            _clickHighlight.clear();
-            _clickHighlight = null;
-        }
-
-        dismissUIAndCleanupState();
-
-        const allElements = window.document.querySelectorAll(`[${GLOBALS.DATA_BRACKETS_ID_ATTR}]`);
-        for (let i = 0; i < allElements.length; i++) {
-            if (allElements[i]._originalBackgroundColor !== undefined) {
-                clearElementBackground(allElements[i]);
-            }
-        }
-
-        if (config.mode === 'edit') {
-            _hoverHighlight = new Highlight("#c8f9c5", true);
-            _clickHighlight = new Highlight("#cfc", true);
-        }
-    }
-
-
     /**
      * This function is responsible to move the cursor to the end of the text content when we start editing
      * @param {DOMElement} element
@@ -5659,7 +5627,6 @@ function RemoteFunctions(config = {}) {
         "startEditing"          : startEditing,
         "finishEditing"         : finishEditing,
         "dismissUIAndCleanupState" : dismissUIAndCleanupState,
-        "resetState"            : resetState,
         "enableHoverListeners" : enableHoverListeners,
         "handleDownloadEvent" : handleDownloadEvent,
         "showToastMessage" : showToastMessage

src/LiveDevelopment/LiveDevMultiBrowser.js

@@ -435,7 +435,6 @@ define(function (require, exports, module) {
                             const urlString = `${url.origin}${url.pathname}`;
                             if (_liveDocument &&  urlString === _resolveUrl(_liveDocument.doc.file.fullPath)) {
                                 _setStatus(STATUS_ACTIVE);
-                                resetLPEditState();
                             }
                         }
                         Metrics.countEvent(Metrics.EVENT_TYPE.LIVE_PREVIEW, "connect",
@@ -719,17 +718,6 @@ define(function (require, exports, module) {
         }
     }
 
-    /**
-     * this function is to completely reset the live preview edit
-     * its done so that when live preview is opened/popped out, we can re-update the config so that
-     * there are no stale markers and edit works perfectly
-     */
-    function resetLPEditState() {
-        if (_protocol) {
-            _protocol.evaluate("_LD.resetState()");
-        }
-    }
-
     /**
      * Originally unload and reload agents. It doesn't apply for this new implementation.
      * @return {jQuery.Promise} Already resolved promise.

src/LiveDevelopment/MultiBrowserImpl/documents/LiveDocument.js

@@ -64,6 +64,7 @@ define(function (require, exports, module) {
         this._onActiveEditorChange = this._onActiveEditorChange.bind(this);
         this._onCursorActivity = this._onCursorActivity.bind(this);
 
+        EditorManager.off(`activeEditorChange.LiveDocument-${this.doc.file.fullPath}`);
         EditorManager.on(`activeEditorChange.LiveDocument-${this.doc.file.fullPath}`, this._onActiveEditorChange);
 
         if (editor) {
@@ -143,6 +144,7 @@ define(function (require, exports, module) {
 
         if (this.editor) {
             this.setInstrumentationEnabled(true, true);
+            this.editor.off("cursorActivity", this._onCursorActivity);
             this.editor.on("cursorActivity", this._onCursorActivity);
             this.updateHighlight();
         }