chore: signout from browser app working, tested in localhost

abose · abose · commit c979a70f85aa · 2025-08-29T18:07:31.000+05:30
diff --git a/serve-proxy.js b/serve-proxy.js
@@ -25,10 +25,10 @@ let config = {
 // Parse command line arguments
 function parseArgs() {
     const args = process.argv.slice(2);
-    
+
     for (let i = 0; i < args.length; i++) {
         const arg = args[i];
-        
+
         if (arg === '-p' && args[i + 1]) {
             config.port = parseInt(args[i + 1]);
             i++;
@@ -73,38 +73,38 @@ proxy.on('proxyReq', (proxyReq, req) => {
     // Transform localhost:8000 to appear as phcode.dev domain
     const originalReferer = req.headers.referer;
     const originalOrigin = req.headers.origin;
-    
+
     // Set target host
     const accountHost = new URL(ACCOUNT_SERVER).hostname;
     proxyReq.setHeader('Host', accountHost);
-    
+
     // Transform referer from localhost:8000 to phcode.dev
     if (originalReferer && originalReferer.includes('localhost:8000')) {
         const newReferer = originalReferer.replace(/localhost:8000/g, 'phcode.dev');
         proxyReq.setHeader('Referer', newReferer);
     } else if (!originalReferer) {
         proxyReq.setHeader('Referer', 'https://phcode.dev/');
     }
-    
+
     // Transform origin from localhost:8000 to phcode.dev
     if (originalOrigin && originalOrigin.includes('localhost:8000')) {
         const newOrigin = originalOrigin.replace(/localhost:8000/g, 'phcode.dev');
         proxyReq.setHeader('Origin', newOrigin);
     } else if (!originalOrigin) {
         proxyReq.setHeader('Origin', 'https://phcode.dev');
     }
-    
+
     // Ensure HTTPS scheme
     proxyReq.setHeader('X-Forwarded-Proto', 'https');
     proxyReq.setHeader('X-Forwarded-For', req.connection.remoteAddress);
-    
+
 });
 
 // Modify proxy response headers
 proxy.on('proxyRes', (proxyRes, req, res) => {
     // Pass through cache control and other security headers
     // But translate any domain references back to localhost for the browser
-    
+
     const setCookieHeader = proxyRes.headers['set-cookie'];
     if (setCookieHeader) {
         // Transform any phcode.dev domain cookies back to localhost
@@ -113,7 +113,7 @@ proxy.on('proxyRes', (proxyRes, req, res) => {
         });
         proxyRes.headers['set-cookie'] = modifiedCookies;
     }
-    
+
     // Ensure CORS headers if needed
     if (config.cors) {
         proxyRes.headers['Access-Control-Allow-Origin'] = '*';
@@ -153,7 +153,7 @@ function serveStaticFile(req, res, filePath) {
             res.end('File not found');
             return;
         }
-        
+
         if (stats.isDirectory()) {
             // Try to serve index.html from directory
             const indexPath = path.join(filePath, 'index.html');
@@ -168,7 +168,7 @@ function serveStaticFile(req, res, filePath) {
                             res.end('Error reading directory');
                             return;
                         }
-                        
+
                         const html = `
                             <!DOCTYPE html>
                             <html>
@@ -183,56 +183,56 @@ function serveStaticFile(req, res, filePath) {
                             </body>
                             </html>
                         `;
-                        
+
                         const headers = {
                             'Content-Type': 'text/html',
                             'Content-Length': Buffer.byteLength(html)
                         };
-                        
+
                         if (!config.cache) {
                             headers['Cache-Control'] = 'no-cache, no-store, must-revalidate';
                             headers['Pragma'] = 'no-cache';
                             headers['Expires'] = '0';
                         }
-                        
+
                         if (config.cors) {
                             headers['Access-Control-Allow-Origin'] = '*';
                             headers['Access-Control-Allow-Methods'] = 'GET, POST, PUT, DELETE, OPTIONS';
                             headers['Access-Control-Allow-Headers'] = 'Origin, X-Requested-With, Content-Type, Accept, Authorization, Cache-Control';
                         }
-                        
+
                         res.writeHead(200, headers);
                         res.end(html);
                     });
                 }
             });
             return;
         }
-        
+
         // Serve file
         const mimeType = getMimeType(filePath);
         const headers = {
             'Content-Type': mimeType,
             'Content-Length': stats.size
         };
-        
+
         if (!config.cache) {
             headers['Cache-Control'] = 'no-cache, no-store, must-revalidate';
             headers['Pragma'] = 'no-cache';
             headers['Expires'] = '0';
         }
-        
+
         if (config.cors) {
             headers['Access-Control-Allow-Origin'] = '*';
             headers['Access-Control-Allow-Methods'] = 'GET, POST, PUT, DELETE, OPTIONS';
             headers['Access-Control-Allow-Headers'] = 'Origin, X-Requested-With, Content-Type, Accept, Authorization, Cache-Control';
         }
-        
+
         res.writeHead(200, headers);
-        
+
         const stream = fs.createReadStream(filePath);
         stream.pipe(res);
-        
+
         stream.on('error', (err) => {
             res.writeHead(500, { 'Content-Type': 'text/plain' });
             res.end('Error reading file');
@@ -243,7 +243,7 @@ function serveStaticFile(req, res, filePath) {
 // Create HTTP server
 const server = http.createServer((req, res) => {
     const parsedUrl = url.parse(req.url, true);
-    
+
     // Handle CORS preflight
     if (req.method === 'OPTIONS' && config.cors) {
         res.writeHead(200, {
@@ -254,20 +254,20 @@ const server = http.createServer((req, res) => {
         res.end();
         return;
     }
-    
+
     // Check if this is a proxy request
     if (parsedUrl.pathname.startsWith('/proxy/accounts')) {
         // Extract the path after /proxy/accounts
         const targetPath = parsedUrl.pathname.replace('/proxy/accounts', '');
         const originalUrl = req.url;
-        
+
         // Modify the request URL for the proxy
         req.url = targetPath + (parsedUrl.search || '');
-        
+
         if (!config.silent) {
             console.log(`[PROXY] ${req.method} ${originalUrl} -> ${ACCOUNT_SERVER}${req.url}`);
         }
-        
+
         // Proxy the request
         proxy.web(req, res, {
             target: ACCOUNT_SERVER,
@@ -276,23 +276,23 @@ const server = http.createServer((req, res) => {
         });
         return;
     }
-    
+
     // Serve static files
     let filePath = path.join(config.root, parsedUrl.pathname);
-    
+
     // Security: prevent directory traversal
     const normalizedPath = path.normalize(filePath);
     if (!normalizedPath.startsWith(config.root)) {
         res.writeHead(403, { 'Content-Type': 'text/plain' });
         res.end('Forbidden');
         return;
     }
-    
+
     if (!config.silent) {
         const clientIp = req.headers['x-forwarded-for'] || req.connection.remoteAddress;
         console.log(`[${new Date().toISOString()}] ${req.method} ${req.url}${config.logIp ? ` (${clientIp})` : ''}`);
     }
-    
+
     // Handle directory requests without trailing slash
     fs.stat(filePath, (err, stats) => {
         if (err) {
@@ -334,4 +334,4 @@ process.on('SIGTERM', () => {
     server.close(() => {
         process.exit(0);
     });
-});
+});
diff --git a/src/services/login-browser.js b/src/services/login-browser.js
@@ -303,14 +303,15 @@ define(function (require, exports, module) {
      * Sign out from browser session
      */
     async function signOutBrowser() {
-        const logoutURL = `${_getAccountBaseURL()}/logoutSession`;
+        const logoutURL = `${_getAccountBaseURL()}/signOut`;
         try {
             const response = await fetch(logoutURL, {
                 method: 'POST',
                 credentials: 'include', // Include cookies
                 headers: {
                     'Content-Type': 'application/json'
-                }
+                },
+                body: JSON.stringify({})
             });
 
             // Always reset local state regardless of server response
@@ -322,7 +323,7 @@ define(function (require, exports, module) {
                     Dialogs.showModalDialog(
                         DefaultDialogs.DIALOG_ID_INFO,
                         Strings.SIGNED_OUT,
-                        Strings.SIGNED_OUT
+                        Strings.SIGNED_OUT_MESSAGE_FRIENDLY
                     );
                     Metrics.countEvent(Metrics.EVENT_TYPE.AUTH, 'browserLogoutOK', 'browser');
                     return;
