ci: remove unused lastTranslatedLocale.json as you need to directly edit expert translations now

Author: abose

docs/02-Adding-Translations.md

@@ -30,10 +30,10 @@ A special folder called the `root` folder houses the reference English translati
 Each `src/nls/<locale>` folder contains similar files, plus a few additional ones:
 1. `expertTranslations.json` where you can provide expert translations for specific English strings to locale strings. This expert translation will be used instead of machine translations if present for a string.
 2. `strings.js` - The full list of translated text for the locale.
-3. Apart from the above two there are 2 autogenerated files that should not be edited: `lastTranslated.json` and `lastTranslatedLocale.json`.
+3. Apart from the above two there are 2 autogenerated files that should not be edited: `lastTranslated.json`.
 
 ## Autogenerated and Manual translations
-When any string changes are made to `src/nls/root/strings.js` or any `src/nls/<locale>/strings.js`, it will automatically be scanned by GitHub Actions and the corresponding translations will be generated. A pull request will be raised with the new translations.
+When any string changes are made to `src/nls/root/strings.js` , it will automatically be scanned by GitHub Actions and the corresponding translations will be generated. A pull request will be raised with the new translations.
 
 You can also run the translation command locally if you have the AWS/GCP keys with the command. This is mostly FYI for phoenix internal devs.
 ```bash
@@ -57,7 +57,6 @@ Say we want to add a new language translation `ko`. We have to do the following
 2. In file `nls/root/strings-app.js` add the line `"LOCALE_KO": "한국어",` where `한국어` is `Korean` in Korean language.
 3. Create a new folder `nls/ko`.
 4. Create a new file `nls/ko/strings.js` with the content `define({});`
-5. Create three new files `nls/ko/lastTranslated.json`, `nls/ko/lastTranslatedLocale.json` and
 `nls/ko/expertTranslations.json` with the content `{}`
 
 Once the code is checked in, the translation will be auto generated.

gulpfile.js/index.js

@@ -65,7 +65,6 @@ function cleanUnwantedFilesInDist() {
     return del([
         'dist/nls/*/expertTranslations.json',
         'dist/nls/*/lastTranslated.json',
-        'dist/nls/*/lastTranslatedLocale.json',
         'dist/nls/*/*.js.map',
         'dist/extensions/default/*/unittests.js.map'
     ]);
@@ -393,7 +392,6 @@ const DISALLOWED_EXTENSIONS_TO_CACHE = ["map", "nuspec", "partial", "pre", "post
 const EXCLUDE_PATTERNS_FROM_CACHE = [
     /src\/nls\/.*expertTranslations\.json$/,
     /src\/nls\/.*lastTranslated\.json$/,
-    /src\/nls\/.*lastTranslatedLocale\.json$/,
     /extensions\/registry\/registry\.json$/
 ];
 

gulpfile.js/translateStrings.js

@@ -111,19 +111,14 @@ async function coreAiTranslate(stringsToTranslate, lang) {
  * 1. nls/<lang>/lastTranslated.json holds the last root english strings that was automatically translated. This will be
  * used to compare with the current `root/strings.js`. We can determine which strings have changed from the last locale
  * translation done and translate only those changed strings.
- * 2. nls/<lang>/lastTranslatedLocale.json same as `lastTranslated.json` but holds the locale translations instead of
- * english. Holds the last locale strings that was automatically translated.
- * 3. `expertTranslations.json` is a dictionary from english string to locale string that can be used to provide manual
+ * 2. `expertTranslations.json` is a dictionary from english string to locale string that can be used to provide manual
  * expert translations. When translating, we will check for an available translation in the expert translation json
  * before calling google/aws translate. This file is also auto updated when someone provides a translation override
  * in a specific locale.
  *
  * ## How we translate
  * First we deduce if there are any manual translations done in `<locale>/strings.js` as users can explicitly provide
- * translations like these: https://github.com/phcode-dev/phoenix/pull/588 . We check the `<lang>/strings.js` with
- * `<lang>/lastTranslatedLocale.json` to determine translation overrides and update the `expertTranslations.json`
- * dictionary with the overrides.
- *
+ * translations like these: https://github.com/phcode-dev/phoenix/pull/588 .
  * Then, we figure out the changed strings that needs translation by comparing `root/strings.js` with
  * `<lang>/lastTranslated.json`. Then we translate with aws/google translate.
  *
@@ -195,7 +190,6 @@ async function _processLang(lang) {
     let fileToWrite = `${FILE_HEADER}${translatedStringsJSON}${FILE_FOOTER}`;
     fs.writeFileSync(`src/nls/${lang}/strings.js`, fileToWrite);
     fs.writeFileSync(`src/nls/${lang}/lastTranslated.json`, JSON.stringify(updatedLastTranslatedJSON, null, 2));
-    fs.writeFileSync(`src/nls/${lang}/lastTranslatedLocale.json`, JSON.stringify(translations, null, 2));
 }
 
 async function translate() {