chore: signout working

Author: abose

src/nls/root/strings.js

@@ -1569,10 +1569,13 @@ define({
     // login
     "SIGNED_OUT": "You have been signed out.",
     "SIGNED_OUT_MESSAGE": "You have been signed out of your {APP_NAME} account. Please sign in again to continue.",
+    "SIGNED_OUT_MESSAGE_FRIENDLY": "Thank you for using {APP_NAME}. See you soon!",
     "SIGNED_IN_OFFLINE_TITLE": "Offline - Cannot Sign In",
     "SIGNED_IN_OFFLINE_MESSAGE": "Please connect to the internet to sign in to {APP_NAME}.",
     "SIGNED_IN_FAILED_TITLE": "Cannot Sign In",
     "SIGNED_IN_FAILED_MESSAGE": "Something went wrong while trying to sign in. Please try again.",
+    "SIGNED_OUT_FAILED_TITLE": "Failed to Sign Out",
+    "SIGNED_OUT_FAILED_MESSAGE": "Something went wrong while trying to sign out. Please try again.",
     "VALIDATION_CODE_TITLE": "Sign In Verification Code",
     "VALIDATION_CODE_MESSAGE": "Please use this Verification code to sign in to your {APP_NAME} account:",
     "COPY_VALIDATION_CODE": "Copy Code",

src/services/login.js

@@ -94,6 +94,12 @@ define(function (require, exports, module) {
         }
     }
 
+    async function _resetAccountLogin() {
+        isLoggedInUser = false;
+        ProfileMenu.setNotLoggedIn();
+        await KernalModeTrust.removeCredential(KernalModeTrust.CRED_KEY_API);
+    }
+
     async function _verifyLogin() {
         const savedUserProfile = await KernalModeTrust.getCredential(KernalModeTrust.CRED_KEY_API);
         if(!savedUserProfile){
@@ -122,14 +128,13 @@ define(function (require, exports, module) {
         }
         // some error happened.
         if(resolveResponse.err === ERR_INVALID) { // the api key is invalid, we need to logout and tell user
-            isLoggedInUser = false;
-            ProfileMenu.setNotLoggedIn();
+            _resetAccountLogin()
+                .catch(console.error);
             Dialogs.showModalDialog(
                 DefaultDialogs.DIALOG_ID_ERROR,
                 Strings.SIGNED_OUT,
                 Strings.SIGNED_OUT_MESSAGE
             );
-            await KernalModeTrust.removeCredential(KernalModeTrust.CRED_KEY_API);
         }
         // maybe some intermittent network error, ERR_RETRY_LATER is here. do nothing
     }
@@ -253,6 +258,50 @@ define(function (require, exports, module) {
         NativeApp.openURLInDefaultBrowser(appSignInURL);
     }
 
+    async function signOutAccount() {
+        try {
+            const resolveURL = `${Phoenix.config.account_url}logoutSession`;
+            let input = {
+                appSessionID: userProfile.apiKey
+            };
+
+            const response = await fetch(resolveURL, {
+                method: 'POST',
+                headers: {
+                    'Content-Type': 'application/json'
+                },
+                body: JSON.stringify(input)
+            });
+
+            const result = await response.json();
+
+            if (!result.isSuccess) {
+                console.error('Error logging out', result);
+                Dialogs.showModalDialog(
+                    DefaultDialogs.DIALOG_ID_ERROR,
+                    Strings.SIGNED_OUT_FAILED_TITLE,
+                    Strings.SIGNED_OUT_FAILED_MESSAGE
+                );
+                return;
+                // todo raise metrics
+            }
+            await _resetAccountLogin();
+            Dialogs.showModalDialog(
+                DefaultDialogs.DIALOG_ID_INFO,
+                Strings.SIGNED_OUT,
+                Strings.SIGNED_OUT_MESSAGE_FRIENDLY
+            );
+        } catch (error) {
+            console.error("Network error. Could not log out session.", error);
+            Dialogs.showModalDialog(
+                DefaultDialogs.DIALOG_ID_ERROR,
+                Strings.SIGNED_OUT_FAILED_TITLE,
+                Strings.SIGNED_OUT_FAILED_MESSAGE
+            );
+            // todo raise metrics
+        }
+    }
+
     function init() {
         ProfileMenu.init();
         if(!Phoenix.isNativeApp){
@@ -273,6 +322,7 @@ define(function (require, exports, module) {
     // kernal exports
     secureExports.isLoggedIn = isLoggedIn;
     secureExports.signInToAccount = signInToAccount;
+    secureExports.signOutAccount = signOutAccount;
 
     // public exports
     exports.isLoggedIn = isLoggedIn;

src/services/profile-menu.js

@@ -62,15 +62,13 @@ define(function (require, exports, module) {
     };
 
     function _handleSignInBtnClick() {
-        console.log("User clicked sign in button");
         closePopup(); // need to close the current popup to show the new one
         KernalModeTrust.loginService.signInToAccount();
     }
 
     function _handleSignOutBtnClick() {
-        console.log("User clicked sign out");
         closePopup();
-        showLoginPopup();
+        KernalModeTrust.loginService.signOutAccount();
     }
 
     function _handleContactSupportBtnClick() {